Page MenuHomePhabricator
Create Task
Maniphest T236589

Page Previews Storybook not available on doc.wikimedia.org and documentation a bit broken
Closed, ResolvedPublic
Actions

Description

Just as we do for MobileFrontend, we should publish our page previews storybook so @alexhollender and @Volker_E can at a glance review Page previews designs. It would also be useful for onboarding new volunteers/team members.

Looking at https://doc.wikimedia.org/Popups/master/js/js/

  • I'm missing Page Previews Storybook that was part one of first storybooks written there
  • an image is missing on that page

Details

SubjectRepoBranchLines +/-
Storybook: Images should be relative urismediawiki/extensions/Popupsmaster+26 -22
Storybook: Copy over static filesmediawiki/extensions/Popupsmaster+2 -2
Use local files for storybookmediawiki/extensions/Popupsmaster+84 -23
Publish storybook now we are using more modern nodemediawiki/extensions/Popupsmaster+18 K -22 K
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Oct 26 2019, 4:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2019, 4:00 AM
Volker_E added a project: Documentation.Oct 26 2019, 4:01 AM
Jdlrobson merged a task: T213226: Publish Popups storybook to docs.Oct 27 2019, 4:28 PM
Jdlrobson added subscribers: Jdlrobson, WMDE-leszek, greg and 6 others.
gerritbot added a comment.Oct 28 2019, 7:05 PM

Change 534498 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Publish storybook now we are using more modern node

https://gerrit.wikimedia.org/r/534498

gerritbot added a project: Patch-For-Review.Oct 28 2019, 7:05 PM
Jdlrobson assigned this task to ovasileva.Oct 28 2019, 7:05 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson triaged this task as Medium priority.Oct 30 2019, 5:00 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: • alexhollender_WMF.
• Niedzielski awarded a token.Nov 5 2019, 4:04 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog.Nov 12 2019, 1:40 PM
Jdrewniak moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Nov 14 2019, 10:27 AM

Since there's already a patch up for this task (thank you @Jdlrobson!) I think this can be estimated and moved to the code-review column.

Jdlrobson moved this task from Needs Code Review to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Nov 14 2019, 2:47 PM

Let's be wary of process and estimate before jumping into code review.

ovasileva moved this task from Upcoming to Needs Analysis on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Nov 14 2019, 6:11 PM
Jdlrobson added a comment.Nov 14 2019, 6:11 PM

Possibly blocked on T213223

Jdlrobson mentioned this in T235221: php-composer-security-docker currently failing with "curl: command not found" error.Nov 25 2019, 6:24 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 11 2019, 11:09 PM
Jdlrobson removed ovasileva as the assignee of this task.Dec 11 2019, 11:35 PM
Jdlrobson added a subscriber: ovasileva.

This is unblocked now and we can review at our leisure.

gerritbot added a comment.Dec 12 2019, 12:11 AM

Change 534498 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Publish storybook now we are using more modern node

https://gerrit.wikimedia.org/r/534498

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 12:11 AM
Jdlrobson moved this task from Upcoming to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 12 2019, 12:29 AM

A storybook is born - https://doc.wikimedia.org/Popups/master/js/ui/?path=/story/thumbnails--landscape-thin-thumbnail

Images are not displaying there but I think T213223#5734249 is the appropriate place to talk through that.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 12 2019, 1:00 AM
Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 12 2019, 7:23 PM
gerritbot added a comment.Dec 12 2019, 7:25 PM

Change 556772 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Use local files for storybook

https://gerrit.wikimedia.org/r/556772

gerritbot added a project: Patch-For-Review.Dec 12 2019, 7:25 PM
gerritbot added a comment.Dec 12 2019, 8:43 PM

Change 556772 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Use local files for storybook

https://gerrit.wikimedia.org/r/556772

gerritbot added a comment.Dec 12 2019, 9:09 PM

Change 556813 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Storybook: Copy over static files

https://gerrit.wikimedia.org/r/556813

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 12 2019, 9:38 PM
gerritbot added a comment.Dec 12 2019, 9:44 PM

Change 556813 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Storybook: Copy over static files

https://gerrit.wikimedia.org/r/556813

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 10:10 PM
gerritbot added a comment.Dec 12 2019, 10:39 PM

Change 556824 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Storybook: Images should be relative uris

https://gerrit.wikimedia.org/r/556824

gerritbot added a project: Patch-For-Review.Dec 12 2019, 10:39 PM
gerritbot added a comment.Dec 13 2019, 2:05 AM

Change 556824 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Storybook: Images should be relative uris

https://gerrit.wikimedia.org/r/556824

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 2:10 AM
Jdlrobson added a comment.Dec 13 2019, 6:00 PM

Documentation is live at https://doc.wikimedia.org/Popups/master/js/ui/

Jdlrobson assigned this task to Volker_E.Dec 16 2019, 6:16 PM

Volker can you check out the docs and if you can't find any issues please resolve this task? Thanks!

Volker_E closed this task as Resolved.Dec 19 2019, 1:39 AM
Volker_E reassigned this task from Volker_E to Jdlrobson.

Looks and works like a charme now. Storybook for the win.

phuedx mentioned this in T266797: Fix page preview renderings in storybook?.Jan 8 2021, 12:01 PM
Jdlrobson mentioned this in T271763: Give Popups storybook instance some love.Jan 11 2021, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL