Page MenuHomePhabricator
Create Task
Maniphest T239873

[Pre-deployment testing] Clicking on edit on "Talk:Reply test" page, gives error "Uncaught TypeError: Cannot read property 'range' of undefined"
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Go to the Reply test page on our prototype server: http://visualeditor-prototype.wmflabs.org/wiki/Talk:Reply_test
  1. Click on any Edit button/Section Edit link

Observed Result :

The following error appears.

Screen Shot 2019-12-04 at 2.44.54 PM.png (590×1 px, 200 KB)

Details

SubjectRepoBranchLines +/-
Don't load DT on edit pagesmediawiki/extensions/DiscussionToolsmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Dec 4 2019, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2019, 10:45 PM
matmarex added projects: OWC2020, DiscussionTools.Dec 5 2019, 1:52 AM
Ryasmeen mentioned this in T239865: [Pre-deployment testing] Same reply can get posted multiple times if you click on "Reply" button multiple times.Dec 5 2019, 9:56 PM
Ryasmeen added a parent task: T239961: QA Replying v1.0 on prototype server.Dec 6 2019, 12:41 AM
Esanders added a comment.Dec 9 2019, 2:24 PM

We need to avoid running the code on edit pages.

gerritbot added a comment.Dec 9 2019, 2:44 PM

Change 555954 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Don't load DT on edit pages

https://gerrit.wikimedia.org/r/555954

gerritbot added a project: Patch-For-Review.Dec 9 2019, 2:44 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Dec 9 2019, 2:44 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Dec 9 2019, 7:24 PM

Change 555954 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Don't load DT on edit pages

https://gerrit.wikimedia.org/r/555954

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 9 2019, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2019, 8:10 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Dec 9 2019, 9:07 PM
Ryasmeen moved this task from QA to Code review on the VisualEditor (Current work) board.Dec 11 2019, 10:11 PM

This is still not fixed on protoype server, please move it to QA column when it's ready to test.

Ryasmeen added a project: Verified.Dec 12 2019, 8:29 PM
Ryasmeen moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Dec 24 2019, 6:14 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 24 2019, 6:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits