Page MenuHomePhabricator
Create Task
Maniphest T239865

[Pre-deployment testing] Same reply can get posted multiple times if you click on "Reply" button multiple times
Closed, ResolvedPublic
Actions

Description

Same reply can get posted multiple times if you click on "Reply" button multiple times.

Screen Shot 2019-12-04 at 1.49.59 PM.png (518×985 px, 161 KB)

Details

SubjectRepoBranchLines +/-
Disable buttons while postingmediawiki/extensions/DiscussionToolsmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Dec 4 2019, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2019, 9:51 PM
matmarex added projects: OWC2020, DiscussionTools.Dec 5 2019, 1:52 AM
ppelberg merged a task: T239861: Bug: Not able to post comment on beta.EditedDec 5 2019, 6:32 PM
ppelberg added subscribers: Enterprisey, TheDJ.

Provisionally merging T239861 in as a duplicate of this task. Per our discussion in today's stand: let's see if resolving this task (T239865) also takes care of T239861.

Ryasmeen added a comment.EditedDec 5 2019, 9:56 PM

@ppelberg: did you mean to merge T239861 to T239864 instead. Because this one seems like a different issue to me. T239864 is about not being able to post a comment and this one is about it being posted multiple times.

ppelberg added a comment.EditedDec 5 2019, 11:12 PM
In T239865#5716892, @Ryasmeen wrote:

@ppelberg: did you mean to merge T239861 to T239864 instead. Because this one seems like a different issue to me. T239864 is about not being able to post a comment and this one is about it being posted multiple times.

Yikes. You're right. Good catch! This should now be fixed. See: T239864#5717015

Ryasmeen added a parent task: T239961: QA Replying v1.0 on prototype server.Dec 6 2019, 12:41 AM
matmarex mentioned this in T239864: [Pre-deployment testing] Getting error " Uncaught TypeError: Cannot read property 'then' of undefined" while replying to a nested reply.Dec 7 2019, 12:46 AM
gerritbot added a comment.Dec 9 2019, 1:42 PM

Change 555939 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Disable buttons while posting

https://gerrit.wikimedia.org/r/555939

gerritbot added a project: Patch-For-Review.Dec 9 2019, 1:42 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Dec 9 2019, 1:42 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Dec 9 2019, 7:17 PM

Change 555939 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Disable buttons while posting

https://gerrit.wikimedia.org/r/555939

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 9 2019, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2019, 8:10 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Dec 9 2019, 9:07 PM
Ryasmeen moved this task from QA to Code review on the VisualEditor (Current work) board.Dec 11 2019, 10:10 PM

This is still not fixed on protoype server, please move it to QA column when it's ready to test.

Ryasmeen moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Dec 12 2019, 8:27 PM
Ryasmeen added a project: Verified.
ppelberg closed this task as Resolved.Dec 24 2019, 6:15 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 24 2019, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits