Page MenuHomePhabricator
Create Task
Maniphest T240062

Extract components from VectorTemplate to Mustache files
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
• Niedzielski
Authored By
• Niedzielski
Dec 7 2019, 12:33 AM
Tags
Referenced Files
F31541769: ezgif.com-optimize (1).gif
Jan 31 2020, 11:50 AM
F31541784: ezgif.com-optimize (3).gif
Jan 31 2020, 11:50 AM
F31541796: Selenium language test page - Wikipedia, the free encyclopedia.gif
Jan 31 2020, 11:50 AM
F31541789: Wikipedia.gif
Jan 31 2020, 11:50 AM
F31541805: en.wikipedia.beta.wmflabs.org_wiki_Selenium_language_test_page(iPad).png
Jan 31 2020, 11:50 AM
Subscribers
Aklapper
Edtadros
Jdlrobson
Mainframe98
• Niedzielski
ovasileva
pmiazga
polishdeveloper

Description

Move inline HTML from VectorTemplate.php to distinct Mustache files.

Acceptance criteria
  • Isolate HTML from renderVariantsComponent() to VariantList.mustache. (VectorMenu)
  • Isolate HTML from renderActionsComponent() to PageActionMenu.mustache. (VectorTabs)
  • Isolate HTML from renderPersonalComponent() to UserMenu.mustache. (PersonalMenu)
  • Add QA steps
QA

Visit 2 random pages on desktop site as a logged in user on https://en.wikipedia.beta.wmflabs.org/

QA Results

ACStatusDetails
1✅T240062#5841639
2✅T240062#5841639
3✅T240062#5841639
4✅T240062#5841639
5✅T240062#5841639
6✅T240062#5841639
7✅T240062#5841639
8❓T240062#5841639
9✅T240062#5841639
10✅T240062#5841639
11✅T240062#5841639

Details

SubjectRepoBranchLines +/-
Dev: Complete initial porting of Vector to Mustachemediawiki/skins/Vectormaster+80 -45
Fix uerlangattributes echoing output from PersonalMenu componentmediawiki/skins/Vectormaster+1 -1
Deprecation: Deprecate Vector specific hooksmediawiki/skins/Vectormaster+2 -2
Dev: Break Footer out into templatemediawiki/skins/Vectormaster+90 -41
Dev: Include closed body and html tags in getTrailmediawiki/skins/Vectormaster+1 -3
Extract Portal mustache component from VectorTemplate.phpmediawiki/skins/Vectormaster+51 -38
SkinTemplateToolboxEnd hook output not displaying in Vectormediawiki/skins/Vectormaster+1 -1
Extract VectorMenu.mustache component from VectorTemplatemediawiki/skins/Vectormaster+50 -46
Extract PersonalMenu,mustache component from VectorTemplatemediawiki/skins/Vectormaster+48 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.Dec 7 2019, 12:33 AM
ovasileva triaged this task as Medium priority.Dec 10 2019, 1:39 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q3); removed Web-Team-Backlog (Kanbanana-2019-20-Q2).Jan 6 2020, 7:05 PM
gerritbot added a comment.Jan 8 2020, 1:52 PM

Change 562829 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Extract VectorMenu.mustache component from VectorTemplate

https://gerrit.wikimedia.org/r/562829

gerritbot added a project: Patch-For-Review.Jan 8 2020, 1:52 PM
gerritbot added a comment.Jan 9 2020, 11:13 AM

Change 563155 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Extract PersonalMenu,mustache component from VectorTemplate

https://gerrit.wikimedia.org/r/563155

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 9 2020, 9:42 PM
gerritbot added a comment.Jan 9 2020, 11:56 PM

Change 563155 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Extract PersonalMenu,mustache component from VectorTemplate

https://gerrit.wikimedia.org/r/563155

ovasileva raised the priority of this task from Medium to High.Jan 10 2020, 12:02 PM
gerritbot added a comment.Jan 10 2020, 12:18 PM

Change 563429 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Fix uerlangattributes echoing output from PersonalMenu component

https://gerrit.wikimedia.org/r/563429

gerritbot added a comment.Jan 10 2020, 1:18 PM

Change 563429 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix uerlangattributes echoing output from PersonalMenu component

https://gerrit.wikimedia.org/r/563429

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Jan 10 2020, 2:01 PM
gerritbot added a comment.Jan 10 2020, 3:03 PM

Change 563466 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Extract Portal mustache component from VectorTemplate.php

https://gerrit.wikimedia.org/r/563466

Jdlrobson moved this task from Upcoming to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 10 2020, 10:10 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.
Jdlrobson subscribed.

Analysis has turned to development which is okay - we're making good progress there! Let's have a quick chat about this on Monday for an estimate but keep going!

ovasileva set the point value for this task to 5.Jan 13 2020, 6:15 PM
gerritbot added a comment.Jan 14 2020, 7:26 PM

Change 562829 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Extract VectorMenu.mustache component from VectorTemplate

https://gerrit.wikimedia.org/r/562829

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 14 2020, 9:51 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.16; 2020-01-21); removed MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 15 2020, 6:26 AM
Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.Jan 15 2020, 5:57 PM
gerritbot added a comment.Jan 16 2020, 10:45 PM

Change 565396 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Dev: Include closed body and html tags in getTrail

https://gerrit.wikimedia.org/r/565396

gerritbot added a comment.Jan 16 2020, 10:46 PM

Change 565397 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Dev: Break Footer out into template

https://gerrit.wikimedia.org/r/565397

Jdlrobson mentioned this in T242674: Add storybook to Vector.Jan 16 2020, 10:47 PM
gerritbot added a comment.Jan 17 2020, 8:01 PM

Change 565396 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Dev: Include closed body and html tags in getTrail

https://gerrit.wikimedia.org/r/565396

polishdeveloper claimed this task.Jan 22 2020, 6:10 PM
polishdeveloper reassigned this task from polishdeveloper to pmiazga.
polishdeveloper subscribed.
gerritbot added a comment.Jan 22 2020, 6:54 PM

Change 565397 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Dev: Break Footer out into template

https://gerrit.wikimedia.org/r/565397

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 22 2020, 7:00 PM
• Niedzielski reassigned this task from pmiazga to Jdlrobson.Jan 23 2020, 6:08 PM
• Niedzielski moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.
• Niedzielski added a subscriber: pmiazga.
gerritbot added a comment.Jan 24 2020, 11:54 AM

Change 567012 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/Vector@master] Deprecation: Deprecate Vector specific hooks

https://gerrit.wikimedia.org/r/567012

gerritbot added a comment.Jan 24 2020, 5:01 PM

Change 567012 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Deprecation: Deprecate Vector specific hooks

https://gerrit.wikimedia.org/r/567012

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 27 2020, 2:53 AM
Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 29 2020, 8:48 AM
Mainframe98 subscribed.Jan 29 2020, 11:12 AM
gerritbot added a comment.Jan 29 2020, 1:55 PM

Change 564754 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Dev: Complete initial porting of Vector to Mustache

https://gerrit.wikimedia.org/r/564754

polishdeveloper added a comment.EditedJan 29 2020, 9:39 PM

@Jdlrobson can you add QA steps and move it to needs QA?

polishdeveloper moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 29 2020, 9:39 PM
Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 29 2020, 11:53 PM

Will do

Jdlrobson updated the task description. (Show Details)Jan 30 2020, 4:01 AM
Restricted Application added a subscriber: Stang. · View Herald TranscriptJan 30 2020, 4:01 AM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jan 30 2020, 4:01 AM
Edtadros reassigned this task from Edtadros to Jdlrobson.Jan 31 2020, 11:50 AM
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: na

Test Artifact(s):

QA Steps

Visit 2 random pages on desktop site as a logged in user on https://en.wikipedia.beta.wmflabs.org/

✅ AC1: Verify footer contains " This page was last edited..."
✅ AC2: Verify footer contains "Text is available under the Creative Commons Attribution-ShareAlike License...".
✅ AC3: Verify footer contains a mobile view link
✅ AC4: Verify sidebar contains interaction, tools, print/export and languages
✅ AC5: verify "move" is available in "more" menu
✅ AC6: verify search shows autocomplete results

ezgif.com-optimize (1).gif (480×416 px, 3 MB)
ezgif.com-optimize (3).gif (480×416 px, 3 MB)

✅ AC7: Verify variant drop down menu shows on https://zh.wikipedia.beta.wmflabs.org/wiki/%E9%A6%96%E9%A1%B5 to right of discussion tab.

Wikipedia.gif (480×416 px, 1 MB)

❓ AC8: Verify Echo notifications shows up in top right
@Jdlrobson I'm not sure if this criteria should be executed on the link in AC7 or the two random pages. Additionally, the only thing that shows up in the top right is log out. I'm assuming the Echo notifications are just the notifications that show up to the right of the logged in user name.

✅ AC9: Verify ULS displays when clicking on language cog on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page
✅ AC10: Verify "add link" displays under list of languages on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page

Selenium language test page - Wikipedia, the free encyclopedia.gif (712×618 px, 2 MB)

✅ AC11: logout and verify UI is more or less the same with the exception of the personal menu in the top right.
The only changes appear to be related to personal menu items (which I assume you meant): notifications, preferences, beta, watchlist, and log out instead of log in.

en.wikipedia.beta.wmflabs.org_wiki_Selenium_language_test_page(iPad).png (2×1 px, 383 KB)

Edtadros updated the task description. (Show Details)Jan 31 2020, 11:52 AM
Jdlrobson reassigned this task from Jdlrobson to ovasileva.Feb 3 2020, 2:57 AM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.

❓ AC8: Verify Echo notifications shows up in top right
@Jdlrobson I'm not sure if this criteria should be executed on the link in AC7 or the two random pages. Additionally, the only thing that shows up in the top right is log out. I'm assuming the Echo notifications are just the notifications that show up to the right of the logged in user name.

LGTM! ✅

Jdlrobson updated the task description. (Show Details)Feb 3 2020, 2:59 AM
Jdlrobson mentioned this in T239248: [EPIC] Divide VectorTemplate into components.Feb 4 2020, 9:18 AM
• Niedzielski claimed this task.Feb 4 2020, 6:08 PM
• Niedzielski closed this task as Resolved.Feb 4 2020, 6:52 PM
Stang unsubscribed.Nov 13 2021, 8:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL