Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 13 2019, 12:04 AM

Description

Visit https://en.m.wikipedia.org/wiki/Main_Page and login.
Make sure AMC is disabled
Open main menu

Expected:
The logout icon label is not visible

Actual:
The logout label is visible

Screen Shot 2019-12-11 at 2.29.50 PM.png (158×230 px, 9 KB)

QA steps

On beta cluster (mobile) en.m.wikipedia.beta.wmflabs.org/ check

logout label on non-AMC logged in has no label
check contributions icon on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdlrobson&mobileaction=toggle_view_mobile when using a mobile device/mobile-like responsive width is not present.

QA Results

AC	Status	Details
1	✅	T240644#5747662
2	✅	T240644#5747662

Details

Subject	Repo	Branch	Lines +/-
Remove unnecessary visited/active color from main-menu links	mediawiki/skins/MinervaNeue	master	+0 -5
Add missing class to contributions icon in page-actions menu	mediawiki/skins/MinervaNeue	master	+1 -1
Prevent text from showing in main-menu logout button	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T240651: User scripts that override the color of icons cause link text to partially appear over icons in mobile view

Event Timeline

Jdlrobson created this task.Dec 13 2019, 12:04 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 13 2019, 12:04 AM

Jdlrobson triaged this task as High priority.Dec 13 2019, 12:04 AM

Change 556838 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Prevent text from showing in main-menu logout button

https://gerrit.wikimedia.org/r/556838

gerritbot added a project: Patch-For-Review.Dec 13 2019, 12:40 AM

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 13 2019, 12:48 AM

Change 556838 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Prevent text from showing in main-menu logout button

https://gerrit.wikimedia.org/r/556838

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 1:10 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 2:00 AM

Ammarpad mentioned this in T240651: User scripts that override the color of icons cause link text to partially appear over icons in mobile view.Dec 13 2019, 3:06 AM

noting that the same issue seems to be happening with the Contributions icon and the Map icon:

The contributions icon still appears broken.
See https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson
Can we get a fix out before the last train?

Jan will write a fix. I will review.

Change 558164 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Add missing class to contributions icon in page-actions menu

https://gerrit.wikimedia.org/r/558164

gerritbot added a project: Patch-For-Review.Dec 16 2019, 6:37 PM

Change 558164 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add missing class to contributions icon in page-actions menu

https://gerrit.wikimedia.org/r/558164

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Dec 16 2019, 7:24 PM

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: Jdrewniak.

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2019, 8:11 PM

still seeing the contributions icon looking odd when logged out

{F31478919}

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

QA steps

On beta cluster (mobile) en.m.wikipedia.beta.wmflabs.org/ check

✅ AC1: logout label on non-AMC logged in has no label

✅ AC2: check contributions icon on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdlrobson&mobileaction=toggle_view_mobile when using a mobile device/mobile-like responsive width is not present.

Edtadros updated the task description. (Show Details)Dec 17 2019, 1:56 PM

Seems fixed (tried on mediawiki while logged out). Resolving.

I'm seeing the label reappear when I click it so I think we missed the hover/active state?

ovasileva moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 18 2019, 5:00 PM

ovasileva removed ovasileva as the assignee of this task.Jan 6 2020, 1:08 PM

Change 562287 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Remove unnecessary visited/active color from main-menu links

https://gerrit.wikimedia.org/r/562287

gerritbot added a project: Patch-For-Review.Jan 6 2020, 3:40 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q3); removed Web-Team-Backlog (Kanbanana-2019-20-Q2).Jan 6 2020, 6:59 PM

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 6 2020, 9:46 PM

Change 562287 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove unnecessary visited/active color from main-menu links

https://gerrit.wikimedia.org/r/562287

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2020, 10:10 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.14; 2020-01-07); removed MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Jan 6 2020, 11:00 PM

Looks fixed to me.

en.m.wikipedia.beta.wmflabs.org_wiki_User_Coentor(iPhone 6_7_8).png (1×750 px, 84 KB)

en.m.wikipedia.beta.wmflabs.org_wiki_Selenium_wikitext_editor_test_0.3386836313461403(iPhone 6_7_8).png (1×750 px, 79 KB)

@Jdlrobson is there any way to check if the map gadget icon is also fixed?

en.m.wikipedia.org_wiki_Port_Sulphur,_Louisiana(iPhone 6_7_8).png (1×750 px, 388 KB)

I've enabled the maps gadget (go to preferences to enable) - but it's still broken - https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain?debug=true - @TheDJ are you still working on the gadget?

@Jdlrobson ok, since it's a gadget I'd be okay with moving this task along without fixing that, however if it's easy to fix at the same time that'd be great.

seems like an easy fix for the gadget:
add mw-ui-icon-with-label-desktop to the link in the button and change the text to "Map" instead of "Show on map" seems to do it.

https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-mobilemaps.js#Interface-protected_edit_request_on_15_January_2020

Amorymeltzer subscribed.Jan 15 2020, 4:03 PM

Moving this along. Known issue that the map icon still has this bug, e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

ovasileva moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 21 2020, 6:11 PM

Resolving

	F31506359: en.m.wikipedia.beta.wmflabs.org_wiki_User_Coentor(iPhone 6_7_8).png
	Jan 9 2020, 6:20 PM

	F31506363: en.m.wikipedia.org_wiki_Port_Sulphur,_Louisiana(iPhone 6_7_8).png
	Jan 9 2020, 6:20 PM

	F31506358: en.m.wikipedia.beta.wmflabs.org_wiki_Selenium_wikitext_editor_test_0.3386836313461403(iPhone 6_7_8).png
	Jan 9 2020, 6:20 PM

	F31474189: Screen Shot 2019-12-11 at 2.29.50 PM.png
	Dec 13 2019, 12:04 AM

	F31479078: T240644-1.png
	Dec 17 2019, 1:55 PM

	F31479080: T240644-2.png
	Dec 17 2019, 1:55 PM

	F31478083: image.png
	Dec 16 2019, 5:37 PM

	F31478081: image.png
	Dec 16 2019, 5:37 PM

Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user pageClosed, ResolvedPublicActions

Description

QA steps

QA Results

Details

Related Objects

Event Timeline

Test Result

QA steps

Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user page
Closed, ResolvedPublic
Actions