Page MenuHomePhabricator
Create Task
Maniphest T242912

Remove $wgEnablePartialBlocks feature flag
Closed, ResolvedPublic2 Estimated Story PointsMar 12 2020
Actions

Description

Following deployment to all production wikis (after a period of time), remove the feature flag.

We'll remove the information banner that is displayed for the most recent adopters of the feature at the same time (T240300).

The flag is used in core, CentralAuth, UploadWizard and WikimediaMessages.

Details

Due Date
Mar 12 2020, 4:00 AM
SubjectRepoBranchLines +/-
Remove $wgEnablePartialBlocks configoperations/mediawiki-configmaster+0 -13
Remove $wgEnablePartialBlocks config and always enable partial blocksmediawiki/coremaster+154 -235
SpecialCentralAuth: Remove check for $wgEnablePartialBlocks configmediawiki/extensions/CentralAuthmaster+1 -1
Remove setting of $wgEnablePartialBlocks config in testmediawiki/extensions/UploadWizardmaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Jan 15 2020, 8:11 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJan 15 2020, 8:11 PM
Jdforrester-WMF subscribed.Jan 15 2020, 8:32 PM
Niharika triaged this task as Medium priority.Jan 15 2020, 10:27 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
Reedy added a project: MediaWiki-General.Jan 16 2020, 12:40 AM
Niharika set the point value for this task to 2.Jan 23 2020, 7:09 PM
Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
Tchanders added a subscriber: Niharika.Mar 2 2020, 3:57 PM

@Niharika When do we want to do this? Asking with https://www.mediawiki.org/wiki/MediaWiki_1.35/Roadmap in mind.

gerritbot added a comment.Mar 2 2020, 4:32 PM

Change 576079 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] WIP Remove $wgEnablePartialBlocks config and always enable partial blocks

https://gerrit.wikimedia.org/r/576079

gerritbot added a project: Patch-For-Review.Mar 2 2020, 4:32 PM
Tchanders claimed this task.Mar 2 2020, 4:33 PM
RhinosF1 subscribed.Mar 2 2020, 4:41 PM
gerritbot added a comment.Mar 2 2020, 4:47 PM

Change 576083 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/UploadWizard@master] Remove setting of $wgEnablePartialBlocks config in test

https://gerrit.wikimedia.org/r/576083

gerritbot added a comment.Mar 2 2020, 4:47 PM

Change 576084 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CentralAuth@master] SpecialCentralAuth: Remove check for $wgEnablePartialBlocks config

https://gerrit.wikimedia.org/r/576084

gerritbot added a comment.Mar 2 2020, 4:51 PM

Change 576086 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[operations/mediawiki-config@master] Remove $wgEnablePartialBlocks config

https://gerrit.wikimedia.org/r/576086

Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Mar 2 2020, 5:01 PM
Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Mar 2 2020, 6:35 PM
Tchanders closed subtask T246685: Fix tests that fail with partial blocks enabled as Resolved.Mar 3 2020, 9:53 PM
gerritbot added a comment.Mar 5 2020, 9:16 PM

Change 576083 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove setting of $wgEnablePartialBlocks config in test

https://gerrit.wikimedia.org/r/576083

gerritbot added a comment.Mar 5 2020, 9:16 PM

Change 576084 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] SpecialCentralAuth: Remove check for $wgEnablePartialBlocks config

https://gerrit.wikimedia.org/r/576084

gerritbot added a comment.Mar 5 2020, 9:41 PM

Change 576079 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgEnablePartialBlocks config and always enable partial blocks

https://gerrit.wikimedia.org/r/576079

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 5 2020, 10:00 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Mar 6 2020, 4:17 PM
ARamirez_WMF set Due Date to Mar 12 2020, 4:00 AM.Mar 13 2020, 6:16 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
dom_walden moved this task from QA/Testing 🐞 to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.Mar 18 2020, 6:17 PM
dom_walden subscribed.

I tried to briefly test each of the parts of the code that have been touched by this change, just to make sure everything appears to be as it was before.

  • Special:Block: Submitting a new partial block and editing an existing partial block.
  • API:Block: Creating a sitewide and partial block.
  • Special:BlockList: Correct block info appears for sitewide and partial blocks.
  • Special:CentralAuth: Tested look of sitewide and partial block info.

Also tested that partial blocks are correctly applied to a blocked user.

Haven't tested:

  • UploadWizard: the change is just to phpunit. The test's results have not changed (I guess).

Testing on https://en.wikipedia.beta.wmflabs.org (various versions starting from MediaWiki 1.35.0-alpha (7531497) 13:28, 16 March 2020).

Tchanders closed this task as Resolved.Mar 20 2020, 12:02 AM
gerritbot added a comment.Apr 15 2020, 2:11 PM

Change 576086 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove $wgEnablePartialBlocks config

https://gerrit.wikimedia.org/r/576086

Stashbot added a comment.Apr 15 2020, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-15T14:14:42Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T242912 Remove wgEnablePartialBlocks config, no longer read (duration: 01m 07s)

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 3:10 PM
JJMC89 edited projects, added MediaWiki-Blocks; removed MediaWiki-General.Apr 25 2020, 8:05 PM
JJMC89 moved this task from Backlog to Partial blocks on the MediaWiki-Blocks board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits