The "thanks" and "undo" links on diffs have same requirements but different conditional appearance
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Krinkle
	Jan 24 2020, 5:41 PM

Description

I regularly browse with a VPN enabled. This means I can't make edits on Wikipedia, and that's fine.

What's interesting however is that nothing in the UI changes when enabling the UI – except the appearance of "thanks" links.

I haven't looked too deeply into this yet, but this suggests two things:

That the "edit" permission checks for the undo links in core (HistoryPager.php) and thank links in the Thanks extension (ThanksHooks.php) are not using the same logic (but presumably have no reason to differ for the use case of generally being IP-blocked
That maybe the Thanks exension is not performing "quick" checks (as we normally do for skin rendering) but something more expensive and/or ad-hoc.

Related Objects

Mentioned In: T308251: Remove an effect of not showing "Thank" link when user IP is blocked
Mentioned Here: T283265: Many Special pages that query user blocks make primary database connections on GET requests

Event Timeline

Krinkle created this task.Jan 24 2020, 5:41 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 24 2020, 5:41 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald Transcript

HistoryPager.php

		if ( … && $permissionManager->quickUserCan( 'edit', $user, $this->getTitle() ) ) {

ThanksHooks.php

		…->getPermissionManager()->isBlockedFrom( $user, $this->getTitle(), true ) // via self::isUserBlockedFromTitle
		&& !$user->isBlockedGlobally()

I could not find a call to isBlockedGlobally or getGlobalBlock in PermissionManager. This suggests global blocks are generally not checked during quick checks for skin rendering logic / on page views.

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Jan 24 2020, 6:28 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM

matej_suchanek mentioned this in T308251: Remove an effect of not showing "Thank" link when user IP is blocked.May 29 2022, 8:02 AM

Unfiltering as a duplicate was reported.

Ref T283265: Many Special pages that query user blocks make primary database connections on GET requests

Tgr moved this task from Inbox to Needs Discussion on the Growth-Team board.May 30 2022, 11:27 PM

MShilova_WMF moved this task from Needs Discussion to Triaged on the Growth-Team board.Aug 9 2022, 4:56 PM

Krinkle moved this task from Perf recommendation to Watching on the Performance-Team (Radar) board.Oct 3 2022, 9:53 PM

Krinkle edited projects, added Design; removed Performance-Team (Radar).Aug 6 2023, 10:40 PM

In T243615#5830032, @Krinkle wrote:

I could not find a call to isBlockedGlobally or getGlobalBlock in PermissionManager. This suggests global blocks are generally not checked during quick checks for skin rendering logic / on page views.

User:isBlockedGlobally is now deprecated, and the Thanks code has been refactored. Maybe this has been fixed in the meantime.

Krinkle removed a project: Sustainability (MediaWiki-MultiDC).Oct 2 2023, 3:01 PM

The "thanks" and "undo" links on diffs have same requirements but different conditional appearanceOpen, MediumPublicActions

Description

Related Objects

Event Timeline

The "thanks" and "undo" links on diffs have same requirements but different conditional appearance
Open, MediumPublic
Actions