Page MenuHomePhabricator
Create Task
Maniphest T245869

Undeleting of an entry (NS=0) is no longer possible in de.wiktionary
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Hi,

today I deleted an entry (NS=0) in de.wiktionary: https://de.wiktionary.org/w/index.php?title=Giga-&action=edit&redlink=1

After deleting it I wanted to restore the entry without the 2 newest versions, which were made by an LTA troll.

However, only the following error message then appears in a red frame:
"[XlA-uwpAICsAACYFCI8AAACI] 2020-02-21 20:38:19: Fataler Ausnahmefehler des Typs „Error“"

After a few tests I found out that this error probably only affects to entries in NS = 0. The error also occurs with entries that have been deleted for a long time.

Best regards.
Udo T.

Details

Stack Trace
2020-02-21 20:38:19 [XlA-uwpAICsAACYFCI8AAACI] mw1322 dewiktionary 1.35.0-wmf.20 exception ERROR: [XlA-uwpAICsAACYFCI8AAACI] /w/index.php?title=Spezial:Wiederherstellen&action=submit   Error from line 148 of /srv/mediawiki/php-1.35.0-wmf.20/extensions/Cognate/src/hooks/CognatePageHookHandler.php: Call to a member function getContent() on null {"exception_id":"XlA-uwpAICsAACYFCI8AAACI","exception_url":"/w/index.php?title=Spezial:Wiederherstellen&action=submit","caught_by":"mwe_handler"} 
[Error Error] (/srv/mediawiki/php-1.35.0-wmf.20/extensions/Cognate/src/hooks/CognatePageHookHandler.php:148) Call to a member function getContent() on null
  #0 /srv/mediawiki/php-1.35.0-wmf.20/extensions/Cognate/src/CognateHooks.php(77): Cognate\CognatePageHookHandler->onArticleUndelete(Title)
  #1 /srv/mediawiki/php-1.35.0-wmf.20/includes/Hooks.php(174): Cognate\CognateHooks::onArticleUndelete(Title, boolean, string, integer, array)
  #2 /srv/mediawiki/php-1.35.0-wmf.20/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
  #3 /srv/mediawiki/php-1.35.0-wmf.20/includes/page/PageArchive.php(758): Hooks::run(string, array)
  #4 /srv/mediawiki/php-1.35.0-wmf.20/includes/page/PageArchive.php(437): PageArchive->undeleteRevisions(array, boolean, string)
  #5 /srv/mediawiki/php-1.35.0-wmf.20/includes/specials/SpecialUndelete.php(1225): PageArchive->undelete(array, string, array, boolean, User)
  #6 /srv/mediawiki/php-1.35.0-wmf.20/includes/specials/SpecialUndelete.php(253): SpecialUndelete->undelete()
  #7 /srv/mediawiki/php-1.35.0-wmf.20/includes/specialpage/SpecialPage.php(575): SpecialUndelete->execute(NULL)
  #8 /srv/mediawiki/php-1.35.0-wmf.20/includes/specialpage/SpecialPageFactory.php(621): SpecialPage->run(NULL)
  #9 /srv/mediawiki/php-1.35.0-wmf.20/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #10 /srv/mediawiki/php-1.35.0-wmf.20/includes/MediaWiki.php(971): MediaWiki->performRequest()
  #11 /srv/mediawiki/php-1.35.0-wmf.20/includes/MediaWiki.php(534): MediaWiki->main()
  #12 /srv/mediawiki/php-1.35.0-wmf.20/index.php(47): MediaWiki->run()
  #13 /srv/mediawiki/w/index.php(3): require(string)
  #14 {main}
SubjectRepoBranchLines +/-
Exit undelete hook early if revision not foundmediawiki/extensions/Cognatewmf/1.35.0-wmf.22+37 -14
Exit undelete hook early if revision not foundmediawiki/extensions/Cognatemaster+37 -14
Customize query in gerrit

Event Timeline

Udo_T created this task.Feb 21 2020, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2020, 8:49 PM
Bugreporter added a project: Wikimedia-production-error.Feb 21 2020, 8:49 PM
Reedy added a project: MediaWiki-Page-deletion.Feb 21 2020, 9:04 PM
Reedy changed the subtype of this task from "Task" to "Production Error".
Reedy added a project: Cognate.
Reedy edited Stack Trace. (Show Details)
Reedy edited Stack Trace. (Show Details)Feb 21 2020, 9:07 PM
Reedy added a project: Wikidata-Campsite.
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 21 2020, 9:07 PM
Addshore subscribed.Feb 24 2020, 9:15 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Feb 24 2020, 9:18 AM
WMDE-leszek subscribed.Feb 24 2020, 9:18 AM
Addshore triaged this task as High priority.Feb 24 2020, 10:27 AM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 24 2020, 11:15 AM
Ladsgroup claimed this task.Feb 24 2020, 11:22 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 24 2020, 11:22 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Feb 24 2020, 12:15 PM
Krinkle moved this task from Untriaged to Feb2020/1.35-wmf.18 on the Wikimedia-production-error board.Feb 29 2020, 8:01 PM
Tarrow claimed this task.Mar 4 2020, 9:45 AM
Tarrow added subscribers: Ladsgroup, Tarrow.

Hope it's ok but I'm taking this over in the attempt to finish what we started rather than picking up new work

gerritbot added a comment.Mar 4 2020, 1:47 PM

Change 576830 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Cognate@master] Exit undelete hook early if revision not found

https://gerrit.wikimedia.org/r/576830

gerritbot added a project: Patch-For-Review.Mar 4 2020, 1:47 PM
gerritbot added a comment.Mar 4 2020, 4:18 PM

Change 576830 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Exit undelete hook early if revision not found

https://gerrit.wikimedia.org/r/576830

gerritbot added a comment.Mar 4 2020, 4:19 PM

Change 576876 had a related patch set uploaded (by Jforrester; owner: Tarrow):
[mediawiki/extensions/Cognate@wmf/1.35.0-wmf.22] Exit undelete hook early if revision not found

https://gerrit.wikimedia.org/r/576876

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 4 2020, 5:00 PM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 5 2020, 10:20 AM
gerritbot added a comment.Mar 5 2020, 11:17 AM

Change 576876 merged by jenkins-bot:
[mediawiki/extensions/Cognate@wmf/1.35.0-wmf.22] Exit undelete hook early if revision not found

https://gerrit.wikimedia.org/r/576876

Stashbot added a comment.Mar 5 2020, 11:25 AM

Mentioned in SAL (#wikimedia-operations) [2020-03-05T11:25:45Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.22/extensions/Cognate: [[gerrit:576876|Exit undelete hook early if revision not found (T245869)]] (duration: 01m 04s)

Ladsgroup added a comment.Mar 5 2020, 11:26 AM

@Udo_T Hey, Can you try now? I'm not admin in any wiktionary project to test it.

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 5 2020, 11:29 AM
Udo_T added a comment.Mar 5 2020, 11:40 AM

Hi @Ladsgroup, undeleting of entries now works again without problems. Thank you very much for fixing the bug.

Best regards
Udo T.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2020, 12:10 PM
Lydia_Pintscher closed this task as Resolved.Mar 5 2020, 1:02 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lydia_Pintscher subscribed.

\o/

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Mar 5 2020, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits