Page MenuHomePhabricator
Create Task
Maniphest T248719

\ParserCache::get remove polymorphic argument
Closed, ResolvedPublic
Actions

Description

ParserCache::get remove polymorphic argument

Use WikiPage instead Page|Article|WikiPage

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/577393/26/includes/parser/ParserCache.php#247

Details

SubjectRepoBranchLines +/-
ParserCache::get - fix wfDeprecated callmediawiki/coreREL1_35+1 -1
ParserCache::get use WikiPage only as argumentmediawiki/coremaster+78 -61
ParserCache::get and extends - use WikiPage instead Article|Pagemediawiki/extensions/FlaggedRevsmaster+10 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Art-Baltai created this task.Mar 27 2020, 11:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2020, 11:43 PM
Aklapper added a project: MediaWiki-Parser.Mar 29 2020, 3:16 PM

@Art-Baltai: Assuming this task is about the MediaWiki-Parser project, hence adding that project tag so other people who don't know or don't care about random team tags can also find this task when searching via projects.

• Pchelolo added a parent task: T239975: Complete WikiPage/Article split and deprecate Page interface.Mar 30 2020, 4:33 PM
Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:04 PM
Peter.ovchyn moved this task from Current sprint Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:04 PM
Peter.ovchyn moved this task from Estimated/Estimation to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.
Helga_sf moved this task from Current sprint Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:05 PM
gerritbot added a comment.Apr 1 2020, 12:17 AM

Change 585055 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/FlaggedRevs@master] ParserCache::get remove polymorphic argument

https://gerrit.wikimedia.org/r/585055

gerritbot added a project: Patch-For-Review.Apr 1 2020, 12:17 AM

Change 584103 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] ParserCache::get use WikiPage only as argument

https://gerrit.wikimedia.org/r/584103

Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Apr 1 2020, 3:18 PM
Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Apr 2 2020, 3:59 PM
• Pchelolo edited projects, added Technical-Debt (Deprecation process); removed Patch-For-Review.Apr 15 2020, 7:02 PM

Calling ParserCache::get with Article was deprecated. Need to wait for 1.36 to remove it.

• Pchelolo moved this task from In Progress/In Review to Blocked on the Platform Team Workboards (S&F Workboard) board.Apr 15 2020, 7:02 PM
• Pchelolo moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Apr 15 2020, 7:13 PM

Change 584103 merged by jenkins-bot:
[mediawiki/core@master] ParserCache::get use WikiPage only as argument

https://gerrit.wikimedia.org/r/584103

gerritbot added a comment.Apr 15 2020, 7:13 PM

Change 585055 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] ParserCache::get and extends - use WikiPage instead Article|Page

https://gerrit.wikimedia.org/r/585055

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 8:01 PM
abi_ added subscribers: Kghbln, abi_.Apr 23 2020, 7:03 AM

During our regular Twn updates, noticed the following incompatibility with SemanticMediaWiki,

[2020-04-22 14:58:13] exception.ERROR: [8a209061a64b161a1b7952fe] /wiki/Support   TypeError from line 133 of /srv/mediawiki/workdir/includes/parser/ParserCache.php: Argument 1 passed to ParserCache::getETag() must be an instance of WikiPage, instance of Article given, called in /srv/mediawiki/workdir/extensions/SemanticMediaWiki/src/MediaWiki/Hooks.php on line 646 {"exception":"[object] (TypeError(code: 0): Argument 1 passed to ParserCache::getETag() must be an instance of WikiPage, instance of Article given, called in /srv/mediawiki/workdir/extensions/SemanticMediaWiki/src/MediaWiki/Hooks.php on line 646 at /srv/mediawiki/workdir/includes/parser/ParserCache.php:133)
[stacktrace]
#0 /srv/mediawiki/workdir/extensions/SemanticMediaWiki/src/MediaWiki/Hooks.php(646): ParserCache->getETag(Object(Article), Object(ParserOptions))
#1 /srv/mediawiki/workdir/includes/HookRunner/HookContainer.php(283): SMW\\MediaWiki\\Hooks->onArticleViewHeader(Object(Article), false, true)
#2 /srv/mediawiki/workdir/includes/HookRunner/HookContainer.php(126): MediaWiki\\HookRunner\\HookContainer->callLegacyHook('ArticleViewHead...', Array, Array, Array)
#3 /srv/mediawiki/workdir/includes/Hooks.php(135): MediaWiki\\HookRunner\\HookContainer->run('ArticleViewHead...', Array, Array)
#4 /srv/mediawiki/workdir/includes/page/Article.php(699): Hooks::run('ArticleViewHead...', Array)
#5 /srv/mediawiki/workdir/extensions/LiquidThreads/pages/TalkpageView.php(61): Article->view()
#6 /srv/mediawiki/workdir/extensions/LiquidThreads/pages/TalkpageView.php(281): TalkpageView->showHeader()
#7 /srv/mediawiki/workdir/extensions/LiquidThreads/classes/Dispatch.php(66): TalkpageView->show()
#8 /srv/mediawiki/workdir/extensions/LiquidThreads/classes/Dispatch.php(222): LqtDispatch::talkpageMain(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#9 /srv/mediawiki/workdir/includes/HookRunner/HookContainer.php(283): LqtDispatch::tryPage(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest), Object(MediaWiki))
#10 /srv/mediawiki/workdir/includes/HookRunner/HookContainer.php(126): MediaWiki\\HookRunner\\HookContainer->callLegacyHook('MediaWikiPerfor...', Array, Array, Array)
#11 /srv/mediawiki/workdir/includes/Hooks.php(135): MediaWiki\\HookRunner\\HookContainer->run('MediaWikiPerfor...', Array, Array)
#12 /srv/mediawiki/workdir/includes/MediaWiki.php(491): Hooks::run('MediaWikiPerfor...', Array)
#13 /srv/mediawiki/workdir/includes/MediaWiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#14 /srv/mediawiki/workdir/includes/MediaWiki.php(973): MediaWiki->performRequest()
#15 /srv/mediawiki/workdir/includes/MediaWiki.php(535): MediaWiki->main()
#16 /srv/mediawiki/workdir/index.php(47): MediaWiki->run()
`

See - https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/e0b192bbdf8c7dc4087694ad0bbb654c92c93e0b/src/MediaWiki/Hooks.php#L644

Ping: @Kghbln

Nikerabbit added a project: affects-translatewiki.net.Apr 23 2020, 2:05 PM
• Pchelolo added a comment.Apr 23 2020, 3:14 PM

This is a bug in SemanticMediawiki - ParserCache::getEtag was always documented to accept WikiPage only, and not Article. The fact it worked with Article passed was a coincidence.

Kghbln added a comment.Apr 23 2020, 5:54 PM

@abi_ Thanks for pinging! Tracked on GitHub / 4741

Art-Baltai added a comment.May 6 2020, 2:46 PM

I want to check the status of this task

@Kghbln Do we have any problem with SemanticMediaWiki TypeError with Hook now?
Can we unblock current task?

Nikerabbit moved this task from Backlog to Mitigated on the affects-translatewiki.net board.May 6 2020, 2:52 PM
Kghbln added a comment.May 6 2020, 3:20 PM

We actually had two pull requests to mitigate the situation:

I'd say we are cool. Thanks also to @abi_ for involving him here!

abi_ added a comment.May 6 2020, 3:32 PM

Yup, we've deployed the latest patches on translatewiki.net, and haven't seen any issues, so I'd say we are good here.

Art-Baltai moved this task from Blocked to Done on the Platform Team Workboards (S&F Workboard) board.May 13 2020, 10:30 PM
WDoranWMF subscribed.May 20 2020, 6:42 PM

@Art-Baltai Can this task be closed since it's done?

Art-Baltai closed this task as Resolved.May 21 2020, 1:17 PM
gerritbot added a comment.Sep 28 2020, 2:38 AM

Change 630406 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@REL1_35] ParserCache::get - fix wfDeprecated call

https://gerrit.wikimedia.org/r/630406

gerritbot added a project: Patch-For-Review.Sep 28 2020, 2:38 AM
gerritbot added a comment.Sep 29 2020, 2:28 PM

Change 630406 merged by jenkins-bot:
[mediawiki/core@REL1_35] ParserCache::get - fix wfDeprecated call

https://gerrit.wikimedia.org/r/630406

ReleaseTaggerBot edited projects, added MW-1.35-notes; removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Sep 29 2020, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL