Page MenuHomePhabricator
Create Task
Maniphest T248751

[EPIC] Adopt mustache templates in legacy skins: CologneBlue, Modern
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
Jdlrobson
Mar 28 2020, 5:10 PM
Tags
Referenced Files
F33985014: Screen Shot 2021-01-04 at 8.45.47 PM.png
Jan 5 2021, 10:58 PM
F33985016: Screen Shot 2021-01-04 at 8.46.06 PM.png
Jan 5 2021, 10:58 PM
F33984950: Screen Shot 2021-01-05 at 4.07.14 AM.png
Jan 5 2021, 3:53 AM
F33984952: Screen Shot 2021-01-05 at 4.40.32 AM.png
Jan 5 2021, 3:53 AM
Subscribers
Aklapper
Ammarpad
Amorymeltzer
Jdlrobson
Tokens
"Like" token, awarded by Ammarpad.

Description

For better maintainability and off the back of the desktop refresh, Modern and CologneBlue could be reduced to a repo without any PHP.

Acceptance criteria

Details

SubjectRepoBranchLines +/-
CologneBlue implemented with SkinMustachemediawiki/skins/CologneBluemaster+354 -599
Replace piped lists with pseudo element styled listsmediawiki/skins/CologneBluemaster+81 -24
Clean up skin.mustache layout/whitespacemediawiki/skins/Modernmaster+41 -48
Make Modern modern again (at least from a technology standpoint)mediawiki/skins/Modernmaster+151 -395
Monobook templating 2/2mediawiki/skins/MonoBookmaster+37 -37
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 28 2020, 5:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2020, 5:10 PM
gerritbot added a comment.Mar 28 2020, 5:11 PM

Change 584088 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] Use templates in Monobook (1/2)

https://gerrit.wikimedia.org/r/584088

gerritbot added a project: Patch-For-Review.Mar 28 2020, 5:11 PM

Change 584089 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] Monobook templating 2/2

https://gerrit.wikimedia.org/r/584089

Jdlrobson added a comment.Mar 28 2020, 5:15 PM

Possibly blocked on T248752

gerritbot added a comment.May 29 2020, 8:03 PM

Change 584089 abandoned by Jdlrobson:
Monobook templating 2/2

https://gerrit.wikimedia.org/r/584089

gerritbot added a comment.May 29 2020, 8:10 PM

Change 584088 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] WIP: Monobook Mustache

https://gerrit.wikimedia.org/r/584088

Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.May 29 2020, 8:10 PM
Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.
gerritbot added a comment.Jun 3 2020, 10:48 PM

Change 584088 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] WIP: Monobook Mustache

https://gerrit.wikimedia.org/r/584088

gerritbot added a comment.Jun 3 2020, 10:48 PM

Change 585834 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Modern@master] POC: Make Modern modern again (at least from a technology standpoint)

https://gerrit.wikimedia.org/r/585834

Jdlrobson renamed this task from Adopt mustache templates in Monobook to Adopt mustache templates in Modern and Monobook.Jun 3 2020, 10:48 PM
Jdlrobson added a project: Modern.
Jdlrobson updated the task description. (Show Details)
Amorymeltzer subscribed.Jun 4 2020, 1:40 AM
Ammarpad awarded a token.Aug 6 2020, 7:16 AM
Jdlrobson renamed this task from Adopt mustache templates in Modern and Monobook to [EPIC] Adopt mustache templates in legacy skins: CologneBlue, Modern and Monobook.Aug 6 2020, 4:50 PM
Jdlrobson updated the task description. (Show Details)
Ammarpad added a project: CologneBlue.Aug 7 2020, 1:04 AM
gerritbot added a comment.Oct 8 2020, 9:07 AM

Change 585834 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Make Modern modern again (at least from a technology standpoint)

https://gerrit.wikimedia.org/r/585834

Jdlrobson removed projects: Modern, Patch-For-Review.Oct 8 2020, 9:35 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Oct 8 2020, 11:03 PM

Change 632994 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Modern@master] Clean up mustache templates

https://gerrit.wikimedia.org/r/632994

gerritbot added a project: Patch-For-Review.Oct 8 2020, 11:03 PM
gerritbot added a comment.Oct 9 2020, 6:29 PM

Change 632994 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Clean up skin.mustache layout/whitespace

https://gerrit.wikimedia.org/r/632994

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 9 2020, 7:00 PM
Amorymeltzer mentioned this in T265763: .mw-indicators in Modern skin displaying vertically/improperly.Oct 16 2020, 8:50 PM
Amorymeltzer mentioned this in T265832: Weird text overlay in Modern's echo indicators.Oct 18 2020, 5:41 PM
gerritbot added a comment.Oct 30 2020, 7:49 PM

Change 606798 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@master] CologneBlue to Mustache

https://gerrit.wikimedia.org/r/606798

gerritbot added a comment.Oct 30 2020, 7:49 PM

Change 637771 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@master] Replace piped lists with pseudo element styled lists

https://gerrit.wikimedia.org/r/637771

Amorymeltzer mentioned this in T246931: Modern echo icons too high up.Oct 31 2020, 5:01 PM
gerritbot added a comment.Nov 11 2020, 6:15 AM

Change 637771 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Replace piped lists with pseudo element styled lists

https://gerrit.wikimedia.org/r/637771

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Nov 11 2020, 7:00 AM
gerritbot added a comment.Jan 5 2021, 3:33 AM

Change 606798 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] CologneBlue implemented with SkinMustache

https://gerrit.wikimedia.org/r/606798

Ammarpad subscribed.EditedJan 5 2021, 3:53 AM

CologneBlue

BeforeAfter
Screen Shot 2021-01-05 at 4.07.14 AM.png (814×471 px, 204 KB)
Screen Shot 2021-01-05 at 4.40.32 AM.png (871×471 px, 218 KB)

Notice how the "Interaction" portal location changed. This is the position change I was talking about.

Second issue, there's now a new "Edit" portlet with inactive "edit this page" link. I didn't see this locally, so I guess it appears now because I don't have permission to edit Wikipedia Beta mainpage. It displays correctly on other pages https://en.wikipedia.beta.wmflabs.org/wiki/Portal:Current_events?useskin=cologneblue. But anyway the section need to be hidden at all if the user has no permission (as it used to be in the first image).

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.26; 2021-01-12); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Jan 5 2021, 4:00 AM
Jdlrobson removed a project: CologneBlue.Jan 5 2021, 4:49 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a comment.Jan 5 2021, 10:58 PM

Screen Shot 2021-01-04 at 8.45.47 PM.png (1×2 px, 579 KB)

Screen Shot 2021-01-04 at 8.46.06 PM.png (1×2 px, 566 KB)

Right yes...

  1. Interaction now moves below personal links
  2. what links here and page info switch position
  3. Several label changes

I think these are all fine as they bring further consistency and if anyone is upset about them, I'm happy to chat through with them to why this makes maintenance easier.

Just one left now - Monobook!

Jdlrobson renamed this task from [EPIC] Adopt mustache templates in legacy skins: CologneBlue, Modern and Monobook to [EPIC] Adopt mustache templates in legacy skins: CologneBlue, Modern.Jan 22 2021, 1:29 AM
Jdlrobson closed this task as Resolved.
Jdlrobson claimed this task.
Jdlrobson edited projects, added Modern, CologneBlue; removed MonoBook.
Jdlrobson updated the task description. (Show Details)

Will create a new task for Monobook if interest.

DannyS712 mentioned this in T292038: Merge CologneBlue resourceloader modules.Sep 29 2021, 1:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL