Page MenuHomePhabricator
Create Task
Maniphest T249888

GrowthExperiments's suggestions widget doesn't provide visual `:focus` feedback for keyboard/AT users
Open, Needs TriagePublic
Actions

Description

When testing Newcomer homepage interface on euwiki, it became clear that SuggestionGroupWidget overrides the OOUI CheckboxMultiselectWidget, while not providing visual :focus feedback for keyboard/AT users.

T249888 GE SuggestionGroupWidget screencast 2020-04-09.mp41 MBDownload

image.png (294×1 px, 32 KB)

aka “where's my focus”

Related Objects

Event Timeline

Volker_E created this task.Apr 10 2020, 12:04 AM
Restricted Application added projects: Growth-Team, Structured-Data-Backlog. · View Herald TranscriptApr 10 2020, 12:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E updated the task description. (Show Details)Apr 10 2020, 12:06 AM
Volker_E mentioned this in T242414: Consider adding suggestion widget to OOUI.
Volker_E updated the task description. (Show Details)Apr 10 2020, 12:12 AM
AnneT added a comment.Apr 10 2020, 4:34 PM

Thanks for pointing this out @Volker_E; I added T249932 so we can handle this in the MV project.

CBogen moved this task from Triage to Tracking on the Structured-Data-Backlog board.Apr 14 2020, 3:50 PM
kostajh merged a task: T250221: Topic filters are not keyboard accessible.Apr 14 2020, 7:55 PM
kostajh subscribed.
MMiller_WMF added a comment.Apr 15 2020, 4:45 AM

@AnneT @kostajh -- since @AnneT filed T249932, does that mean we don't need to work on this, and we will get the effects downstream? Thank you for working on it!

kostajh added a comment.Apr 15 2020, 7:39 AM

does that mean we don't need to work on this, and we will get the effects downstream? Thank you for working on it!

@MMiller_WMF unfortunately no, since this component was copy/pasted from MachineVision and has now diverged slightly from their implementation.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Jdforrester-WMF renamed this task from GrowthExperiments (/ MachineVisions) suggestions widget doesn't provide visual `:focus` feedback for keyboard/AT users to GrowthExperiments's suggestions widget doesn't provide visual `:focus` feedback for keyboard/AT users.Fri, Apr 5, 7:52 PM
Jdforrester-WMF removed projects: Structured-Data-Backlog, MachineVision.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL