Termbox: Use "vuex" ResourceLoader module from core
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Acceptance criteria:

Termbox uses vuex copy provided by mediawiki
There is automated check in place that the version specified in termbox's package.json and the version provided by mediawiki are the same.
The new termbox version is pinned in the wikibase repo

Note: Wikidata Bridge has done externalization of this dependency, could be looked up for inspiration. Termbox has also already externalized vuejs dependency.

Details

	Subject	Repo	Branch	Lines +/-
	Update termbox and add vuex dependency	mediawiki/extensions/Wikibase	master	+3 -2
	Externalize vuex	wikibase/termbox	master	+143 -169

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T250263 Use "vuex" ResourceLoader module from core
		Resolved		• Tonina_Zhelyazkova_WMDE	T250266 Termbox: Use "vuex" ResourceLoader module from core

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 15 2020, 12:02 PM

• Pablo-WMDE added a project: User-Pablo-WMDE.Nov 18 2020, 10:01 AM

• Pablo-WMDE moved this task from Incoming to Medium term on the User-Pablo-WMDE board.

Addshore moved this task from Inbox to legacy-backlog on the [DEPRECATED] wdwb-tech board.Mar 5 2021, 12:17 PM

Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.

Addshore moved this task from legacy-backlog to To Prioritize on the [DEPRECATED] wdwb-tech board.Mar 18 2021, 12:41 PM

Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).

Don't forget to make sure that T259468 remains resolved. i.e. check we don't end up with a vuex version drift between core and package.json

Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Apr 6 2021, 11:53 AM

Addshore added a project: Wikidata-Campsite.Apr 13 2021, 5:04 PM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

WMDE-leszek updated the task description. (Show Details)Apr 16 2021, 11:01 AM

WMDE-leszek set the point value for this task to 3.

WMDE-leszek moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Jakob_WMDE updated the task description. (Show Details)Apr 16 2021, 11:14 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 16 2021, 11:15 AM

Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Apr 23 2021, 10:54 AM

• Tonina_Zhelyazkova_WMDE claimed this task.Apr 26 2021, 12:10 PM

• Tonina_Zhelyazkova_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 682618 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[wikibase/termbox@master] Externalize vuex

https://gerrit.wikimedia.org/r/682618

gerritbot added a project: Patch-For-Review.Apr 26 2021, 1:08 PM

Note to the reviewer(s):
The patch contains changes to package-lock.json which were not expected given the nature of the change, but they were generated after an npm install (executed inside the docker container) so I decided to submit them.