Page MenuHomePhabricator
Create Task
Maniphest T251957

skinScripts cannot be used alongside packageFiles: should throw exception.
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

While working on https://gerrit.wikimedia.org/r/c/591436 (Bug: T250851) we noticed that skinScripts do not get loaded in packageFile modules.

This will block work in building out the search widget in Vue.js so it's of high importance that we get this unblocked.

In the meantime we could revert the use of packageFiles in this module or split out a new module however we'd like to avoid this if at all possible.

Acceptance criteria

  • Setting skinScripts and packageFiles on the same module should thrown an exception.

Developer notes

After talking to @Catrope we think that virtual packageFiles using hooks could solve the needs of skins wants to change behaviour. With this in mind we should thrown an exception of skinScripts is mixed with packageFiles.

Details

SubjectRepoBranchLines +/-
resourceloader: Improve packageFiles/skinScripts error messagemediawiki/coremaster+1 -4
resourceloader: skinScripts cannot be used alongside packageFilesmediawiki/coremaster+6 -0
resourceloader: skinScripts cannot be used alongside packageFilesmediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 5 2020, 10:38 PM
Jdlrobson claimed this task.May 5 2020, 10:53 PM
• Niedzielski edited projects, added Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)); removed Design-Systems-team-20200324-20220422.May 6 2020, 2:19 PM
• Niedzielski moved this task from Backlog to On Web Board on the Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)) board.May 6 2020, 2:27 PM
• nray subscribed.May 6 2020, 8:17 PM
Jdlrobson renamed this task from skinScripts cannot be used alongside packageFiles to skinScripts cannot be used alongside packageFiles: should throw exception..May 6 2020, 8:58 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T250853: Add support for 'skinScripts' in extension.json and skin.json.May 6 2020, 9:02 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-2019-20-Q4).May 6 2020, 9:07 PM
Jdlrobson triaged this task as Medium priority.May 8 2020, 4:18 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson added a project: patch-welcome.
Krinkle added a comment.May 8 2020, 4:26 PM

With or without throw, they can't both be used at the same time (there can only be one main module.exports). So I assume this does not block, T250851. Right?

The equivalent of skinScripts in packageFiles, is a virtual file that you define from a callback based on any variant factors you wish (language, skin, wiki config etc.).

Krinkle edited projects, added MediaWiki-ResourceLoader; removed MediaWiki-User-Interface, Performance-Team (Radar).May 8 2020, 4:27 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 8 2020, 4:27 PM
Jdlrobson removed a parent task: T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.May 8 2020, 4:34 PM
ovasileva moved this task from Incoming to Q1 2020-2021 on the Desktop Improvements (Vector 2022) board.May 20 2020, 9:41 AM
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.May 20 2020, 4:23 PM
• Niedzielski mentioned this in T249306: [Spike] How should we load Vue.js and dependencies for Vue.js search?.May 29 2020, 11:55 PM
Jdlrobson reassigned this task from Jdlrobson to vas.Jun 5 2020, 4:14 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog.Jun 5 2020, 4:53 PM
Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.
ovasileva set the point value for this task to 2.Jun 8 2020, 5:28 PM
Krinkle removed projects: patch-welcome, Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)).Jun 8 2020, 6:37 PM
Krinkle added a project: Developer Productivity.
gerritbot added a comment.Jun 9 2020, 1:37 PM

Change 604011 had a related patch set uploaded (by Vas Yaremchuk; owner: Vas Yaremchuk):
[mediawiki/core@master] skinScripts cannot be used alongside packageFiles: should throw exception

https://gerrit.wikimedia.org/r/604011

gerritbot added a project: Patch-For-Review.Jun 9 2020, 1:37 PM
vas reassigned this task from vas to Jdlrobson.Jun 9 2020, 1:39 PM
vas subscribed.

Jon, please check my patch.

Jdlrobson reassigned this task from Jdlrobson to vas.Jun 9 2020, 3:47 PM
Jdlrobson moved this task from Doing to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.
vas reassigned this task from vas to Jdlrobson.Jun 9 2020, 5:20 PM

Jon, I have fixed 2 issues in includes/resourceloader/ResourceLoaderFileModule.php

You can run tests again.

gerritbot added a comment.Jun 9 2020, 8:18 PM

Change 604011 had a related patch set uploaded (by VolkerE; owner: Vas Yaremchuk):
[mediawiki/core@master] skinScripts cannot be used alongside packageFiles: should throw exception

https://gerrit.wikimedia.org/r/604011

Jdlrobson reassigned this task from Jdlrobson to vas.Jun 9 2020, 8:31 PM
gerritbot added a comment.Jun 11 2020, 10:07 AM

Change 604647 had a related patch set uploaded (by Vas Yaremchuk; owner: Vas Yaremchuk):
[mediawiki/core@master] resourceloader: skinScripts cannot be used alongside packageFiles

https://gerrit.wikimedia.org/r/604647

vas reassigned this task from vas to Jdlrobson.Jun 11 2020, 10:17 AM

Jon, please ignore https://gerrit.wikimedia.org/r/604647
The correct version to review in https://gerrit.wikimedia.org/r/604011

gerritbot added a comment.Jun 11 2020, 3:21 PM

Change 604647 abandoned by Jdlrobson:
resourceloader: skinScripts cannot be used alongside packageFiles

Reason:
Per https://phabricator.wikimedia.org/T251957#6214484

https://gerrit.wikimedia.org/r/604647

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 11 2020, 5:09 PM
gerritbot added a comment.Jun 11 2020, 8:29 PM

Change 604011 had a related patch set uploaded (by Jdlrobson; owner: Vas Yaremchuk):
[mediawiki/core@master] resourceloader: skinScripts cannot be used alongside packageFiles

https://gerrit.wikimedia.org/r/604011

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 11 2020, 8:30 PM
gerritbot added a comment.Jun 11 2020, 9:14 PM

Change 604011 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: skinScripts cannot be used alongside packageFiles

https://gerrit.wikimedia.org/r/604011

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 10:01 PM
gerritbot added a comment.Jun 11 2020, 10:41 PM

Change 604890 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Improve packageFiles/skinScripts error message

https://gerrit.wikimedia.org/r/604890

gerritbot added a comment.Jun 11 2020, 11:05 PM

Change 604890 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Improve packageFiles/skinScripts error message

https://gerrit.wikimedia.org/r/604890

Jdlrobson closed this task as Resolved.Jun 15 2020, 5:09 PM
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits