Page MenuHomePhabricator

Echo notifications: Action menu more "..." icon disappears when mute/unmute action is selected
Open, Needs TriagePublicBUG REPORT

Description

This is occurring for the Mute/Unmute action (forthcoming on T254197) on the page-linked notification type.

Steps to Reproduce

Scenario A. Notifications panel

  1. Open the Notices panel and select the "..." option on a page-linked notification
  2. Select the option to mute the notification.
  3. Close the confirmation pop-up and click to see the notifications panel again.

Scenario B. Special:Notifications page

  1. Open the Special:Notifications page and select the "..." option on a page-linked notification
  2. Select the option to mute the notification.
Actual Results:

Scenario A. Notifications panel
The page-link notification item does not show "..." menu button at first, it only re-appears after the notifications panel finishes reloading.

open full-screen to see animated gif

Scenario B. Special:Notifications page
The page-link notification item does not show "..." menu button at all, it only re-appears after the page is refreshed.

open full-screen to see animated gif

Expected Results:

Scenario A. Notifications panel
The page-link notifications should continue to show the "..." menu button, which when selected shows the option to unmute the notification

Scenario B. Special:Notifications page
The page-link notifications should continue to show the "..." menu button, which when selected shows the option to unmute the notification

Event Timeline

RHo created this task.Jun 2 2020, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2020, 7:32 PM
RHo updated the task description. (Show Details)Jun 2 2020, 7:32 PM
Catrope added a subscriber: Catrope.EditedJun 3 2020, 4:04 AM

This is because this feature reused the infrastructure built for T132975: Allow unwatching a Flow topic/board from a notification about that topic/board. That was a one-way toggle (allow unwatching, but not rewatching), so it made sense to have the toggle disappear after use. For mute/unmute, we offer the toggle in both directions, so it doesn't make sense. We've currently hard-coded the assumption that all dynamic actions should disappear after the action taken, so we'll have to make that behavior configurable and turn it off for mute/unmute.

RHo added a comment.Jun 3 2020, 2:09 PM

This is because this feature reused the infrastructure built for T132975: Allow unwatching a Flow topic/board from a notification about that topic/board. That was a one-way toggle (allow unwatching, but not rewatching), so it made sense to have the toggle disappear after use. For mute/unmute, we offer the toggle in both directions, so it doesn't make sense. We've currently hard-coded the assumption that all dynamic actions should disappear after the action taken, so we'll have to make that behavior configurable and turn it off for mute/unmute.

Ah I see. Reading the comment history on that task I understand the reason for not including an option to rewatch. However, we may wish to revisit this decision if and when the muting/unmuting behavior for all notifications on T115264 is done, since it can be a little confusing for users that one type of "monitoring" notification action has an undo but the other does not.