Maniphest T255586

Replace HTMLFormatter by Remex
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Jun 16 2020, 4:53 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

wikimedia/html-formatter uses loadHTML. It shouldn't. It should use Remex.

Maybe we should just remove the HTMLFormatter framework into Remex and remove uses of the library entirely from core.

Details

	Subject	Repo	Branch	Lines +/-
	Convert the RemovableClasses feature into a Transform	mediawiki/extensions/MobileFrontend	master	+78 -95
	MobileFormatter: Use RemexHtml	mediawiki/extensions/MobileFrontend	master	+111 -106
	ApiHelp: Replace use of HtmlFormatter in fixHelpLinks()	mediawiki/core	master	+33 -28

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T255586 Replace HTMLFormatter by Remex
		Resolved		None	T217850 Remex could use some helper/utility classes
		Resolved		matmarex	T296648 Replace use of HtmlFormatter in Linker::expandLocalLinks() with Remex

Event Timeline

cscott created this task.Jun 16 2020, 4:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 4:53 PM

cscott added a subtask: T217850: Remex could use some helper/utility classes.Jun 16 2020, 4:53 PM

Aklapper added a project: MediaWiki-Vendor.Jun 16 2020, 5:12 PM

Jdlrobson added a project: HtmlFormatter.Jul 21 2020, 3:22 PM

Jdlrobson mentioned this in T258964: HtmlFormatter library: Code stewardship review.Jul 27 2020, 4:45 PM

Jdforrester-WMF subscribed.Jul 27 2020, 6:31 PM

Sort of duplicates T217360: Replace libxml/xpath in HtmlFormatter with Remex/zest.

We probably want to use the dodo library here, too.

cscott mentioned this in T296648: Replace use of HtmlFormatter in Linker::expandLocalLinks() with Remex.Nov 29 2021, 4:35 PM

Tgr mentioned this in T217705: RemexHTML should be able to parse HTML into an existing DOM node.Dec 23 2022, 4:11 AM

matmarex closed subtask T217850: Remex could use some helper/utility classes as Resolved.Dec 29 2022, 8:25 PM

Change 873766 had a related patch set uploaded (by Umherirrender; author: Bartosz Dziewoński):

[mediawiki/core@master] ApiHelp: Replace use of HtmlFormatter in fixHelpLinks()

https://gerrit.wikimedia.org/r/873766

gerritbot added a project: Patch-For-Review.Feb 5 2023, 6:12 PM

Change 873766 merged by jenkins-bot:

[mediawiki/core@master] ApiHelp: Replace use of HtmlFormatter in fixHelpLinks()

https://gerrit.wikimedia.org/r/873766

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2023, 6:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 5 2023, 7:00 PM

matmarex added a subtask: T296648: Replace use of HtmlFormatter in Linker::expandLocalLinks() with Remex.Feb 7 2023, 8:46 PM

matmarex closed subtask T296648: Replace use of HtmlFormatter in Linker::expandLocalLinks() with Remex as Resolved.

Krinkle subscribed.Feb 7 2023, 9:41 PM

matmarex mentioned this in T345319: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314.Sep 4 2023, 4:26 PM

cscott mentioned this in T348251: Move HtmlHolder from Parsoid to independent library.Oct 5 2023, 1:49 PM

TehKittyCat subscribed.Dec 20 2023, 2:41 AM

Change #1030548 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MobileFrontend@master] Convert the RemovableClasses feature into a Transform

https://gerrit.wikimedia.org/r/1030548

gerritbot added a project: Patch-For-Review.May 12 2024, 3:55 PM

Change #1030551 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MobileFrontend@master] MobileFormatter: Use RemexHtml

https://gerrit.wikimedia.org/r/1030551