Page MenuHomePhabricator

entitysources: Clean up any remainders of the legacy back/compat config in Wikibase and extensions
Open, Needs TriagePublic

Description

When creating T257260: entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository I realized that these config options are still used in various places in code (mainly tests and defaults) which is not ideal.
These should all be removed so that we can safely unset these in production.
All code should be getting these things from entity sources, including tests.

Looking at EntitySourceDefinitionsLegacyRepoSettingsParser this probably is:

  • entityNamespaces
  • changesDatabase
  • conceptBaseUri
  • foreignRepositories

And for EntitySourceDefinitionsLegacyClientSettingsParser:

  • foreignRepositories
  • repositories
  • repoDatabase
  • entityNamespaces
  • repoConceptBaseUri

Event Timeline

I played around with this a bit in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/609852
Actually tackling this will probably require the removal of the current WikibaseClientEntityNamespaces and WikibaseRepoEntityNamespaces hooks which interact with the entityNamespaces setting directly to do something more fancy with either the entitySources config or perhaps this could all be done with the entity type definitions (that already has another hook).
That's it for tonight though....