Page MenuHomePhabricator

entitysources: Clean up any remainders of the legacy back/compat config in Wikibase and extensions
Closed, ResolvedPublic

Description

When creating T257260: entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository I realized that these config options are still used in various places in code (mainly tests and default settings) which is not ideal.
These references should all be removed so that we can safely unset these variables in production.
All code should be getting these things from entity sources, including tests.

Looking at EntitySourceDefinitionsLegacyRepoSettingsParser this probably is:

And for EntitySourceDefinitionsLegacyClientSettingsParser:

The repositories old legacy thing: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_options.html#autotoc_md370
The foreignRepositories old legacy thing: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_options.html#foreignRepositories
The new entitysources thing: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_entitysources.html

Acceptance criteria:🏕️🌟

  • Release notes are updated (as this is user facing back compat config that is being removed), including how to migrate from old settings to new settings (possible including a code snippet that using eval.php that can output the new config for people).
  • References to the old configuration options are all removed
  • Back compat layer for the old config options are removed
  • Docs are updated

Related Objects

Event Timeline

I played around with this a bit in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/609852
Actually tackling this will probably require the removal of the current WikibaseClientEntityNamespaces and WikibaseRepoEntityNamespaces hooks which interact with the entityNamespaces setting directly to do something more fancy with either the entitySources config or perhaps this could all be done with the entity type definitions (that already has another hook).
That's it for tonight though....

Michael added a subscriber: Michael.

Given that all the subtasks are closed, I think this can move to verification.

Also, is there a checklist-task for the next major Wikibase release? That should probably get an item of making double sure that the script we created in T285474 works as expected. Quoting from that task:

I think we can close this, with verification happening in the parent tasks.

Change 711130 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/vagrant@master] Use 'entitySources' configuration

https://gerrit.wikimedia.org/r/711130

Change 711130 merged by jenkins-bot:

[mediawiki/vagrant@master] Use 'entitySources' configuration

https://gerrit.wikimedia.org/r/711130

Change 711538 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] docs: Final update for legacy/non-legacy entity sources

https://gerrit.wikimedia.org/r/711538

Change 711538 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] docs: Final update for legacy/non-legacy entity sources

https://gerrit.wikimedia.org/r/711538

Doing a quick grep of mediawiki.org it seems like at some point we will also have to update some pages there.
https://www.mediawiki.org/w/index.php?search=entitynamespaces&title=Special%3ASearch&go=Go&ns0=1&ns12=1&ns100=1&ns102=1&ns104=1&ns106=1

@danshick-wmde Is this something that we should aim to do on the campsite or rather something that we could do in a doc coffee time?

I think all the current documentation on mediawiki.org is updated now.