Page MenuHomePhabricator
Create Task
Maniphest T241975

entitysources: Remove old MultiRepository & PerRepository Service containers and config
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Once T214557 is finished (functionality is written and complete) and useEntitySourceBasedFederation is true everywhere in production and by default in Wikibase we can remove the old code that it is switching away from.

(possibly optional (please talk to the federated properties team folks before doing this)) Remove EntityId::getRepositoryName and "repository prefix" related code in Wikibase Data Model library

Details

SubjectRepoBranchLines +/-
Wikibase: Remove config option wmgUseEntitySourceBasedFederation (take 2)operations/mediawiki-configmaster+0 -7
Wikibase: stop using wmgUseEntitySourceBasedFederation (take 2)operations/mediawiki-configmaster+0 -8
Revert "Wikibase: Remove config option wmgUseEntitySourceBasedFederation"operations/mediawiki-configmaster+7 -0
Revert "Wikibase: stop using wmgUseEntitySourceBasedFederation"operations/mediawiki-configmaster+8 -0
Wikibase: stop using wmgUseEntitySourceBasedFederationoperations/mediawiki-configmaster+0 -8
Wikibase: Remove config option wmgUseEntitySourceBasedFederationoperations/mediawiki-configmaster+0 -7
Removed no longer used UnusableEntitySourcemediawiki/extensions/Wikibasemaster+0 -118
Removed not needed "non-entity-source" logic in HtmlPageLinkRendererBeginHookHandlermediawiki/extensions/Wikibasemaster+7 -331
Removed "non-entity-source" conditional logic in RebuildTermSqlIndexmediawiki/extensions/Wikibasemaster+1 -6
Removed now-redundant tests cases in RepoHooksTestmediawiki/extensions/Wikibasemaster+14 -136
Removed "non-entity-source" conditional logic in Database*TermStoreWritermediawiki/extensions/Wikibasemaster+24 -90
Removed no longer used ForeignEntityValidatormediawiki/extensions/Wikibasemaster+0 -224
Removed "non-entity-source" conditional logic in WikiPageEntityStoremediawiki/extensions/Wikibasemaster+4 -586
Removed "non-entity-source" conditional logic in EntityContentFactorymediawiki/extensions/Wikibasemaster+26 -130
Removed "non-entity-source" conditional logic in WikiPageEntityMetaDataLookupmediawiki/extensions/Wikibasemaster+26 -473
Swapped DataAccessSettingsFactory::anySetting to entity source onemediawiki/extensions/Wikibasemaster+1 -1
Removed "non-entity-source" conditional logic in DatabaseEntityInfoBuildermediawiki/extensions/Wikibasemaster+13 -280
Removed "non-entity-source" conditional logic in SqlEntityInfoBuildermediawiki/extensions/Wikibasemaster+18 -313
Removed now-redundant tests cases in TermStoreWriter testsmediawiki/extensions/Wikibasemaster+10 -436
Removed "non-entity-source" conditional logic in PropertyInfoTablemediawiki/extensions/Wikibasemaster+21 -362
Removed now-redundant tests cases in DataAccessSnakFormatterOutputFormatTestmediawiki/extensions/Wikibasemaster+0 -37
Removed "non-entity-source" conditional logic in RepoHooksmediawiki/extensions/Wikibasemaster+19 -37
Removed useEntitySourceBasedFederation config optionmediawiki/extensions/Wikibasemaster+5 -291
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT241975 entitysources: Remove old MultiRepository & PerRepository Service containers and config
 ResolvedAddshoreT242087 entitysources: Directly create entitySources config for WMF sites instead of using compat layer
 ResolvedWMDE-leszekT241971 useEntitySourceBasedFederation true by default in Wikibase
 ResolvedAddshoreT243395 wmgUseEntitySourceBasedFederation true for Wikimedia clients (all sites)
 ResolvedLadsgroupT241972 wmgUseEntitySourceBasedFederation true for Wikidata.org
 ResolvedLadsgroupT241973 wmgUseEntitySourceBasedFederation true for test.wikidata.org
 ResolvedLadsgroupT241974 wmgUseEntitySourceBasedFederation true for beta wikidata
 ResolvedPRODUCTION ERRORAddshoreT243415 Multiple repo/includes/Rdf errors, when wmgUseEntitySourceBasedFederation true on Wikidata.org
 ResolvedAddshoreT248656 entitysources: Directly create entitySources config for beta cluster sites
 ResolvedAddshoreT248664 entitysources: Directly create entitySources config for WMF "test" wikis
 Resolved• Pablo-WMDET250181 test.wikidata.org - term store not updating
 ResolvedAddshoreT252019 Remove Wikibase assumption that a false dbname is the only way to refer to the local DB.
 ResolvedAddshoreT254315 entitysources: Directly create entitySources config for WMF production wikis
 ResolvedmatthiasmullieT255601 MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false
 ResolvedPRODUCTION ERRORAddshoreT256906 No namespace configured for MediaInfo entities, when deploying entity source config to wikidata clients
 ResolvedPRODUCTION ERRORAddshoreT256907 Call to a member function getDatabaseName() on null, when deploying entity source config to wikidata clients
 ResolvedPRODUCTION ERRORAddshoreT256909 Call to a member function getSourceName() on null, when deploying entity source config to wikidata clients
 ResolvedWMDE-leszekT245547 Remove useEntitySourceBasedFederation setting
 ResolvedWMDE-leszekT245817 Remove conditional "federation mode" logic from the services in the "storage layer"
 ResolvedWMDE-leszekT245830 Remove conditional "federation mode" logic from the Wikibase API and hook code
 ResolvedAddshoreT245831 Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code
 ResolvedAddshoreT245860 Remove conditional "federation mode" logic from the Wikibase "top-level" factories
 ResolvedhooT245865 Remove legacy Wikibase service containers
 ResolvedAddshoreT245870 Remove RepositorySettings
 ResolvedLucas_Werkmeister_WMDET257260 entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository
 ResolvedLucas_Werkmeister_WMDET257262 entitysources: Clean up any remainders of the legacy back/compat config in Wikibase and extensions
 ResolvedLucas_Werkmeister_WMDET285471 Remove repositories and foreignRepositories legacy settings
 ResolvedLucas_Werkmeister_WMDET285472 Remove entityNamespaces settings
 ResolvedLucas_Werkmeister_WMDET286767 Remove foreignRepositories support in WikibaseCirrusSearch
 ResolvedLucas_Werkmeister_WMDET285473 Remove changesDatabase legacy setting
Resolved• toanT285474 Create a script to suggest migrated entity sources settings
 ResolvedLucas_Werkmeister_WMDET286539 Remove repoNamespaces setting
 ResolvedLucas_Werkmeister_WMDET287242 Remove repoDatabase legacy setting
 ResolvedLucas_Werkmeister_WMDET287486 Remove conceptBaseUri setting

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Feb 21 2020, 2:44 PM

Change 573964 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in DatabaseEntityInfoBuilder

https://gerrit.wikimedia.org/r/573964

gerritbot added a comment.Feb 21 2020, 3:11 PM

Change 569333 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Swapped DataAccessSettingsFactory::anySetting to entity source one

https://gerrit.wikimedia.org/r/569333

gerritbot added a comment.Feb 21 2020, 3:19 PM

Change 572278 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/572278

gerritbot added a comment.Feb 21 2020, 3:36 PM

Change 572279 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in EntityContentFactory

https://gerrit.wikimedia.org/r/572279

gerritbot added a comment.Feb 21 2020, 3:37 PM

Change 572280 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityStore

https://gerrit.wikimedia.org/r/572280

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 3:40 PM
gerritbot added a comment.Feb 21 2020, 3:43 PM

Change 574018 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed no longer used ForeignEntityValidator

https://gerrit.wikimedia.org/r/574018

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 3:57 PM
gerritbot added a comment.Feb 21 2020, 4:38 PM

Change 574018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed no longer used ForeignEntityValidator

https://gerrit.wikimedia.org/r/574018

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 4:42 PM
gerritbot added a comment.Feb 21 2020, 4:58 PM

Change 573967 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in Database*TermStoreWriter

https://gerrit.wikimedia.org/r/573967

gerritbot added a comment.Feb 21 2020, 5:34 PM

Change 569330 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in RepoHooksTest

https://gerrit.wikimedia.org/r/569330

gerritbot added a comment.Feb 21 2020, 6:00 PM

Change 572261 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RebuildTermSqlIndex

https://gerrit.wikimedia.org/r/572261

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 7:34 PM
WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 8:16 PM
WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 8:51 PM
WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 9:46 PM
gerritbot added a comment.Feb 22 2020, 4:06 PM

Change 572284 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in HtmlPageLinkRendererBeginHookHandler

https://gerrit.wikimedia.org/r/572284

WMDE-leszek closed subtask T245817: Remove conditional "federation mode" logic from the services in the "storage layer" as Resolved.Feb 22 2020, 6:02 PM
WMDE-leszek updated the task description. (Show Details)
gerritbot added a comment.Feb 22 2020, 6:08 PM

Change 574192 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed no longer used UnusableEntitySource

https://gerrit.wikimedia.org/r/574192

WMDE-leszek updated the task description. (Show Details)Feb 22 2020, 6:09 PM
WMDE-leszek reopened subtask T245817: Remove conditional "federation mode" logic from the services in the "storage layer" as Open.Feb 23 2020, 1:10 PM
WMDE-leszek closed subtask T245817: Remove conditional "federation mode" logic from the services in the "storage layer" as Resolved.Feb 23 2020, 5:12 PM
WMDE-leszek closed subtask T245830: Remove conditional "federation mode" logic from the Wikibase API and hook code as Resolved.
WMDE-leszek updated the task description. (Show Details)
gerritbot added a comment.Feb 24 2020, 12:58 PM

Change 574192 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed no longer used UnusableEntitySource

https://gerrit.wikimedia.org/r/574192

hoo updated the task description. (Show Details)Mar 5 2020, 6:40 PM
hoo updated the task description. (Show Details)Mar 6 2020, 10:31 AM
Ladsgroup updated the task description. (Show Details)Mar 6 2020, 11:08 AM
Ladsgroup added a comment.Mar 6 2020, 11:13 AM

EntityIdSearchHelper still uses $entityTypeToRepositoryMapping and needs to be adjusted to use entity source instead.

Addshore closed subtask T245865: Remove legacy Wikibase service containers as Resolved.Mar 6 2020, 1:58 PM
Addshore closed subtask T245831: Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code as Resolved.
Addshore closed subtask T245860: Remove conditional "federation mode" logic from the Wikibase "top-level" factories as Resolved.
Addshore closed subtask T245870: Remove RepositorySettings as Resolved.
Addshore mentioned this in T248458: Remove "repositories" response from SearchEntities for Federated Property calls.Mar 25 2020, 11:13 AM
WMDE-leszek moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 27 2020, 9:39 AM
Addshore changed the status of subtask T242087: entitysources: Directly create entitySources config for WMF sites instead of using compat layer from Open to Stalled.May 6 2020, 10:14 AM
WMDE-leszek changed the status of subtask T242087: entitysources: Directly create entitySources config for WMF sites instead of using compat layer from Stalled to Open.Jun 3 2020, 6:35 AM
gerritbot added a comment.Jun 3 2020, 6:42 AM

Change 569263 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Wikibase: Removed config option wmgUseEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/569263

Addshore moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 4 2020, 11:23 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

We should also update test to use the DB name strings again now (rather than also needing false)

WMDE-leszek updated the task description. (Show Details)Jun 11 2020, 8:29 AM
WMDE-leszek moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek updated the task description. (Show Details)Jun 15 2020, 2:12 PM
gerritbot added a comment.Jul 1 2020, 7:22 PM

Change 608944 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Wikibase: stop using wmgUseEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608944

gerritbot added a comment.Jul 6 2020, 6:49 PM

Change 608944 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: stop using wmgUseEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/608944

Stashbot added a comment.Jul 6 2020, 6:51 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-06T18:51:12Z] <addshore@deploy1001> Synchronized wmf-config/Wikibase.php: [[gerrit:608944]] T241975 Wikibase: stop using wmgUseEntitySourceBasedFederation (duration: 00m 56s)

gerritbot added a comment.Jul 6 2020, 6:52 PM

Change 569263 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: Remove config option wmgUseEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/569263

Stashbot added a comment.Jul 6 2020, 6:55 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-06T18:55:24Z] <addshore@deploy1001> Synchronized wmf-config: [[gerrit:569263]] T241975 Wikibase: Remove config option wmgUseEntitySourceBasedFederation (duration: 00m 58s)

Addshore claimed this task.Jul 6 2020, 9:22 PM
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)
Restricted Application added a project: User-Addshore. · View Herald TranscriptJul 6 2020, 9:23 PM
Addshore mentioned this in T257260: entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository.Jul 6 2020, 9:33 PM
Addshore updated the task description. (Show Details)Jul 6 2020, 9:36 PM
Addshore updated the task description. (Show Details)Jul 6 2020, 9:42 PM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Jul 6 2020, 10:17 PM
Lucas_Werkmeister_WMDE mentioned this in T257266: Missing Wikidata sitelinks on Commons categories.Jul 6 2020, 10:29 PM
gerritbot added a comment.Jul 7 2020, 7:11 AM

Change 609641 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Revert "Wikibase: Remove config option wmgUseEntitySourceBasedFederation"

https://gerrit.wikimedia.org/r/609641

gerritbot added a comment.Jul 7 2020, 7:13 AM

Change 609641 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Wikibase: Remove config option wmgUseEntitySourceBasedFederation"

https://gerrit.wikimedia.org/r/609641

Stashbot added a comment.Jul 7 2020, 7:15 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-07T07:15:01Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:609641|Revert "Wikibase: Remove config option wmgUseEntitySourceBasedFederation" (T241975, T257266)]] (duration: 00m 57s)

gerritbot added a comment.Jul 7 2020, 7:15 AM

Change 609642 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Revert "Wikibase: stop using wmgUseEntitySourceBasedFederation"

https://gerrit.wikimedia.org/r/609642

gerritbot added a comment.Jul 7 2020, 7:16 AM

Change 609642 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Wikibase: stop using wmgUseEntitySourceBasedFederation"

https://gerrit.wikimedia.org/r/609642

Stashbot added a comment.Jul 7 2020, 7:19 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-07T07:19:10Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:609642|Revert "Wikibase: stop using wmgUseEntitySourceBasedFederation" (T241975, T257266)]] (duration: 00m 55s)

gerritbot added a comment.Jul 7 2020, 7:54 AM

Change 609986 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Wikibase: Remove config option wmgUseEntitySourceBasedFederation (take 2)

https://gerrit.wikimedia.org/r/609986

gerritbot added a comment.Jul 7 2020, 7:54 AM

Change 609645 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Wikibase: stop using wmgUseEntitySourceBasedFederation (take 2)

https://gerrit.wikimedia.org/r/609645

gerritbot added a comment.Jul 7 2020, 9:31 AM

Change 609645 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: stop using wmgUseEntitySourceBasedFederation (take 2)

https://gerrit.wikimedia.org/r/609645

Stashbot added a comment.Jul 7 2020, 9:33 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-07T09:33:55Z] <addshore@deploy1001> Synchronized wmf-config/Wikibase.php: [[gerrit:609645]] T257266 T241975 Wikibase: stop using wmgUseEntitySourceBasedFederation (take2) (duration: 00m 59s)

gerritbot added a comment.Jul 7 2020, 9:34 AM

Change 609986 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: Remove config option wmgUseEntitySourceBasedFederation (take 2)

https://gerrit.wikimedia.org/r/609986

Stashbot added a comment.Jul 7 2020, 9:37 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-07T09:37:15Z] <addshore@deploy1001> Synchronized wmf-config: [[gerrit:609986]] T257266 T241975 Wikibase: Remove config option wmgUseEntitySourceBasedFederation (take2) (duration: 00m 57s)

Addshore closed subtask T242087: entitysources: Directly create entitySources config for WMF sites instead of using compat layer as Resolved.Jul 17 2020, 7:04 AM
Addshore edited projects, added Wikidata-Campsite, [DEPRECATED] wdwb-tech; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jul 20 2020, 12:58 PM
Addshore moved this task from Inbox to Legacy Inbox on the [DEPRECATED] wdwb-tech board.Mar 17 2021, 5:19 PM
Addshore removed a project: Wikidata-Campsite.Apr 22 2021, 4:04 PM
Addshore removed Addshore as the assignee of this task.Jun 22 2021, 9:06 AM
Addshore updated the task description. (Show Details)Jun 22 2021, 10:24 AM
Addshore added a project: Wikidata-Campsite.Jun 22 2021, 12:21 PM
Addshore moved this task from Legacy Inbox to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Jun 23 2021, 8:33 AM
Addshore set the point value for this task to 8.Jun 23 2021, 10:30 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jun 23 2021, 11:02 AM
Addshore moved this task from Stalled/Waiting to Parent tasks on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Jun 23 2021, 11:05 AM
Addshore added a project: wikidata-campsite-a-b-split.Jun 28 2021, 1:12 PM
Addshore moved this task from Backlog to Team B driven on the wikidata-campsite-a-b-split board.Jun 28 2021, 1:19 PM
Addshore closed subtask T257260: entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository as Resolved.Aug 24 2021, 12:21 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 24 2021, 12:24 PM
Lucas_Werkmeister_WMDE moved this task from Parent tasks to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore closed this task as Resolved.Aug 24 2021, 12:25 PM
Addshore claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL