Page MenuHomePhabricator

entitysources: Remove old MultiRepository & PerRepository Service containers and config
Open, HighPublic

Description

Once T214557 is finished (functionality is written and complete) and useEntitySourceBasedFederation is true everywhere in production and by default in Wikibase we can remove the old code that it is switching away from.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in TermSqlIndex
mediawiki/extensions/Wikibase : masterRemoved now-redundant tests cases in DataAccessSnakFormatterOutputFormatTest
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in RepoHooks
mediawiki/extensions/Wikibase : masterRemoved not needed "non-entity-source" logic in SearchEntities API class
mediawiki/extensions/Wikibase : masterRemoved useEntitySourceBasedFederation config option
mediawiki/extensions/Wikibase : masterRemoved not needed "non-entity-source" logic in HtmlPageLinkRendererBeginHookHandler
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in WikiPageEntityStore
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in RebuildTermSqlIndex
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in EntityContentFactory
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in WikiPageEntityMetaDataLookup
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in RebuildPropertyInfo
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in SqlEntityInfoBuilder
mediawiki/extensions/Wikibase : masterRemoved now-redundant tests cases in RepoHooksTest
mediawiki/extensions/Wikibase : masterRemoved "non-entity-source" conditional logic in PropertyInfoTable
mediawiki/extensions/Wikibase : masterSwapped DataAccessSettingsFactory::anySetting to entity source one
operations/mediawiki-config : masterWikibase: Removed config option wmgUseEntitySourceBasedFederation

Event Timeline

Addshore created this task.Jan 6 2020, 9:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2020, 9:23 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 7 2020, 2:15 PM

I don't think we should make patches for this before T242096: SingleEntitySourceServices PrefetchingTermLookup should use new terms storage is done since it's going to cause merge conflicts, etc.

I feel a need to mention that, aside from possible merge conflicts, which is an argument related to pragmatics, those legacy service containers and their config should only be removed when all code paths using them have been removed. This currently is not the case. Change default config is a step in this direction, but it should become impossible for the system to reach these, which is a bit of more effort.

Addshore triaged this task as High priority.Jan 14 2020, 4:09 PM
Addshore renamed this task from Remove old MultiRepository & PerRepository Service containers and config to entitysources: Remove old MultiRepository & PerRepository Service containers and config.Jan 16 2020, 4:33 PM

Change 569255 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed useEntitySourceBasedFederation config option

https://gerrit.wikimedia.org/r/569255

Change 569263 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Wikibase: Removed config option wmgUseEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/569263

Change 569330 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in RepoHooksTest

https://gerrit.wikimedia.org/r/569330

Change 569331 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in DataAccessSnakFormatterOutputFormatTest

https://gerrit.wikimedia.org/r/569331

Change 569333 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Swapped DataAccessSettingsFactory::anySetting to entity source one

https://gerrit.wikimedia.org/r/569333

Change 569334 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RepoHooks

https://gerrit.wikimedia.org/r/569334

Change 569335 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in PropertyInfoTable

https://gerrit.wikimedia.org/r/569335

Change 569376 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in SqlEntityInfoBuilder

https://gerrit.wikimedia.org/r/569376

Change 569378 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] WIP Removed "non-entity-source" conditional logic in TermSqlIndex

https://gerrit.wikimedia.org/r/569378

Change 572261 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RebuildTermSqlIndex

https://gerrit.wikimedia.org/r/572261

Change 572265 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RebuildPropertyInfo

https://gerrit.wikimedia.org/r/572265

Change 572278 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/572278

Change 572279 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in EntityContentFactory

https://gerrit.wikimedia.org/r/572279

Change 572280 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityStore

https://gerrit.wikimedia.org/r/572280

Change 572284 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in HtmlPageLinkRendererBeginHookHandler

https://gerrit.wikimedia.org/r/572284

WMDE-leszek updated the task description. (Show Details)Mon, Feb 17, 9:50 AM
WMDE-leszek updated the task description. (Show Details)Tue, Feb 18, 6:23 PM

Change 573347 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in SearchEntities API class

https://gerrit.wikimedia.org/r/573347