Page MenuHomePhabricator
Create Task
Maniphest T214557

Allow accessing Wikibase entities from multiple (Wikibase) databases
Closed, ResolvedPublic
Actions

Description

Following the discussion in T211800, assuming for now a single entity type can only be provided by single Wikibase instance, make it possible for wikibase to access entities provided by multiple sources.
For now, only direct database database access is considered.

The general idea would be to define "sources" that are providing entities of particular type. Services providing access to entity data will be defined per source (i,e. a particular service is configured to access the database of given source/instance/repository). Wikibase will determine which source-specific service to use to access data of particular entity based on the entity-type vs source configuration.

Entity ID prefixes are not considered for now, as long as there is no technical need (state January 2019) to have a single entity type provided by multiple Wikibase instances/sources./databases.

Update January 2020:

The implementation of "entity-source-based federation" is almost completed (remaining changes have related patches on gerrit) Wikibase Repo "component" (enabled instead of "repository-prefix-based" one using configuration setting), and also close to complete in the Wikibase Client "component".
After finishing the implementation, the remaining step to complete this work would be to remove the "use entity source based federation" setting and disable the possibility to use "repository-prefix-based federation". Consequently all code paths related to "repository-prefix-based federation" would be dropped.

The known remaining steps are listed below (list not complete as of 2020-01-15, being continuously updated) - note the list is broken in the ordered "steps", order of items in the "step" might be arbitrary

...

A follow up to this task removing all of the stuff that this task replaces can be found at T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

Details

SubjectRepoBranchLines +/-
Added wmgWikibaseRepoLocalEntitySourceName to define the "local" source of Wikibase Repooperations/mediawiki-configmaster+5 -0
Added wmgWikibaseEntitySources setting for defining Wikibase "entity sources"operations/mediawiki-configmaster+8 -0
DNM Define Wikibase "entity sources" on beta commonsoperations/mediawiki-configmaster+24 -0
Removed now-redundant tests cases in RepoHooksTestmediawiki/extensions/Wikibasemaster+14 -136
Added RdfDumpGenerator test cases for entity source based access modemediawiki/extensions/Wikibasemaster+197 -0
Removed now-redundant tests cases in TermStoreWriter testsmediawiki/extensions/Wikibasemaster+10 -436
Removed now-redundant tests cases in DataAccessSnakFormatterOutputFormatTestmediawiki/extensions/Wikibasemaster+0 -37
Removed useEntitySourceBasedFederation config optionmediawiki/extensions/Wikibasemaster+5 -291
Adjusted SearchEntities API class to use concept uri data from entity sourcesmediawiki/extensions/Wikibasemaster+26 -12
Reorganized slightly ValidatorBuildersTestmediawiki/extensions/Wikibasemaster+55 -90
Do not prefix IDs in HtmlPageLinkRendererBeginHookHandler when not neededmediawiki/extensions/Wikibasemaster+330 -14
Make it impossible to write to non local database in PropertyInfoTablemediawiki/extensions/Wikibasemaster+42 -0
Adjusted RepoLinker to use concept uri data from entity sourcesmediawiki/extensions/Wikibasemaster+28 -10
rebuildTermSqlIndex: Adjusted constructor to use right "entity source"mediawiki/extensions/Wikibasemaster+1 -1
Made WikibaseClient::getRepoItemUriParser use data from entity source definitions, when "entity source based federation" in usemediawiki/extensions/Wikibasemaster+68 -4
EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entitiesmediawiki/extensions/Wikibasewmf/1.35.0-wmf.16+6 -0
Test EntitySourceDefitions::getEntityTypeToSourceMapping with subsmediawiki/extensions/Wikibasemaster+26 -4
EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entitiesmediawiki/extensions/Wikibasemaster+6 -0
Prefix the value namespace in the RDF outputmediawiki/extensions/Wikibasemaster+118 -46
WikibaseRepo: (conditionally) use entity source definitions instead of conceptBaseUri settingmediawiki/extensions/Wikibasemaster+4 -0
Constructing GenericServices: use entity source defintions when applicablemediawiki/extensions/Wikibasemaster+22 -4
Use (conditionally) EntitySourceDefinitions in WikibaseRepo::getEnabledEntityTypesmediawiki/extensions/Wikibasemaster+91 -1
WikibaseRepo::newValidatorBuilders: do not rely on RepositoryDefinitions when the "entity source based federation" is in use.mediawiki/extensions/Wikibasemaster+12 -7
Use (conditionally) EntitySourceDefinitions in WikibaseRepo::getLocalEntityTypesmediawiki/extensions/Wikibasemaster+66 -0
Moved out logic on creating entity source definitions from backwards compatible settings out of WikibaseRepo/Clientmediawiki/extensions/Wikibasemaster+747 -183
Adjust constructor calls in SparqlHelperTestmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -26
Temporarily skip some tests due to on-going changes to Wikibasemediawiki/extensions/WikibaseQualityConstraintsmaster+24 -0
Adjust integration test clean up to have test pass also when EntitySources based federation is in usemediawiki/extensions/WikibaseLexememaster+41 -7
docs, update federation docsmediawiki/extensions/Wikibasemaster+45 -20
docs, update services.md for current statemediawiki/extensions/Wikibasemaster+141 -51
Restored the skipped test after changes to Wikibasemediawiki/extensions/WikibaseQualityConstraintsmaster+1 -3
Prefix statement, and reference namespaces in RDF outputmediawiki/extensions/Wikibasemaster+30 -9
Added prefixes to document (data) URIs in the RDF outputmediawiki/extensions/Wikibasemaster+149 -56
Temporarily skip a testmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -0
Added a service generating canonical URLs of "document" pages for defined Entity Sourcesmediawiki/extensions/Wikibasemaster+98 -0
Adjusted calls to RdfVocabulary methodsmediawiki/extensions/WikibaseQualityConstraintsmaster+175 -57
Prefix RDF (turtle) namespaces with configurable prefixes instead of using a source/repository suffixmediawiki/extensions/Wikibasemaster+629 -151
Temporarily skip tests instantiating RdfVocabulary object from Wikibasemediawiki/extensions/WikibaseQualityConstraintsmaster+26 -1
Add RDF namespace prefixes to the entity source configmediawiki/extensions/Wikibasemaster+316 -36
Updated MediaInfoRdfBuilder after changes to Wikibase's RdfVocabularymediawiki/extensions/WikibaseMediaInfomaster+9 -5
Restore tests for new RdfVocabulary ctormediawiki/extensions/WikibaseQualityConstraintsmaster+6 -20
Add tests for RDF mapping for the properties defined in "foreign" entity sourcesmediawiki/extensions/Wikibasemaster+3 K -4
Made RdfVocabulary work with EntitySourcesmediawiki/extensions/Wikibasemaster+526 -59
Temporarily skip tests creating RdfVocabulary instancemediawiki/extensions/WikibaseQualityConstraintsmaster+22 -0
Documented entity-source-related config options.mediawiki/extensions/Wikibasemaster+10 -0
Added a dedicated config setting for entity sources, and a service processing itmediawiki/extensions/Wikibasemaster+413 -3
Fixed WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor when using "entity source based federation"mediawiki/extensions/Wikibasemaster+1 -1
Added wmgUseEntitySourceBasedFederation setting to switch the federation mechanismoperations/mediawiki-configmaster+6 -0
DNM Use "entity source based federation" on Beta Commonsoperations/mediawiki-configmaster+5 -0
Made RepoLinker aware of entity sourcesmediawiki/extensions/Wikibasemaster+123 -7
Added EntitySource to WikiPageEntityStoremediawiki/extensions/Wikibasemaster+680 -14
BETA: wmgUseEntitySourceBasedFederation trueoperations/mediawiki-configmaster+3 -0
Fixed entity-source-based-access branch of WikibaseRepo::getEntityTypeToRepositoryMappingmediawiki/extensions/Wikibasemaster+2 -2
Do not use ForeignEntityValidator when using entity-source based access to other Wikibase instance entitiesmediawiki/extensions/Wikibasemaster+129 -2
Wikibase.php, add conditional setting of useEntitySourceBasedFederationoperations/mediawiki-configmaster+8 -0
wbsearchentities: Show name of entity source name in "repository" part of API responsemediawiki/extensions/Wikibasemaster+15 -3
Use prefix of the entity source when generating Title objects in EntityContentFactorymediawiki/extensions/Wikibasemaster+15 -5
Add interwiki prefix to Entity Sourcemediawiki/extensions/Wikibasemaster+108 -39
Take EntitySources into account in EntityContentFactory::getTitleForIdmediawiki/extensions/Wikibasemaster+124 -3
Use concept base URIs from source definitions when using source config instead of repository prefix onemediawiki/extensions/Wikibasemaster+196 -14
Added concept base URI to Entity Source and Definitionsmediawiki/extensions/Wikibasemaster+136 -57
Added WikibaseClient::getItemTermIndexmediawiki/extensions/Wikibasemaster+46 -1
Use MultipleEntitySourceServices as a drop-in replacement for repo-based WikibaseServicesmediawiki/extensions/Wikibasemaster+400 -48
MultipleEntitySourceServices implements WikibaseServices interfacemediawiki/extensions/Wikibasemaster+55 -2
Added PropertyInfoLookup to *EntitySourceServicesmediawiki/extensions/Wikibasemaster+85 -1
Added EntitySource to PropertyInfoTablemediawiki/extensions/Wikibasemaster+350 -22
Added EntityPrefetcher to *EntitySourceServicesmediawiki/extensions/Wikibasemaster+71 -0
Adjust WikiPageEntityMetaDataLookup constructor call and re-enabled the testmediawiki/extensions/WikibaseMediaInfomaster+12 -2
Added EntitySource to WikiPageEntityMetaDataLookupmediawiki/extensions/Wikibasemaster+419 -19
Added ByTypeDispatchingEntityPrefetchermediawiki/extensions/Wikibasemaster+283 -1
Added PrefetchingTermLookup to *EntitySourceServicesmediawiki/extensions/Wikibasemaster+90 -2
Temporarily skip tests that call WikiPageEntityMetaDataLookup's constructormediawiki/extensions/WikibaseMediaInfomaster+2 -0
Added TermSearchInteractoryFactory to *EntitySourceServicesmediawiki/extensions/Wikibasemaster+103 -0
Added ByTypeDispatchingPrefetchingTermLookupmediawiki/extensions/Wikibasemaster+384 -1
Added EntitySource to TermSqlIndexmediawiki/extensions/Wikibasemaster+876 -24
Added EntityInfoBuilder to *EntitySourceServicesmediawiki/extensions/Wikibasemaster+86 -3
Added EntitySource to SqlEntityInfoBuildermediawiki/extensions/Wikibasemaster+218 -6
Added dummy EntitySource class exploding whenever usedmediawiki/extensions/Wikibasemaster+99 -0
Added useEntitySourceBasedFederation flag to DataAccessSettingsmediawiki/extensions/Wikibasemaster+36 -13
Added ByTypeDispatchingEntityInfoBuildermediawiki/extensions/Wikibasemaster+151 -0
Added test for MultipleEntitySourceServices::getEntityRevisionLookupmediawiki/extensions/Wikibasemaster+29 -0
Added tests for MultipleEntitySourceServices' EntityStoreWatcher behaviourmediawiki/extensions/Wikibasemaster+88 -0
Followup docs & tests for *EntitySourceServicesmediawiki/extensions/Wikibasemaster+165 -1
Added SingleEntitySourceServices and MultipleEntitySourceServicesmediawiki/extensions/Wikibasemaster+268 -0
Added ByTypeDispatchingEntityRevisionLookupmediawiki/extensions/Wikibasemaster+216 -0
Added EntitySource and EntitySourceDefinitionsmediawiki/extensions/Wikibasemaster+364 -0
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 Resolved• Ramsey-WMFT199352 Deploy Structured Data on Commons with arbitrary Statements
 ResolvedCparleT204264 "Depicts crawling": Add displaying/editing statements to File page
 ResolvedJdforrester-WMFT218913 Enable Depicts in production
 ResolvedJdforrester-WMFT214075 Enable federated access to entities and properties from Wikidata to Commons
 ResolvedNoneT212144 Allow access to MediaInfo from wikitext on Commons
 InvalidNoneT211800 Resolve ambiguity of entity ID prefixes used on Commons.
 ResolvedWMDE-leszekT214557 Allow accessing Wikibase entities from multiple (Wikibase) databases
 ResolvedWMDE-leszekT216686 beta wikidata API: LogicException (UnusableEntitySource used)
 ResolvedNoneT242415 EntitySourceDefinitions to use 'sub-entity-type' entity type definition information
 ResolvedWMDE-leszekT243184 entitysources: Client: adjust WikibaseClient::getRepoItemUriParser
 ResolvedWMDE-leszekT243185 entitysources: Client: adjust WikibaseClient::getRecentChangeFactory
 ResolvedWMDE-leszekT243186 entitysources: Client: adjust WikibaseClient::getStore
 ResolvedWMDE-leszekT243187 entitysources: Client: adjust UpdateRepoHookHandlers::newFromGlobalState
 ResolvedWMDE-leszekT243188 entitysources: Client: adjust UpdateSubscriptions::execute
 DuplicateNoneT243190 entitysources: Switch the default value of the useEntitySourceBasedFederation to true in both Repo and Client
 ResolvedAddshoreT243769 entitysources: DatabasePropertyTermStore and DatabaseItemTermStore should not perform any writes operations for items/properties from non-local source
 ResolvedAddshoreT243846 Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions
 ResolvedAddshoreT243841 LogicException UnusableEntitySource on fresh install of Wikibase from PropertyInfoTable.php(74): Wikibase\DataAccess\UnusableEntitySource->getDatabaseName()

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
WMDE-leszek updated the task description. (Show Details)Jan 15 2020, 11:55 AM
In T214557#5693466, @Addshore wrote:

@WMDE-leszek which bits of this should the campsite be looking at? / what is ready for review vs doing?

Sorry for the late reply. It took me a bit to review the current state of thing there. I've updated the task description with what I believe is the current state, and tried to outline the remaining steps.
It might make sense to break down certain "steps" from this already long task for better prioritization etc.

WMDE-leszek updated the task description. (Show Details)Jan 16 2020, 12:46 PM
WMDE-leszek closed subtask T242415: EntitySourceDefinitions to use 'sub-entity-type' entity type definition information as Resolved.Jan 16 2020, 12:54 PM
gerritbot added a comment.Jan 16 2020, 1:54 PM

Change 494051 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Use (conditionally) EntitySourceDefinitions in WikibaseRepo::getLocalEntityTypes

https://gerrit.wikimedia.org/r/494051

gerritbot added a comment.Jan 16 2020, 2:17 PM

Change 490145 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Moved out logic on creating entity source definitions from backwards compatible settings out of WikibaseRepo/Client

https://gerrit.wikimedia.org/r/490145

gerritbot added a comment.Jan 16 2020, 2:20 PM

Change 494051 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use (conditionally) EntitySourceDefinitions in WikibaseRepo::getLocalEntityTypes

https://gerrit.wikimedia.org/r/494051

Addshore updated the task description. (Show Details)Jan 16 2020, 2:24 PM
gerritbot added a comment.Jan 16 2020, 2:42 PM

Change 494052 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] WikibaseRepo::newValidatorBuilders: do not rely on RepositoryDefinitions when the "entity source based federation" is in use.

https://gerrit.wikimedia.org/r/494052

gerritbot added a comment.Jan 16 2020, 2:43 PM

Change 494650 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Constructing GenericServices: use entity source defintions when applicable

https://gerrit.wikimedia.org/r/494650

gerritbot added a comment.Jan 16 2020, 2:44 PM

Change 494651 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use (conditionally) EntitySourceDefinitions in WikibaseRepo::getEnabledEntityTypes

https://gerrit.wikimedia.org/r/494651

gerritbot added a comment.Jan 16 2020, 2:47 PM

Change 564976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] WikibaseRepo: (conditionally) use entity source definitions instead of conceptBaseUri setting

https://gerrit.wikimedia.org/r/564976

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.16; 2020-01-21); removed MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 16 2020, 3:00 PM
Addshore updated the task description. (Show Details)Jan 16 2020, 4:43 PM
Addshore claimed this task.Jan 17 2020, 12:43 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 17 2020, 12:43 PM
Addshore updated the task description. (Show Details)Jan 17 2020, 4:48 PM
gerritbot added a comment.Jan 17 2020, 5:09 PM

Change 533202 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Prefix the value namespace in the RDF output

https://gerrit.wikimedia.org/r/533202

Addshore removed Addshore as the assignee of this task.Jan 20 2020, 10:23 AM
Addshore moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore mentioned this in T243184: entitysources: Client: adjust WikibaseClient::getRepoItemUriParser.Jan 20 2020, 11:37 AM
Addshore mentioned this in T243185: entitysources: Client: adjust WikibaseClient::getRecentChangeFactory.
Addshore mentioned this in T243186: entitysources: Client: adjust WikibaseClient::getStore.
Addshore mentioned this in T243187: entitysources: Client: adjust UpdateRepoHookHandlers::newFromGlobalState.
Addshore mentioned this in T243188: entitysources: Client: adjust UpdateSubscriptions::execute.
Addshore updated the task description. (Show Details)
Addshore moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore updated the task description. (Show Details)Jan 20 2020, 11:46 AM
Addshore mentioned this in T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.Jan 20 2020, 11:48 AM
Addshore mentioned this in T243190: entitysources: Switch the default value of the useEntitySourceBasedFederation to true in both Repo and Client.
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)Jan 20 2020, 2:11 PM
gerritbot added a comment.Jan 22 2020, 10:10 AM

Change 494055 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] WIP Made WikibaseClient::getRepoItemUriParser use data from entity source definitions, when "entity source based federation" in use

https://gerrit.wikimedia.org/r/494055

WMDE-leszek moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2020, 10:26 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2020, 10:52 AM
gerritbot added a comment.Jan 23 2020, 12:48 PM

Change 566720 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566720

gerritbot added a comment.Jan 23 2020, 12:51 PM

Change 566721 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566721

gerritbot added a comment.Jan 23 2020, 1:46 PM

Change 566732 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Test EntitySourceDefitions::getEntityTypeToSourceMapping with subs

https://gerrit.wikimedia.org/r/566732

gerritbot added a comment.Jan 23 2020, 3:26 PM

Change 566720 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566720

gerritbot added a comment.Jan 23 2020, 3:50 PM

Change 566732 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test EntitySourceDefitions::getEntityTypeToSourceMapping with subs

https://gerrit.wikimedia.org/r/566732

gerritbot added a comment.Jan 23 2020, 3:57 PM

Change 566721 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566721

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 23 2020, 4:01 PM
Stashbot mentioned this in T242415: EntitySourceDefinitions to use 'sub-entity-type' entity type definition information.Jan 23 2020, 4:02 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-23T16:02:40Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.16/extensions/Wikibase/data-access/src/EntitySourceDefinitions.php: [[gerrit:566721|EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities (T242415 T214557)]] (duration: 01m 08s)

gerritbot added a comment.Jan 27 2020, 10:35 AM

Change 494055 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Made WikibaseClient::getRepoItemUriParser use data from entity source definitions, when "entity source based federation" in use

https://gerrit.wikimedia.org/r/494055

WMDE-leszek closed subtask T243186: entitysources: Client: adjust WikibaseClient::getStore as Resolved.Jan 27 2020, 1:39 PM
WMDE-leszek closed subtask T243185: entitysources: Client: adjust WikibaseClient::getRecentChangeFactory as Resolved.
WMDE-leszek closed subtask T243184: entitysources: Client: adjust WikibaseClient::getRepoItemUriParser as Resolved.
WMDE-leszek closed subtask T243187: entitysources: Client: adjust UpdateRepoHookHandlers::newFromGlobalState as Resolved.
WMDE-leszek closed subtask T243188: entitysources: Client: adjust UpdateSubscriptions::execute as Resolved.
WMDE-leszek updated the task description. (Show Details)Jan 27 2020, 1:59 PM
Addshore added a subtask: T243846: Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions.Jan 28 2020, 3:54 PM
gerritbot added a comment.Jan 31 2020, 5:58 PM

Change 569255 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed useEntitySourceBasedFederation config option

https://gerrit.wikimedia.org/r/569255

gerritbot added a comment.Feb 1 2020, 6:24 PM

Change 569325 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Adjusted RepoLinker to use concept uri data from entity sources

https://gerrit.wikimedia.org/r/569325

gerritbot added a comment.Feb 1 2020, 6:24 PM

Change 569326 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Adjusted SearchEntities API class to use concept uri data from entity sources

https://gerrit.wikimedia.org/r/569326

gerritbot added a comment.Feb 1 2020, 6:24 PM

Change 569327 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Added RdfDumpGenerator test cases for entity source based access mode

https://gerrit.wikimedia.org/r/569327

gerritbot added a comment.Feb 1 2020, 6:25 PM

Change 569328 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Reorganized slightly ValidatorBuildersTest

https://gerrit.wikimedia.org/r/569328

gerritbot added a comment.Feb 1 2020, 6:25 PM

Change 569329 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] rebuildTermSqlIndix: Adjusted constructor to use right "entity source"

https://gerrit.wikimedia.org/r/569329

gerritbot added a comment.Feb 1 2020, 6:41 PM

Change 569330 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in RepoHooksTest

https://gerrit.wikimedia.org/r/569330

gerritbot added a comment.Feb 1 2020, 6:44 PM

Change 569331 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in DataAccessSnakFormatterOutputFormatTest

https://gerrit.wikimedia.org/r/569331

gerritbot added a comment.Feb 1 2020, 7:37 PM

Change 569332 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Make it impossible to write to non local database in PropertyInfoTable

https://gerrit.wikimedia.org/r/569332

Addshore closed subtask T243846: Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions as Resolved.Feb 3 2020, 9:30 AM
Addshore closed subtask T243769: entitysources: DatabasePropertyTermStore and DatabaseItemTermStore should not perform any writes operations for items/properties from non-local source as Resolved.
gerritbot added a comment.Feb 7 2020, 9:09 AM

Change 569329 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] rebuildTermSqlIndex: Adjusted constructor to use right "entity source"

https://gerrit.wikimedia.org/r/569329

gerritbot added a comment.Feb 7 2020, 9:09 AM

Change 569325 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Adjusted RepoLinker to use concept uri data from entity sources

https://gerrit.wikimedia.org/r/569325

gerritbot added a comment.Feb 7 2020, 9:52 AM

Change 569332 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make it impossible to write to non local database in PropertyInfoTable

https://gerrit.wikimedia.org/r/569332

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.19; 2020-02-11); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 7 2020, 10:00 AM
gerritbot added a comment.Feb 7 2020, 12:23 PM

Change 570879 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Do not prefix IDs in HtmlPageLinkRendererBeginHookHandler when not needed

https://gerrit.wikimedia.org/r/570879

Addshore added a comment.Feb 7 2020, 12:44 PM

Entity source based federation (implemented in this ticket) is now deployed and enabled everywhere.
Now just to remove the old stuff.

Addshore added a comment.Feb 7 2020, 12:48 PM

Except for https://phabricator.wikimedia.org/T241971 making it the wikibase default

gerritbot added a comment.Feb 7 2020, 1:40 PM

Change 570879 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not prefix IDs in HtmlPageLinkRendererBeginHookHandler when not needed

https://gerrit.wikimedia.org/r/570879

gerritbot added a comment.Feb 7 2020, 2:03 PM

Change 569328 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reorganized slightly ValidatorBuildersTest

https://gerrit.wikimedia.org/r/569328

gerritbot added a comment.Feb 7 2020, 2:12 PM

Change 569326 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Adjusted SearchEntities API class to use concept uri data from entity sources

https://gerrit.wikimedia.org/r/569326

WMDE-leszek closed this task as Resolved.Feb 18 2020, 6:16 PM
WMDE-leszek claimed this task.
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from Stalled/Waiting to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek mentioned this in T245547: Remove useEntitySourceBasedFederation setting.Feb 18 2020, 6:22 PM
gerritbot added a comment.Feb 20 2020, 9:12 AM

Change 569255 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed useEntitySourceBasedFederation config option

https://gerrit.wikimedia.org/r/569255

gerritbot added a comment.Feb 20 2020, 9:13 AM

Change 569331 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in DataAccessSnakFormatterOutputFormatTest

https://gerrit.wikimedia.org/r/569331

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 20 2020, 10:01 AM
gerritbot added a comment.Feb 20 2020, 4:02 PM

Change 573607 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in TermStoreWriter tests

https://gerrit.wikimedia.org/r/573607

gerritbot added a comment.Feb 21 2020, 9:16 AM

Change 573607 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in TermStoreWriter tests

https://gerrit.wikimedia.org/r/573607

WMDE-leszek mentioned this in T245817: Remove conditional "federation mode" logic from the services in the "storage layer".Feb 21 2020, 11:03 AM
WMDE-leszek mentioned this in T245830: Remove conditional "federation mode" logic from the Wikibase API and hook code.Feb 21 2020, 2:13 PM
WMDE-leszek mentioned this in T245831: Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code.Feb 21 2020, 2:31 PM
gerritbot added a comment.Feb 21 2020, 4:04 PM

Change 569327 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Added RdfDumpGenerator test cases for entity source based access mode

https://gerrit.wikimedia.org/r/569327

gerritbot added a comment.Feb 21 2020, 5:34 PM

Change 569330 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed now-redundant tests cases in RepoHooksTest

https://gerrit.wikimedia.org/r/569330

WMDE-leszek mentioned this in T245860: Remove conditional "federation mode" logic from the Wikibase "top-level" factories.Feb 21 2020, 7:34 PM
Addshore mentioned this in T248458: Remove "repositories" response from SearchEntities for Federated Property calls.Mar 25 2020, 11:13 AM
Addshore mentioned this in T257260: entitysources: Clean up any remainders of the legacy back/compat config in the mediawiki-config repository.Jun 23 2021, 8:53 AM
gerritbot added a comment.Jun 23 2021, 8:57 AM

Change 490108 abandoned by Addshore:

[operations/mediawiki-config@master] DNM Define Wikibase "entity sources" on beta commons

Reason:

Looks done to me somewhere else https://codesearch.wmcloud.org/operations/?q=wmgWikibaseRepoLocalEntitySourceName&i=nope&files=&excludeFiles=&repos=

https://gerrit.wikimedia.org/r/490108

gerritbot added a comment.Jun 23 2021, 8:58 AM

Change 490104 abandoned by Addshore:

[operations/mediawiki-config@master] Added wmgWikibaseEntitySources setting for defining Wikibase "entity sources"

Reason:

Also looks done to me https://codesearch.wmcloud.org/operations/?q=wmgWikibaseEntitySources&i=nope&files=&excludeFiles=&repos=

https://gerrit.wikimedia.org/r/490104

gerritbot added a comment.Jun 23 2021, 8:58 AM

Change 490633 abandoned by Addshore:

[operations/mediawiki-config@master] Added wmgWikibaseRepoLocalEntitySourceName to define the "local" source of Wikibase Repo

Reason:

Also looks done to me https://codesearch.wmcloud.org/operations/?q=wmgWikibaseRepoLocalEntitySourceName&i=nope&files=&excludeFiles=&repos=

https://gerrit.wikimedia.org/r/490633

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits