Page MenuHomePhabricator

Cookie mw-tour will be soon rejected because it has the “sameSite” attribute set to “none”, without the “secure” attribute.
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:
Use MediaWiki-extensions-GuidedTour on a wiki and open the JavaScript console.

Actual Results
In Firefox:

Cookie “mw-tour” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute. To know more about the “sameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Expected Results
No warning in the JavaScript console.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1092228 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GuidedTour@master] Fix sameSite cookie warning

https://gerrit.wikimedia.org/r/1092228

Change #1092228 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Fix sameSite cookie warning

https://gerrit.wikimedia.org/r/1092228

QA Note: this probably can't be tested beyond trying out that tours still work and still continue where one left off when one abandoned them in the middle. (Also, now there should be no cookie warning in the console related to tours specifically. There will likely be still some unrelated cookie warnings in the console.)

Etonkovidova subscribed.

QA Note: this probably can't be tested beyond trying out that tours still work and still continue where one left off when one abandoned them in the middle. (Also, now there should be no cookie warning in the console related to tours specifically. There will likely be still some unrelated cookie warnings in the console.)

Thx, @Michael! Checked on wmf.4 with`?tour=test` - no cookie warnings.