Page MenuHomePhabricator
Create Task
Maniphest T258060

localEntitySourceName is a misleading setting in some cases
Closed, ResolvedPublic
Actions

Description

Discovered when rolling out T254315 for commonswiki

For repo this right now is indeed the local repo.
For client however, this is the name of main repo? use for data access and sitelinks etc?

In T254315#6304786, @Addshore wrote:

And it looks like getDatabaseDomainNameOfLocalRepo is used in to make the sqlstore.
For testcommons & commons his will be the local wikibase.
This should NOT be used to access the site store... as the local wikibase does not hold the data about items (which is where the sitelinks are).
This is likely the cause of issues found in T257266

Related to / caused in T243186: entitysources: Client: adjust WikibaseClient::getStore

Entity source docs: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_entitysources.html

Details

SubjectRepoBranchLines +/-
Remove localEntitySourceName client settingmediawiki/extensions/Wikibasemaster+1 -4
Remove `wmgWikibaseClientLocalEntitySourceName` from InitialiseSettings.phpoperations/mediawiki-configmaster+0 -6
Use `wmgWikibaseClientItemAndPropertySourceName` instead of `wmgWikibaseClientLocalEntitySourceName` in Wikibase.phpoperations/mediawiki-configmaster+2 -2
Add `wmgWikibaseClientItemAndPropertySourceName` to InitialiseSettings.phpoperations/mediawiki-configmaster+6 -0
Rename localEntitySourceName to itemAndPropertySourceName for Wikibase Clientmediawiki/extensions/Wikibasemaster+29 -21
Improve docs for 'localEntitySourceName'mediawiki/extensions/WikibaseREL1_35+8 -2
Improve docs for 'localEntitySourceName'mediawiki/extensions/Wikibasemaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Jul 15 2020, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 1:37 PM
gerritbot added a comment.Jul 15 2020, 1:37 PM

Change 612663 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612663

gerritbot added a project: Patch-For-Review.Jul 15 2020, 1:37 PM
Addshore added projects: Wikidata, [DEPRECATED] wdwb-tech.Jul 15 2020, 1:37 PM
gerritbot added a comment.Jul 15 2020, 2:29 PM

Change 612663 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612663

gerritbot added a comment.Jul 15 2020, 2:43 PM

Change 612725 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@REL1_35] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612725

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 3:00 PM
gerritbot added a comment.Jul 15 2020, 3:01 PM

Change 612725 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612725

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 3:10 PM
Aklapper renamed this task from localEntitySourceName is a missleading setting in some cases to localEntitySourceName is a misleading setting in some cases.Jul 15 2020, 7:47 PM
darthmon_wmde added a project: Wikidata-Campsite.Jul 20 2020, 9:29 AM
darthmon_wmde moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Aug 18 2020, 12:46 PM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Aug 18 2020, 1:15 PM
Michael subscribed.Aug 20 2020, 12:40 PM

Looking at https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_options.html#autotoc_md256, I'm still not sure about this.

Repo: This should likely ALWAYS be the name of the entity source of the LOCAL repository (same site)

  • Can a Repo have multiple entity sources on the same local site?
  • If not, then is there a setup where setting it and not setting it are both valid options that result in different outcomes?
  • Is there something else I'm missing?
  • If none of those are true, then it would seem that for a Repo the valid value of this setting is entirely determined by the setup and thus the setting should probably be removed.

Client: This should be the name of the entity source of the site containing Item definitions (data is used from here, including sitelinks)

  • Could someone specify what "data" refers to here, besides sitelinks?
  • Possible names for that setting:
    • mainEntitySourceName
    • metaDataEntitySourceName
    • sitelinkEntitySourceName
    • ...
ItamarWMDE claimed this task.Aug 20 2020, 3:32 PM
ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Aug 26 2020, 1:57 PM

Change 622573 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Rename localEntitySourceName to mainEntitySourceName

https://gerrit.wikimedia.org/r/622573

gerritbot added a project: Patch-For-Review.Aug 26 2020, 1:57 PM
gerritbot added a comment.Aug 26 2020, 4:26 PM

Change 622612 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Rename localEntitySourceName setting

https://gerrit.wikimedia.org/r/622612

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 26 2020, 5:18 PM
gerritbot added a comment.Aug 28 2020, 1:24 PM

Change 622993 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Use wmgWikibaseClientMainEntitySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php

https://gerrit.wikimedia.org/r/622993

gerritbot added a comment.Aug 28 2020, 1:27 PM

Change 622994 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php

https://gerrit.wikimedia.org/r/622994

gerritbot added a comment.Sep 1 2020, 11:35 AM

Change 622573 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename localEntitySourceName to itemAndPropertySourceName for Wikibase Client

https://gerrit.wikimedia.org/r/622573

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Sep 1 2020, 1:01 PM
Lucas_Werkmeister_WMDE subscribed.Sep 15 2020, 4:32 PM

The three attached config changes all look fine to me. Are they scheduled for deployment already? (As far as I can tell there’s nothing else left to review here.)

gerritbot added a comment.Sep 16 2020, 3:16 PM

Change 622612 merged by jenkins-bot:
[operations/mediawiki-config@master] Add wmgWikibaseClientItemAndPropertySourceName to InitialiseSettings.php

https://gerrit.wikimedia.org/r/622612

Stashbot added a comment.Sep 16 2020, 3:21 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:21:07Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:622612|Add wmgWikibaseClientItemAndPropertySourceName to InitialiseSettings.php (T258060)]] (duration: 01m 06s)

gerritbot added a comment.Sep 16 2020, 3:22 PM

Change 622993 merged by jenkins-bot:
[operations/mediawiki-config@master] Use wmgWikibaseClientItemAndPropertySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php

https://gerrit.wikimedia.org/r/622993

Stashbot added a comment.Sep 16 2020, 3:27 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:27:22Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:622993|Use wmgWikibaseClientItemAndPropertySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php (T258060)]] (duration: 01m 02s)

gerritbot added a comment.Sep 16 2020, 3:29 PM

Change 622994 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php

https://gerrit.wikimedia.org/r/622994

Stashbot added a comment.Sep 16 2020, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:33:36Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:622994|Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php (T258060)]] (duration: 01m 05s)

Stashbot added a comment.Sep 16 2020, 3:37 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:37:18Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:627871|Rename wmgWikibaseClientLocalEntitySourceName to wmgWikibaseClientItemAndPropertySourceName on Beta (T258060)]] (production no-op) (duration: 01m 04s)

Lucas_Werkmeister_WMDE added a comment.Sep 16 2020, 3:38 PM

Gerrit change https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/627871 also belongs to this task, I forgot to attach the task ID before it was merged.

Lucas_Werkmeister_WMDE removed ItamarWMDE as the assignee of this task.Sep 16 2020, 3:40 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a subscriber: ItamarWMDE.

The new name is now used in production; moving back to To Do for the complete removal of the old name. Do we want to announce this to third parties, by the way?

gerritbot added a comment.Sep 16 2020, 4:34 PM

Change 627879 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] DNM: Remove localEntitySourceName client setting

https://gerrit.wikimedia.org/r/627879

Rosalie_WMDE subscribed.Sep 17 2020, 7:52 AM
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 21 2020, 8:38 AM
WMDE-leszek subscribed.Sep 22 2020, 10:28 AM
In T258060#6466855, @Lucas_Werkmeister_WMDE wrote:

The new name is now used in production; moving back to To Do for the complete removal of the old name. Do we want to announce this to third parties, by the way?

Per discussion with Product Managers: we see no need to make an announcement about this change.

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 22 2020, 11:25 AM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 23 2020, 1:57 AM
gerritbot added a comment.Sep 23 2020, 2:18 AM

Change 627879 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove localEntitySourceName client setting

https://gerrit.wikimedia.org/r/627879

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 23 2020, 3:00 AM
WMDE-leszek closed this task as Resolved.Oct 7 2020, 8:56 AM
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE mentioned this in T277481: Move WikibaseClient EntitySourceOfLocalRepo to service container.Mar 15 2021, 4:27 PM
Lucas_Werkmeister_WMDE mentioned this in T278833: Remove ItemAndPropertySource from WikibaseClient.Mar 30 2021, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits