Page MenuHomePhabricator

localEntitySourceName is a misleading setting in some cases
Open, Needs TriagePublic

Description

Discovered when rolling out T254315 for commonswiki

For repo this right now is indeed the local repo.
For client however, this is the name of main repo? use for data access and sitelinks etc?

And it looks like getDatabaseDomainNameOfLocalRepo is used in to make the sqlstore.
For testcommons & commons his will be the local wikibase.
This should NOT be used to access the site store... as the local wikibase does not hold the data about items (which is where the sitelinks are).
This is likely the cause of issues found in T257266

Related to / caused in T243186: entitysources: Client: adjust WikibaseClient::getStore

Entity source docs: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_entitysources.html

Event Timeline

Addshore created this task.Jul 15 2020, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 1:37 PM

Change 612663 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612663

Change 612663 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612663

Change 612725 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@REL1_35] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612725

Change 612725 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Improve docs for 'localEntitySourceName'

https://gerrit.wikimedia.org/r/612725

Aklapper renamed this task from localEntitySourceName is a missleading setting in some cases to localEntitySourceName is a misleading setting in some cases.Jul 15 2020, 7:47 PM

Looking at https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_options.html#autotoc_md256, I'm still not sure about this.

Repo: This should likely ALWAYS be the name of the entity source of the LOCAL repository (same site)

  • Can a Repo have multiple entity sources on the same local site?
  • If not, then is there a setup where setting it and not setting it are both valid options that result in different outcomes?
  • Is there something else I'm missing?
  • If none of those are true, then it would seem that for a Repo the valid value of this setting is entirely determined by the setup and thus the setting should probably be removed.

Client: This should be the name of the entity source of the site containing Item definitions (data is used from here, including sitelinks)

  • Could someone specify what "data" refers to here, besides sitelinks?
  • Possible names for that setting:
    • mainEntitySourceName
    • metaDataEntitySourceName
    • sitelinkEntitySourceName
    • ...

Change 622573 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Rename localEntitySourceName to mainEntitySourceName

https://gerrit.wikimedia.org/r/622573

Change 622612 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Rename localEntitySourceName setting

https://gerrit.wikimedia.org/r/622612

Change 622993 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Use wmgWikibaseClientMainEntitySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php

https://gerrit.wikimedia.org/r/622993

Change 622994 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[operations/mediawiki-config@master] Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php

https://gerrit.wikimedia.org/r/622994

Change 622573 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename localEntitySourceName to itemAndPropertySourceName for Wikibase Client

https://gerrit.wikimedia.org/r/622573

The three attached config changes all look fine to me. Are they scheduled for deployment already? (As far as I can tell there’s nothing else left to review here.)

Change 622612 merged by jenkins-bot:
[operations/mediawiki-config@master] Add wmgWikibaseClientItemAndPropertySourceName to InitialiseSettings.php

https://gerrit.wikimedia.org/r/622612

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:21:07Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:622612|Add wmgWikibaseClientItemAndPropertySourceName to InitialiseSettings.php (T258060)]] (duration: 01m 06s)

Change 622993 merged by jenkins-bot:
[operations/mediawiki-config@master] Use wmgWikibaseClientItemAndPropertySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php

https://gerrit.wikimedia.org/r/622993

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:27:22Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:622993|Use wmgWikibaseClientItemAndPropertySourceName instead of wmgWikibaseClientLocalEntitySourceName in Wikibase.php (T258060)]] (duration: 01m 02s)

Change 622994 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php

https://gerrit.wikimedia.org/r/622994

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:33:36Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:622994|Remove wmgWikibaseClientLocalEntitySourceName from InitialiseSettings.php (T258060)]] (duration: 01m 05s)

Mentioned in SAL (#wikimedia-operations) [2020-09-16T15:37:18Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:627871|Rename wmgWikibaseClientLocalEntitySourceName to wmgWikibaseClientItemAndPropertySourceName on Beta (T258060)]] (production no-op) (duration: 01m 04s)

Gerrit change https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/627871 also belongs to this task, I forgot to attach the task ID before it was merged.

Lucas_Werkmeister_WMDE removed ItamarWMDE as the assignee of this task.Wed, Sep 16, 3:40 PM
Lucas_Werkmeister_WMDE added a subscriber: ItamarWMDE.

The new name is now used in production; moving back to To Do for the complete removal of the old name. Do we want to announce this to third parties, by the way?

Change 627879 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] DNM: Remove localEntitySourceName client setting

https://gerrit.wikimedia.org/r/627879

The new name is now used in production; moving back to To Do for the complete removal of the old name. Do we want to announce this to third parties, by the way?

Per discussion with Product Managers: we see no need to make an announcement about this change.

Change 627879 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove localEntitySourceName client setting

https://gerrit.wikimedia.org/r/627879