Page MenuHomePhabricator

Search & replace button is hard to find
Open, NormalPublic

Description

Problem screenshot

  1. Disabling "Enable dialogs for inserting links, tables and more" doessn't make clear that it will also disable Search & replace button.
  1. Search & replace button is hard to find in the toolbar unless you already know where it is (see image)

Version: unspecified
Severity: normal

Attached:

Details

Reference
bz23824

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:09 PM
bzimport added projects: WikiEditor, Design.
bzimport set Reference to bz23824.
bzimport added a subscriber: Unknown Object (MLST).

*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*

deepak.sh406 wrote:

(In reply to Platonides from comment #0)

Created attachment 7433 [details]
Problem screenshot

  1. Disabling "Enable dialogs for inserting links, tables and more" doessn't

make clear that it will also disable Search & replace button.

  1. Search & replace button is hard to find in the toolbar unless you already

know where it is (see image)

Hi, I am relatively new to mediawiki and thought this would be an easy bug to fix.
So, I gave it a try. 2nd part was quite clear to me and I have changed the location of search/replace button adjacent to insert buttons and since search/replace button has a left border, it will remain distinct from insert buttons (and easy to locate).
But, 1st part confused me a little. Are you refering to $wgWikiEditorFeatures array in Wikieditor.php file where you can disable the dialogs, or is it the "Enable wizards for inserting links, tables as well as Search and Replace button" in the Editing section of User Preferences? (I am using 1.23 and 1.24 versions of MW)

And also, in my opinion, since, disabling dialogs should either remove the button completely( if button solely depends on the usage of a dialog ) or use dialog-less way (like inserting tables) (and Wikieditor does exactly that).So, I think this should be clear enough.

Please correct me if I am wrong anywhere.

Attached:

Change 149925 had a related patch set uploaded by TheDJ:
Change location of Search-Replace Link adjacent to Insert Links

https://gerrit.wikimedia.org/r/149925

Change 149925 had a related patch set uploaded (by Paladox):
Change location of Search-Replace Link adjacent to Insert Links

https://gerrit.wikimedia.org/r/149925

Patch-For-Review

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2015, 4:22 AM