Page MenuHomePhabricator

Pick a sentence: Highlight a specific sentence
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, a sentence will be focused for users to act on it.

Pick a sentence - Contents.png (768×1 px, 186 KB)
Pick a sentence - Contents Dimensions.png (768×1 px, 126 KB)

Highlighting takes place over the section contents (loading and showing them is covered in T259499), and users can select a different sentence by taping on it. Other tickets will support the card with actions to act on these.

More details in the parent task: T251551: Section Translation Editor: Pick a sentence

Event Timeline

Change 618143 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[mediawiki/services/wikispeech/wikispeech_mockup@master] Archive repo

https://gerrit.wikimedia.org/r/618143

Change 618143 merged by QChris:
[mediawiki/services/wikispeech/wikispeech_mockup@master] Archive repo

https://gerrit.wikimedia.org/r/618143

Some aspects I noticed:

  • Selecting the section title is not possible. It should be possible to select the section title in order to translate the section title. Since it is the first element it should be selected initially by default.
  • Card should not jump on each selection. The jump for the translation card (T260129) is only intended for cases when the user selects a sentence that was already highlighted. The card should not jump when selecting a sentence that is not already highlighted.
  • Highlight produces content reflow. When selecting a sentence it becomes highlighted and it seems to push the sentence after it. I've checked and the approach followed for the highlight was using a box shadow that should not be affecting the dimensions of the text. So some investigation may be required to check why this is happening. An example is shown below (note how the "The" word moves):

Sep-18-2020 12-17-04.gif (148×494 px, 284 KB)

@ngkountas do you prefer having separate tickets for these?

@Pginer-WMF I have created a new ticket concerning the first of the points you made above (i.e. Selecting the section title is not possible) here: T265220: Pick a sentence: Section title should be translatable. Given the fact that the other two issues have been addressed here in separate tickets (T263940: Pick a sentence: Fix content reflow on sentences that follow highlighted sentence, T260129: Pick a sentence: Feedback when tapping on selected sentences), I think we can close this ticket as resolved.

@Pginer-WMF I have created a new ticket concerning the first of the points you made above (i.e. Selecting the section title is not possible) here: T265220: Pick a sentence: Section title should be translatable. Given the fact that the other two issues have been addressed here in separate tickets (T263940: Pick a sentence: Fix content reflow on sentences that follow highlighted sentence, T260129: Pick a sentence: Feedback when tapping on selected sentences), I think we can close this ticket as resolved.

Makes perfect sense. Thanks for creating the ticket!