Page MenuHomePhabricator
Create Task
Maniphest T264904

Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak
Closed, ResolvedPublic
Actions

Description

at Object.wordbreak.isBreak  URL1:607:33
at Object.wordbreak.moveBreakOffset  URL1:605:829
at Object.wordbreak.prevBreakOffset  URL1:605:390
at VeDmElementLinearData.ve.dm.ElementLinearData.getWordRange  URL2:369:563
at VeCeSurface.ve.ce.Surface.maybeSetBreakpoint  URL2:555:172
at URL2:551:185

URL1: https://my.wikipedia.org/w/load.php?lang=my&modules=diffMatchPatch%2Cdompurify%2Cmoment%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.CodeMirror.visualEditor%7Cext.CodeMirror.visualEditor.init%7Cext.abuseFilter.visualEditor%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.confirmEdit.CaptchaInputWidget%2CvisualEditor%7Cext.disambiguator.visualEditor%7Cext.geshi.visualEditor%7Cext.graph.data%2CvisualEditor%7Cext.kartographer%7Cext.kartographer.editing%2Cutil%2CvisualEditor%7Cext.math.styles%2CvisualEditor%7Cext.score.visualEditor%7Cext.score.visualEditor.icons%7Cext.spamBlacklist.visualEditor%7Cext.templateDataGenerator.editPage%7Cext.titleblacklist.visualEditor%7Cext.visualEditor.data%2CmoduleIcons%2CmoduleIndicators%7Cext.wikihiero.visualEditor%7Cext.wikimediaEvents.visualEditor%7Cjquery.tablesorter%7Cjquery.tablesorter.styles%7Cmediawiki.ForeignStructuredUpload%2CForeignUpload%2CUpload%2Cpulsatingdot%2Cwidgets%7Cmediawiki.ForeignStructuredUpload.BookletLayout%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.diff.styles%7Cmediawiki.interface.helpers.styles%7Cmediawiki.language.months%2Cnames%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.AbandonEditDialog%2CCategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CTable%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-accessibility%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-user%2Cicons-wikimedia%2Cindicators&skin=vector&version=y2qhz
URL2: https://my.wikipedia.org/w/load.php?lang=my&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=11jjf

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.07/clienterror/?id=AXUC_gZD1pGl6xFM9VLE
Happening with low frequency.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (831a75cdb)mediawiki/extensions/VisualEditormaster+1 -1
Update UnicodeJS to v13.0.3VisualEditor/VisualEditormaster+53 -54
Always check prevCodepoint is non-nullunicodejsmaster+6 -0
Use next/prevCodepoint for checking for sot/eotunicodejsmaster+6 -4
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 7 2020, 3:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 3:47 PM
gerritbot added a comment.Oct 8 2020, 4:25 PM

Change 632957 had a related patch set uploaded (by Esanders; owner: Esanders):
[unicodejs@master] Use next/prevCodepoint for checking for sot/eot

https://gerrit.wikimedia.org/r/632957

gerritbot added a project: Patch-For-Review.Oct 8 2020, 4:25 PM
Jdforrester-WMF added a project: Utilities-UnicodeJS.Oct 8 2020, 4:59 PM
gerritbot added a comment.Oct 8 2020, 6:31 PM

Change 632957 merged by jenkins-bot:
[unicodejs@master] Use next/prevCodepoint for checking for sot/eot

https://gerrit.wikimedia.org/r/632957

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2020, 7:10 PM
Umherirrender added a project: JavaScript.Oct 13 2020, 8:17 PM
JTannerWMF removed projects: JavaScript, Utilities-UnicodeJS, VisualEditor, Wikimedia-production-error.Oct 14 2020, 3:08 PM
JTannerWMF added projects: VisualEditor, Wikimedia-production-error, JavaScript, Editing-team (Tracking).Oct 14 2020, 3:14 PM
matmarex added a project: Utilities-UnicodeJS.Oct 14 2020, 3:23 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Oct 14 2020, 3:40 PM
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex subscribed.

We've also already updated VisualEditor to use the latest version of the library in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/632981.

Should be fixed by those patches.

Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.Oct 15 2020, 2:32 AM
Jdlrobson added a comment.Oct 15 2020, 3:34 PM

Will this also take care of these errors?
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.15/clienterror/?id=AXUqu-Sj2lgCwKx7E6Zk (TypeError: prevCodepoint is null)
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.15/clienterror/?id=AXUsdLIU2lgCwKx7s-DM (TypeError: null is not an object (evaluating 'prevCodepoint.length'))

matmarex added a comment.Oct 15 2020, 4:32 PM

Yeah, they look like the same problem.

Jdforrester-WMF added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 15 2020, 4:36 PM
ppelberg closed this task as Resolved.Oct 16 2020, 12:41 AM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2020, 12:41 AM
Jdlrobson reopened this task as Open.Apr 3 2021, 12:28 AM

Still seeing instances of this error.
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.04.02?id=UpLDkngBg_6mGHGhBT4Q

ppelberg moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 3 2021, 12:53 AM
matmarex moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Apr 7 2021, 7:52 PM
matmarex added a subscriber: Esanders.

That is indeed the same error.

I'm not too familiar with this code, but looking at the previous patch (https://gerrit.wikimedia.org/r/c/unicodejs/+/632957), we added a check for nextCodepoint === null || prevCodepoint === null after the initial assignment to these variables. However, code below in that function can reassign them, and presumably one of those assignments results in null.

I'll leave this for @Esanders for now, hoping that the fix will be obvious to him.

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Apr 7 2021, 10:12 PM
ppelberg removed ppelberg as the assignee of this task.Apr 17 2021, 1:17 AM
ppelberg subscribed.
gerritbot added a comment.Apr 19 2021, 1:05 PM

Change 681071 had a related patch set uploaded (by Esanders; author: Esanders):

[unicodejs@master] Always check prevCodepoint is non-null

https://gerrit.wikimedia.org/r/681071

gerritbot added a project: Patch-For-Review.Apr 19 2021, 1:05 PM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Apr 21 2021, 5:25 PM
gerritbot added a comment.Apr 23 2021, 11:01 PM

Change 681071 merged by jenkins-bot:

[unicodejs@master] Always check prevCodepoint is non-null

https://gerrit.wikimedia.org/r/681071

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 11:10 PM
gerritbot added a comment.Apr 29 2021, 3:13 PM

Change 683666 had a related patch set uploaded (by Jforrester; author: Jforrester):

[VisualEditor/VisualEditor@master] Update UnicodeJS to v13.0.3

https://gerrit.wikimedia.org/r/683666

gerritbot added a project: Patch-For-Review.Apr 29 2021, 3:13 PM
gerritbot added a comment.Apr 30 2021, 1:40 AM

Change 683666 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Update UnicodeJS to v13.0.3

https://gerrit.wikimedia.org/r/683666

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 2:10 AM
gerritbot added a comment.Apr 30 2021, 5:30 PM

Change 683936 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (831a75cdb)

https://gerrit.wikimedia.org/r/683936

gerritbot added a project: Patch-For-Review.Apr 30 2021, 5:30 PM
gerritbot added a comment.Apr 30 2021, 8:35 PM

Change 683936 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (831a75cdb)

https://gerrit.wikimedia.org/r/683936

matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 30 2021, 8:58 PM

We should check the logs to confirm after this is deployed.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 9:00 PM
ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.May 5 2021, 5:09 PM
Krinkle closed this task as Resolved.Jun 11 2021, 7:48 PM
Krinkle assigned this task to matmarex.
Krinkle subscribed.

Checked for stack_trace:"Object.wordbreak.isBreak" on the medawiki-client-errors dashboard in Logstash over the past 90 days. The entries stopped on May 7th, which is the week after the above patch landed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits