Page MenuHomePhabricator

CheckUserLog invisible on meta, mediawiki.org, wikidata, but visible on kowiki
Closed, ResolvedPublicSecurity

Description

When @Sotiale tried to see the CheckUserLog, he found out the CU log was invisible. He discussed it with me, and I also saw F32385707. I also see the same on F32385709 (mw.org) and F32385711 (meta) (both on 1.36.0-wmf.13), but I see complete CU log on enwiki and kowiki (F32385714) (both on 1.36.0-wmf.11). This probably is Regression.

Event Timeline

revi created this task.Thu, Oct 15, 1:41 PM
Restricted Application added a project: User-revi. · View Herald TranscriptThu, Oct 15, 1:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
revi moved this task from Incoming to Radar on the User-revi board.Thu, Oct 15, 1:46 PM
revi added a subscriber: DeltaQuad.Thu, Oct 15, 1:49 PM
Urbanecm triaged this task as Unbreak Now! priority.Thu, Oct 15, 1:58 PM
Urbanecm added a subscriber: Urbanecm.

Definitely a train blocker. Marked as such, and prioritizing as UBN. Looking into it too.

Adding conductor and backup conductor to make sure they see (non-public) blocker.

revi updated the task description. (Show Details)Thu, Oct 15, 2:02 PM
Reedy updated the task description. (Show Details)Thu, Oct 15, 2:14 PM
Urbanecm added a comment.EditedThu, Oct 15, 2:17 PM

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/494638, and merely reverting that patch should fix this.

This patch should also fix this:

As soon as someone approves it, I'm happy to deploy it. If it's not approved soon, I'll simply revert the breaking change and deploy that.

sbassett added a subscriber: sbassett.EditedThu, Oct 15, 2:34 PM

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/494638, and merely reverting that patch should fix this.

Is the revert clean to do in gerrit and then pick it to wmf.11 and wmf.13 and deploy? And then the change set can be reworked and reviewed again?

Edit: I've created the gerrit revert here: https://gerrit.wikimedia.org/r/634246.

sbassett added a subscriber: Reedy.Thu, Oct 15, 2:34 PM

This patch is only in wmf.13, but yes, it's clean to revert. Doing.

Huji added a comment.Thu, Oct 15, 3:19 PM

Oh wow.

Okay, let me go back and figure out the right way to do this.

Urbanecm closed this task as Resolved.Thu, Oct 15, 3:55 PM
Urbanecm claimed this task.

The wrong patch was reverted, T217713 should be used to re-introduce the patch again.

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptThu, Oct 15, 3:55 PM
Urbanecm changed the visibility from "Custom Policy" to "Public (No Login Required)".Thu, Oct 15, 3:56 PM
Urbanecm changed the edit policy from "Custom Policy" to "All Users".