Page MenuHomePhabricator

SE intro overlay - labels length and text positioning
Closed, ResolvedPublicBUG REPORT

Description

Several issues are reported for the SE intro overlays:

(1) RTL wikis - a regression issue, e.g. hewiki . The issue seems to be specific to the second screen in the intro overlay.

Screen Shot 2020-10-21 at 12.00.09 PM.png (625×641 px, 64 KB)

(2) cswiki has the long label running into the description

Screen Shot 2020-10-19 at 12.15.07 PM.png (722×638 px, 91 KB)

(2) The text wrapping around the image looks not balanced (see the relevant comment https://phabricator.wikimedia.org/T258016#6556575).

Screen Shot 2020-10-19 at 12.17.57 PM.png (208×709 px, 37 KB)
Screen Shot 2020-10-19 at 12.18.05 PM.png (219×605 px, 40 KB)
Screen Shot 2020-10-19 at 12.21.14 PM.png (476×627 px, 70 KB)

Related Objects

Event Timeline

Assuming this is about the GrowthExperiments codebase. (Please set appropriate project tags when possible. Thanks!)

Change 635639 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

Change 635642 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Add padding between difficulty rows

https://gerrit.wikimedia.org/r/635642

Change 635639 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

This is issue (1).

Change 635642 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Add padding between difficulty rows

https://gerrit.wikimedia.org/r/635642

This is issue (2).

Issue (3) (or as currently written, the second issue (2)) should be addressed on T258016, by https://gerrit.wikimedia.org/r/634597

Change 635639 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

Change 635592 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635592

Change 635642 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Add padding between difficulty rows

https://gerrit.wikimedia.org/r/635642

Change 635594 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] StartEditingDialog: Add padding between difficulty rows

https://gerrit.wikimedia.org/r/635594

Change 635592 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635592

Change 635594 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] StartEditingDialog: Add padding between difficulty rows

https://gerrit.wikimedia.org/r/635594

Mentioned in SAL (#wikimedia-operations) [2020-10-21T23:16:01Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.14/extensions/GrowthExperiments/: T266033 (duration: 01m 05s)

Checked (1) in production - the issue is fixed.

Checked in wmf.14 - (1) and (2) are done. (3) will be addressed as a part of another task (see the description).