Page MenuHomePhabricator

[testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpression
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. On testwiki edit one of SE article.
  2. The post-edit dialog will be displayed with a delay and the Console displays the following error:
Cannot read property 'length' of null TypeError: Cannot read property 'length' of null
    at PostEditPanel.logImpression
  1. The "'x" and “Close and edit this article again” buttons in the post-edit dialog do not work.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2020, 7:33 PM

We would like to look into this today, if possible.

Etonkovidova updated the task description. (Show Details)Oct 26 2020, 7:38 PM

@Catrope will be looking into this.

Tgr added a comment.EditedOct 26 2020, 7:50 PM

Happening in production: https://logstash.wikimedia.org/goto/2fdf7dee82f31896300729f4258b20ca
(Seemingly very infrequently, but that dashboard doesn't show the testwiki error @Etonkovidova reported, so it might be underreporting.)

Change 636498 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636498

Change 636498 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636498

Change 636383 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636383

Change 636383 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636383

Mentioned in SAL (#wikimedia-operations) [2020-10-26T23:12:06Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.14/extensions/GrowthExperiments/: Fix JS error when no topics set (T266501) (duration: 01m 00s)

Etonkovidova closed this task as Resolved.Oct 26 2020, 11:23 PM

Checked in betalabs and testwiki - the issues have been fixed.