[testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpression
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 26 2020, 7:33 PM

Description

Steps to Reproduce:

On testwiki edit one of SE article.
The post-edit dialog will be displayed with a delay and the Console displays the following error:

Cannot read property 'length' of null TypeError: Cannot read property 'length' of null
    at PostEditPanel.logImpression

The "'x" and “Close and edit this article again” buttons in the post-edit dialog do not work.

Details

	Subject	Repo	Branch	Lines +/-
	PostEditPanel: Account for topics being null	mediawiki/extensions/GrowthExperiments	wmf/1.36.0-wmf.14	+1 -1
	PostEditPanel: Account for topics being null	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T266162: TypeError: null is not an object (evaluating 'extraData.userTopics.length')

Event Timeline

Etonkovidova created this task.Oct 26 2020, 7:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2020, 7:33 PM

We would like to look into this today, if possible.

Etonkovidova updated the task description. (Show Details)Oct 26 2020, 7:38 PM

@Catrope will be looking into this.

Happening in production: https://logstash.wikimedia.org/goto/2fdf7dee82f31896300729f4258b20ca
(Seemingly very infrequently, but that dashboard doesn't show the testwiki error @Etonkovidova reported, so it might be underreporting.)

Change 636498 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636498

gerritbot added a project: Patch-For-Review.Oct 26 2020, 9:31 PM

• Catrope moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 26 2020, 9:31 PM

Change 636498 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636498

• Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 26 2020, 10:04 PM

Change 636383 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636383

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 11:00 PM

Change 636383 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.14] PostEditPanel: Account for topics being null

https://gerrit.wikimedia.org/r/636383

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2020, 11:10 PM

Mentioned in SAL (#wikimedia-operations) [2020-10-26T23:12:06Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.14/extensions/GrowthExperiments/: Fix JS error when no topics set (T266501) (duration: 01m 00s)

Checked in betalabs and testwiki - the issues have been fixed.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.14; 2020-10-20); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 27 2020, 12:00 AM

Umherirrender merged a task: T266162: TypeError: null is not an object (evaluating 'extraData.userTopics.length').Mar 3 2021, 10:50 PM

Umherirrender added subscribers: Jdlrobson, Masumrezarock100.

[testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpressionClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

[testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpression
Closed, ResolvedPublicBUG REPORT
Actions