Page MenuHomePhabricator
Create Task
Maniphest T266677

Use of FormatMetadata::formatNum with non-numeric value was deprecated in MediaWiki 1.36. [Called from FormatMetadata::makeFormattedData]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

message
Use of FormatMetadata::formatNum with non-numeric value was deprecated in MediaWiki 1.36. [Called from FormatMetadata::makeFormattedData]
Impact
Notes

This is from beta cluster. This task is forked from T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].

Details

Request ID
X5i5j6wQBHcAACBO5r4AAAAJ
Stack Trace
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-master/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /srv/mediawiki/php-master/includes/debug/MWDebug.php(305): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-master/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-master/includes/GlobalFunctions.php(1029): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-master/includes/media/FormatMetadata.php(1285): wfDeprecated(string, string)
#6 /srv/mediawiki/php-master/includes/media/FormatMetadata.php(997): FormatMetadata->formatNum(string)
#7 /srv/mediawiki/php-master/includes/media/FormatMetadata.php(92): FormatMetadata->makeFormattedData(array)
#8 /srv/mediawiki/php-master/includes/media/MediaHandler.php(549): FormatMetadata::getFormattedData(array, RequestContext)
#9 /srv/mediawiki/php-master/extensions/PdfHandler/includes/PdfHandler.php(367): MediaHandler->formatMetadataHelper(array, RequestContext)
#10 /srv/mediawiki/php-master/includes/filerepo/file/File.php(1919): PdfHandler->formatMetadata(ForeignAPIFile, RequestContext)
#11 /srv/mediawiki/php-master/includes/page/ImagePage.php(131): File->formatMetadata(RequestContext)
#12 /srv/mediawiki/php-master/includes/actions/ViewAction.php(74): ImagePage->view()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(530): ViewAction->show()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(316): MediaWiki->performAction(ImagePage, Title)
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(943): MediaWiki->performRequest()
#16 /srv/mediawiki/php-master/includes/MediaWiki.php(546): MediaWiki->main()
#17 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
SubjectRepoBranchLines +/-
Don't try to format pdf-specific metadata as numbersmediawiki/extensions/PdfHandlermaster+23 -5
Provide mechanism for MediaHandlers to override metadata formattingmediawiki/coremaster+130 -0
Extend FormatMetadata to handle non-numeric EXIF tags from PDF XMP datamediawiki/coremaster+15 -2
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Oct 28 2020, 2:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2020, 2:57 PM
cscott mentioned this in T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].Oct 28 2020, 3:00 PM
cscott added a subscriber: Reedy.

Investigation of this class of warning by @Reedy in T263592#6575833.

Reedy added projects: MediaWiki-extensions-PdfHandler, MediaWiki-File-management.Oct 28 2020, 3:12 PM
Reedy edited Stack Trace. (Show Details)
Restricted Application added a project: Commons. · View Herald TranscriptOct 28 2020, 3:12 PM
Jdforrester-WMF added a parent task: T263182: 1.36.0-wmf.16 deployment blockers.Oct 28 2020, 3:47 PM
Jdforrester-WMF subscribed.

(Provisionally a train blocker.)

Krinkle triaged this task as High priority.Oct 28 2020, 3:50 PM
Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.
gerritbot added a comment.Oct 28 2020, 6:31 PM

Change 637001 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Provide mechanism for MediaHandlers to override metadata formatting

https://gerrit.wikimedia.org/r/637001

gerritbot added a project: Patch-For-Review.Oct 28 2020, 6:31 PM

Change 637002 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PdfHandler@master] Don't try to format pdf-version or pdf-encrypted as numbers

https://gerrit.wikimedia.org/r/637002

gerritbot added a comment.Oct 30 2020, 1:48 PM

Change 637697 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Extend FormatMetadata to handle non-numeric EXIF tags from PDF XMP data

https://gerrit.wikimedia.org/r/637697

gerritbot added a comment.Oct 30 2020, 5:12 PM

Change 637001 merged by jenkins-bot:
[mediawiki/core@master] Provide mechanism for MediaHandlers to override metadata formatting

https://gerrit.wikimedia.org/r/637001

gerritbot added a comment.Oct 30 2020, 5:43 PM

Change 637002 merged by jenkins-bot:
[mediawiki/extensions/PdfHandler@master] Don't try to format pdf-specific metadata as numbers

https://gerrit.wikimedia.org/r/637002

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 6:00 PM
cscott mentioned this in rEPHDf0799bec7bfa: Don't try to format pdf-specific metadata as numbers.Oct 30 2020, 6:07 PM
gerritbot added a comment.Oct 30 2020, 10:23 PM

Change 637697 merged by jenkins-bot:
[mediawiki/core@master] Extend FormatMetadata to handle non-numeric EXIF tags from PDF XMP data

https://gerrit.wikimedia.org/r/637697

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2020, 11:10 PM
thcipriani raised the priority of this task from High to Unbreak Now!.Nov 2 2020, 6:48 PM
brennen subscribed.Nov 4 2020, 4:01 PM
Agusbou2015 subscribed.Nov 4 2020, 6:28 PM
brennen added a comment.Nov 4 2020, 7:19 PM

Is there anything outstanding here? This looks resolved?

brennen lowered the priority of this task from Unbreak Now! to High.Nov 4 2020, 7:21 PM

Stuff seems to be merged to master, removing from train blockers. Re-add if that's not appropriate.

brennen removed a parent task: T263182: 1.36.0-wmf.16 deployment blockers.Nov 4 2020, 7:21 PM
cscott mentioned this in T267091: Undefined index: . at Language.php:3348.Nov 5 2020, 6:13 PM
cscott mentioned this in T267362: Use of Language::formatNum with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].Nov 5 2020, 6:21 PM
cscott mentioned this in T267370: Use of FormatMetadata::formatNum with non-numeric value was deprecated in MediaWiki 1.36. [Called from FormatMetadata::makeFormattedData].Nov 5 2020, 9:11 PM
Aklapper assigned this task to cscott.Nov 25 2020, 10:59 AM
In T266677#6604085, @brennen wrote:

Is there anything outstanding here? This looks resolved?

@cscott: Can you please reply? Asking as you are the author of all patches.

Reedy mentioned this in T269374: PHP Notice: A non well formed numeric value encountered (FormatMetadata.php).Dec 14 2020, 5:32 PM
Umherirrender closed this task as Resolved.Mar 2 2021, 9:47 PM
Umherirrender subscribed.

Since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/640249 all non-numeric strings are treated literal and there should not be any error for this task

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits