Page MenuHomePhabricator
Create Task
Maniphest T267832

Refactor PoolWorkArticleView to support caching of old revisions
Closed, ResolvedPublic
Actions

Description

PoolWorkArticleView currently only supports caching ParserOutput for a page's current revision to ParserOutput. To resolve T244058, it needs to be refactored to also support caching of output for an old revision.

There are three implementation options to explore:

  1. use subclasses to implement different behavior for current and old revisions
  2. inject callbacks to implement different behavior for current and old revisions
  3. implement different behavior for current and old revisions based on flags

Details

SubjectRepoBranchLines +/-
PoolWorkArticleView: inject loggermediawiki/coremaster+108 -35
ParserOutputAccess: add metricsmediawiki/coremaster+20 -0
ParserOutputAccess: cache ouput for old revisionsmediawiki/coremaster+512 -51
Extract PoolWorlArticleViewCurrentmediawiki/coremaster+321 -130
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel claimed this task.Nov 13 2020, 11:49 AM
daniel created this task.
daniel moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.
gerritbot added a comment.Nov 13 2020, 12:08 PM

Change 640930 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: cache canonical ouput for old revisions

https://gerrit.wikimedia.org/r/640930

gerritbot added a project: Patch-For-Review.Nov 13 2020, 12:08 PM
gerritbot added a comment.Nov 16 2020, 8:14 PM

Change 641240 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: cache canonical ouput for old revisions

https://gerrit.wikimedia.org/r/641240

gerritbot added a comment.Nov 17 2020, 8:25 PM

Change 640930 merged by jenkins-bot:
[mediawiki/core@master] Extract PoolWorlArticleViewCurrent

https://gerrit.wikimedia.org/r/640930

gerritbot added a comment.Nov 17 2020, 8:40 PM

Change 641522 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ParserOutputAccess: add metrics

https://gerrit.wikimedia.org/r/641522

gerritbot added a comment.Nov 17 2020, 8:41 PM

Change 641523 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] PoolWorkArticleView: inject logger

https://gerrit.wikimedia.org/r/641523

daniel mentioned this in T268075: Enable caching for old revisions in production.Nov 17 2020, 8:48 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 17 2020, 9:00 PM
daniel triaged this task as Medium priority.Nov 18 2020, 5:06 PM
daniel moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.
gerritbot added a comment.Nov 18 2020, 7:52 PM

Change 641240 merged by jenkins-bot:
[mediawiki/core@master] ParserOutputAccess: cache ouput for old revisions

https://gerrit.wikimedia.org/r/641240

gerritbot added a comment.Nov 18 2020, 7:58 PM

Change 641522 merged by jenkins-bot:
[mediawiki/core@master] ParserOutputAccess: add metrics

https://gerrit.wikimedia.org/r/641522

gerritbot added a comment.Nov 18 2020, 8:47 PM

Change 641523 merged by jenkins-bot:
[mediawiki/core@master] PoolWorkArticleView: inject logger

https://gerrit.wikimedia.org/r/641523

• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Nov 18 2020, 10:26 PM
daniel moved this task from Ready to Deploy to User Story Review on the Platform Team Workboards (Green) board.Dec 2 2020, 5:11 PM
• Pchelolo closed this task as Resolved.Dec 10 2020, 3:17 PM
• Pchelolo moved this task from User Story Review to Done on the Platform Team Workboards (Green) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits