Page MenuHomePhabricator
Create Task
Maniphest T268075

Enable caching for old revisions in production
Closed, ResolvedPublic
Actions

Description

In T267832 we introduced $wgOldRevisionParserCacheExpireTime with a default of one hour. In order to retain control over when the new caching behavior will take effect, we want to disable it in production first, then deploy the code, then enable it on group 0, then enable it globally.

Steps:

  • Set $wgOldRevisionParserCacheExpireTime to 0 in production to disable caching of old revisions (the old behavior)
  • Merge and deploy code for that implements caching of old revisions (T267832)
  • Set $wgOldRevisionParserCacheExpireTime to 60 * 60 on group 0. Watch for trouble.
  • Set $wgOldRevisionParserCacheExpireTime to 60 * 60 everywhere.

Details

SubjectRepoBranchLines +/-
Enable old revision parser cache on all wikisoperations/mediawiki-configmaster+3 -10
group1: Enable OldRevisionParserCacheoperations/mediawiki-configmaster+1 -0
Article:view - always try using ParserCache for old revisions.mediawiki/coremaster+24 -10
Enable OldRevisionParserCache on labs and group0operations/mediawiki-configmaster+9 -3
Set $wgOldRevisionParserCacheExpireTime to 0 in productionoperations/mediawiki-configmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Nov 17 2020, 8:48 PM
gerritbot added a comment.Nov 17 2020, 8:51 PM

Change 641527 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[operations/mediawiki-config@master] Set $wgOldRevisionParserCacheExpireTime to 0 in production

https://gerrit.wikimedia.org/r/641527

gerritbot added a project: Patch-For-Review.Nov 17 2020, 8:51 PM
daniel moved this task from Backlog to Next Sprint on the Platform Team Workboards (Green) board.Nov 18 2020, 5:34 PM
gerritbot added a comment.Nov 18 2020, 7:10 PM

Change 641527 merged by jenkins-bot:
[operations/mediawiki-config@master] Set $wgOldRevisionParserCacheExpireTime to 0 in production

https://gerrit.wikimedia.org/r/641527

daniel moved this task from Next Sprint to Ready to Deploy on the Platform Team Workboards (Green) board.Dec 2 2020, 5:13 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 6:10 PM
• Pchelolo claimed this task.Dec 7 2020, 2:11 PM
• Pchelolo moved this task from Ready to Deploy to Doing on the Platform Team Workboards (Green) board.
gerritbot added a comment.Dec 7 2020, 2:16 PM

Change 646679 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/mediawiki-config@master] Enable OldRevisionParserCache on labs and group0

https://gerrit.wikimedia.org/r/646679

gerritbot added a project: Patch-For-Review.Dec 7 2020, 2:16 PM
• Pchelolo updated the task description. (Show Details)Dec 7 2020, 2:17 PM
gerritbot added a comment.Dec 7 2020, 7:12 PM

Change 646679 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable OldRevisionParserCache on labs and group0

https://gerrit.wikimedia.org/r/646679

gerritbot added a comment.Dec 7 2020, 7:50 PM

Change 646818 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Article:view - always try using ParserCache.

https://gerrit.wikimedia.org/r/646818

gerritbot added a comment.Dec 7 2020, 10:49 PM

Change 646818 merged by jenkins-bot:
[mediawiki/core@master] Article:view - always try using ParserCache for old revisions.

https://gerrit.wikimedia.org/r/646818

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 7 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2020, 11:10 PM
gerritbot added a comment.Dec 14 2020, 3:12 PM

Change 649359 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/mediawiki-config@master] group1: Enable OldRevisionParserCache

https://gerrit.wikimedia.org/r/649359

gerritbot added a project: Patch-For-Review.Dec 14 2020, 3:12 PM
• Pchelolo updated the task description. (Show Details)Dec 14 2020, 3:13 PM
gerritbot added a comment.Dec 14 2020, 7:29 PM

Change 649359 merged by jenkins-bot:
[operations/mediawiki-config@master] group1: Enable OldRevisionParserCache

https://gerrit.wikimedia.org/r/649359

gerritbot added a comment.Dec 14 2020, 7:34 PM

Change 649432 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/mediawiki-config@master] Enable old revision parser cache on all wikis

https://gerrit.wikimedia.org/r/649432

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Dec 15 2020, 1:32 AM
gerritbot added a comment.Dec 15 2020, 3:35 PM

Change 649432 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable old revision parser cache on all wikis

https://gerrit.wikimedia.org/r/649432

Stashbot added a comment.Dec 15 2020, 3:41 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-15T15:41:57Z] <ppchelko@deploy1001> Synchronized wmf-config/CommonSettings.php: gerrit:649432 T268075 Enable old revision parser cache on all wikis CS.php (duration: 00m 56s)

Stashbot added a comment.Dec 15 2020, 3:43 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-15T15:43:08Z] <ppchelko@deploy1001> Synchronized wmf-config/InitialiseSettings.php: gerrit:649432 T268075 Enable old revision parser cache on all wikis IS.php (duration: 00m 54s)

• Pchelolo closed this task as Resolved.Dec 15 2020, 3:45 PM
• Pchelolo updated the task description. (Show Details)
• Pchelolo moved this task from Doing to Done on the Platform Team Workboards (Green) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits