SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H]
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Nov 30 2020, 10:39 AM

Description

What is the problem?

When using the IPInfo popup on the history of an article can cause the dotted lines which mark selected revisions to jump (see screenshot).

I have only reproduced this on Firefox (not Chrome, Edge or Safari).

Steps to reproduce problem

Login and go to https://thegoodplace.wmcloud.org/index.php?title=Test2&action=history
Click the first IPInfo "i" popup

Environment

Browser: Firefox 78 and 83.
Wiki(s): MediaWiki 1.36.0-alpha (ed5d593), IP Info 0.0.0 (9fc96a6).

Screenshots (if applicable):

dotted_lines_jump.png (352×735 px, 66 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Dotted lines on revision history jumps when opening popup	mediawiki/extensions/IPInfo	master	+6 -2
	Fix Firefox outline styling in history pages	mediawiki/extensions/IPInfo	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T306041: Use 'info' icon for the popup button
T301938: IPInfo: Use infoFilled for the popup button
T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]
Mentioned Here: rEIPIcb5558d59d68: Localisation updates from https://translatewiki.net.
T301938: IPInfo: Use infoFilled for the popup button
rEIPI500d7c134063: Localisation updates from https://translatewiki.net.
T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]
rEIPI109c072c27df: Localisation updates from https://translatewiki.net.
rEIPI9fc96a6bd96d: Merge "Don't append empty paragraph in widget if location is unavailable"
rECHU1309125ecb1c: Localisation updates from https://translatewiki.net.
rMWed5d5932524f: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Nov 30 2020, 10:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2020, 10:39 AM

dom_walden updated the task description. (Show Details)Nov 30 2020, 12:53 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Sep 24 2021, 6:10 AM

@dom_walden We discussed this and we're also unaware if it's still an issue. Would you have time to confirm this bug for us as well please?

In T268981#7406326, @ARamirez_WMF wrote:

@dom_walden We discussed this and we're also unaware if it's still an issue. Would you have time to confirm this bug for us as well please?

Yes. I have just checked. It looks slightly different from the last time I saw this:

20211011_07 30 25_firefox_93.png (1×1 px, 93 KB)

Notice that the whole row of dotted lines is higher than it should be.

Reproduced on https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (109c072) 07:21, 8 October 2021 with Firefox 93, going to page https://en.wikipedia.beta.wmflabs.org/wiki/0.04961315198485505?action=history.

Niharika triaged this task as Medium priority.Oct 11 2021, 7:32 PM

ARamirez_WMF renamed this task from IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) to SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H].Nov 3 2021, 4:45 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

phuedx edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Dec 8 2021, 2:33 PM

• wikitrent claimed this task.Dec 15 2021, 1:21 PM

• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

I'm testing this on Firefox 95 and I can't see a difference between this and what's happening on Chrome. @Prtksxna Can you spot what I'm supposed to fix?

Testing on FF92 and then FF95 on MacOS I can see the dashed line on top move a few pixels up is open:

Normal	With popup

There seems to be an issue with the overflow CSS property. I'm able to remove that by setting it to hidden, but that also removes the bullet points from the left, which we want to keep. This is only happening in FF and changing overflow in Chrome doesn't seem to affect anything at all.

I also changed the font sizes and other height/width values. Those did not seem to move the outline around at all. Moving this to stuck as I'm not sure where to proceed. I've reached out to #front-end to see if anyone has experience/knowledge of this and will pick up another ticket in the meantime.

• wikitrent moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 2:25 PM

Thanks @wikitrent. Looks like this can be fixed by setting overflow: hidden on the button itself (rather than on the list item):

We can do that in ipinfo.less - could you tag a patch against this task?

Change 752159 had a related patch set uploaded (by Wikitrent; author: Wikitrent):

[mediawiki/extensions/IPInfo@master] WIP: Fix FF dotted lines

https://gerrit.wikimedia.org/r/752159

gerritbot added a project: Patch-For-Review.Jan 7 2022, 4:12 PM

• wikitrent moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 4:36 PM

Change 752159 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fix Firefox outline styling in history pages

https://gerrit.wikimedia.org/r/752159

• wikitrent moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 4:59 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 7 2022, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 5:10 PM

I notice on https://ar.wikipedia.beta.wmflabs.org, I think this change chops off the bottom of the icon (ar and arz use a different icon.)

With overflow: hidden:

Without:

@Prtksxna @Niharika Do we mind? Perhaps we should change it so all languages use the same icon (if this is even possible).

Tchanders moved this task from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Jan 10 2022, 5:39 PM

• Prtksxna mentioned this in T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S].Jan 11 2022, 8:06 AM

I feel like we've seen this icon changing bug before but I can't find it anywhere.
Yep we should have the same icon (and no clipping) everywhere, I've raised T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]. Thanks @dom_walden!

Thanks @dom_walden and @Prtksxna

Niharika closed this task as Resolved.Feb 17 2022, 1:48 AM

• TThoabala mentioned this in T301938: IPInfo: Use infoFilled for the popup button.Mar 15 2022, 5:02 PM

I can reproduce this again after T301938. Therefore, I will reopen this bug.

For example, go to https://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama_T173949?action=history and click the first IPInfo popup.

Test environment: IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.
Test browser: Firefox 91.

In T268981#7787818, @dom_walden wrote:

I can reproduce this again after T301938. Therefore, I will reopen this bug.

For example, go to https://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama_T173949?action=history and click the first IPInfo popup.

Test environment: IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.
Test browser: Firefox 91.

Thanks I have uploaded a patch for this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/771840
This patch brings back the code that was used to fix this patch initially, it then fixes the problem we were hoping to fix by removing the mentioned code.

In T268981#7788009, @TThoabala wrote:

Thanks I have uploaded a patch for this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/771840
This patch brings back the code that was used to fix this patch initially, it then fixes the problem we were hoping to fix by removing the mentioned code.

Thanks. In that case, I am going to move this into the code review column of this sprint.

dom_walden reassigned this task from • wikitrent to • TThoabala.Mar 18 2022, 9:53 AM

dom_walden moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.

dom_walden added a subscriber: • wikitrent.

Change 771840 had a related patch set uploaded (by Tchanders; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Dotted lines on revision history jumps when opening popup

https://gerrit.wikimedia.org/r/771840

gerritbot added a project: Patch-For-Review.Mar 18 2022, 4:38 PM

Change 771840 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Dotted lines on revision history jumps when opening popup

https://gerrit.wikimedia.org/r/771840

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 18 2022, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2022, 7:10 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.Mar 18 2022, 8:04 PM

I cannot reproduce this bug anymore.

I repeated the testing I did in T301938#7788171, but only for Firefox 91 and Chromium 87 (and I didn't test Arabic).

Test Environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (cb5558d) 07:14, 21 March 2022.

Niharika closed this task as Resolved.Apr 8 2022, 10:41 PM

Tchanders mentioned this in T306041: Use 'info' icon for the popup button.Apr 13 2022, 3:26 PM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM

	F34886646: Screenshot 2021-12-16 at 10.16.18 PM.png
	Dec 16 2021, 4:48 PM

	F34886644: Screenshot 2021-12-16 at 10.16.13 PM.png
	Dec 16 2021, 4:48 PM

	F34683649: 20211011_07 30 25_firefox_93.png
	Oct 11 2021, 7:34 AM

	F34913161: ar_icon_hidden.png
	Jan 10 2022, 2:44 PM

	F34910553: screenshot.png
	Jan 7 2022, 4:02 PM

SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H]Closed, ResolvedPublicBUG REPORTActions