Page MenuHomePhabricator

"success" greens in Codex are too blue
Open, Needs TriagePublic

Assigned To
None
Authored By
Esanders
Dec 1 2020, 2:29 PM
Referenced Files
F33930045: image.png
Dec 1 2020, 2:37 PM
F32415050: image.png
Dec 1 2020, 2:29 PM
F33929998: image.png
Dec 1 2020, 2:29 PM
F33930000: image.png
Dec 1 2020, 2:29 PM
F33930002: image.png
Dec 1 2020, 2:29 PM
F32414687: image.png
Dec 1 2020, 2:29 PM
F33930007: image.png
Dec 1 2020, 2:29 PM

Description

A green with more yellow looks more natural, and is far more common in other UI libraries

currentproposed (approx)
image.png (57×271 px, 1 KB)
image.png (57×271 px, 1 KB)
Hue 166°Hue 140°

I think a hue between 110° and 150° would be better (current hue is ~166°)

Note also that our blues and yellows have hues of ~210° and ~40° respectively so this would put the green closer to the midpoint between those (125°).

Some examples from other UI libraries:

Fortunately green is one of the less used colours from our styleguide, so there shouldn't be too many places to update.

Event Timeline

@Esanders Are you specifically talking about Green90 or are you proposing shifting Green50 and Green30 accordingly? It's not completely clear from the current task description.

All the greens have a similar hue, so they should all be shifted.

Esanders renamed this task from "success" green in style guide is too blue to "success" greens in style guide are too blue.Dec 1 2020, 3:27 PM

From current description it's not clear, what the problem is. It's a color choice. Could you provide a clearer problem statement of why this choice is an issue?

Volker_E triaged this task as Lowest priority.Dec 14 2020, 2:23 PM

Could you provide a clearer problem statement of why this choice is an issue?

It looks unnatural and jarring compared to what users expect of a success message.

This green would also be more distinct from our blues.

Objections to the shade of green have been raised in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/394076/8 which is think is one of the first patches to put this message box into wide use.

@RHo are design still working on this? The linked task has no activity on it, and this has been stalled for a year.

We might have time for this after our Design System color token definition T296995: Define the system's color palette.

Volker_E renamed this task from "success" greens in style guide are too blue to "success" greens in Codex are too blue.Feb 14 2024, 3:08 PM
Volker_E edited projects, added Codex; removed Wikimedia Design Style Guide.
CCiufo-WMF raised the priority of this task from Lowest to Needs Triage.Feb 20 2024, 3:24 PM
CCiufo-WMF moved this task from Inbox to Backlog on the Design-System-Team board.

It's been a couple of years and I still haven't gotten used to it. The green is ugly. :(