Page MenuHomePhabricator

Make postedit messages ("Your edit was saved.") and mw.notification messages ("The page has been added to your watchlist.") look the same
Open, LowPublic

Description

Style of "Your edit was saved." message is not like 'adding or remove watchlist' and 'SUL'. I suggest 'check' mark isn't removed but background style is changed.

Style comparison from @Ara's comment below

Edit: this are now more similar, but have different placements and icons
mw.nofity: top right, no icons


postEdit: top center, tick and close icons:

Proposal


Use success message box styling for postedit success notification

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:17 AM
bzimport set Reference to bz56313.
bzimport added a subscriber: Unknown Object (MLST).

I don't know how to see the style of 'adding or remove watchlist' and 'SUL'. Could you attach screenshots here, maybe? Also, which theme do you use?

Style Comparison

Attached:

So you basically want it to use mw.notify() ? Or would changing postedit CSS to look like that be what you want?

Myeongjin: Can you answer comment 3, please?

Myeongjin: Can you answer comment 3, please?

I want changing postedit CSS to look like "mw.notify()".

Ara set Security to None.
Ara added a subscriber: Ara.
matmarex renamed this task from Change style of "Your edit was saved." message to Make postedit messages ("Your edit was saved.") and mw.notification messages ("The page has been added to your watchlist.") look the same.Oct 27 2015, 10:33 PM
matmarex updated the task description. (Show Details)
matmarex removed a subscriber: wikibugs-l-list.

Change 347367 had a related patch set uploaded (by Esanders):
[mediawiki/core@master] Cleanup postEdit and match styles to mw.notification

https://gerrit.wikimedia.org/r/347367

Change 347361 had a related patch set uploaded (by Esanders):
[mediawiki/skins/Vector@master] Match mediawiki.notification styles to OOUI dialogs

https://gerrit.wikimedia.org/r/347361

After the above two patches (in Vector):


The postEdit icons need fixing, and all that code should ultimately just be a special case of mw.notification.

Change 347397 had a related patch set uploaded (by Esanders):
[mediawiki/skins/MonoBook@master] Match mediawiki.notification styles to OOUI dialogs

https://gerrit.wikimedia.org/r/347397

Change 347361 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Match mediawiki.notification styles to OOUI dialogs

https://gerrit.wikimedia.org/r/347361

Change 347397 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Match mediawiki.notification styles to OOUI dialogs

https://gerrit.wikimedia.org/r/347397

Change 347367 merged by jenkins-bot:
[mediawiki/core@master] Cleanup postEdit and match styles to mw.notification

https://gerrit.wikimedia.org/r/347367

matmarex assigned this task to Esanders.
matmarex removed a project: Patch-For-Review.

Change 394076 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] mw.postEdit: Use mw.notify to display message

https://gerrit.wikimedia.org/r/394076

Re-opening with change 394076 by @Esanders.
Screenshots appreciated.

Note that on mobile these messages are already unified, with both the post-edit notification, and other notifications showing at the bottom of the page in a black box.

In a static image the 'after' is slightly less prominent, as it lacks the green tick, and a contrasting background, but as these notifications transition in and out of view, they are both hard to miss.

Change 636419 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Use OOUI green tick for postEdit notification

https://gerrit.wikimedia.org/r/636419

Above patch brings icon in line with OOUI:

This should also probably use the 'success' type of mw.notify:

Change 636419 merged by jenkins-bot:
[mediawiki/core@master] Use OOUI green tick for postEdit notification

https://gerrit.wikimedia.org/r/636419

Change 394076 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] mw.postEdit: Use mw.notify to display message

https://gerrit.wikimedia.org/r/394076

I filed T269138 to address the shade of green we currently use of success box.