Page MenuHomePhabricator

Restore ability to hide postedit confirmation
Closed, ResolvedPublic

Description

Please add a user preference to enable/disable the postedit confirmation ("Your edit was saved") dialog.

Right now, a savvy user can disable it with CSS in Special:MyPage/vector.css, but a preferences checkbox would be easier for a wide audience.

Why disable it? Because it blocks other UI elements for the three seconds that it appears. I'm constantly having to pause and wait, or click to dismiss, so I can get at a link underneath it. It's an extra click or delay that adds no value for advanced users. (Though I'm sure it helps beginners.)

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:21 AM
bzimport set Reference to bz64435.
bzimport added a subscriber: Unknown Object (MLST).

It was the first thing that annoyed me when I updated MW.

Presumably the same preference should also disable other mw.notify usage? Used when:

  • Adding pages to your watchlist (e.g. using the watchstar).
  • Patrolling edits.
  • Saving preferences.
  • etc.

Or is mw.notify not annoying due to its position on the side (and never overlapping the header navigation). In that case T103682 may be relevant.

Overall I would be inclined to say this feature should not have a user preference since it would make some interactions quite difficult and odd (e.g. clicking a button and nothing happens).

The feeling to want to disable it is very understandable however. Let's work on improving the interface to make sure it isn't obstructing navigation elements. Some of that is currently on-track via T103682.

Presumably the same preference should also disable other mw.notify usage?

What if it were added as a gadget, that only contained the CSS to hide the notice, similar to https://en.wikipedia.org/wiki/MediaWiki:Gadget-DisambiguationLinks.css?

Hi, I had CSS to disable the confirmation, but it doesn't work with T58313 anymore. Perhaps a preference could be reconsidered?

@Mathis_Benguigui A new preference sounds simple, but is a major decision for a number of reasons...
For context, I love having powerful preferences in all software I use, and I used to regularly request having more of them in MediaWiki. However, after I learned more about the complexity and ramifications of each new preference, I wrote this essay listing out the drawbacks (and the benefits!): https://www.mediawiki.org/wiki/Just_make_it_a_user_preference

As for CSS, It looks like someone has now commented in the patch, suggesting the old CSS class-name be re-added, so that users who previously hid it don't have to change anything. Therefor, I'd suggest just ignoring it for a week, to see if that proposal goes through.
I.e. Because this popup message is now using the same code as the other popup messages (which is great for code-efficiency and UX-consistency), but without an extra CSS class, we can only hide all of them (see list above). However, if you want to do that, the CSS is:
.mw-notification-content .oo-ui-icon-check.oo-ui-image-success { display: none }

Alternatively, you can use this JavaScript in your common.js or global.js to prevent it: mw.config.set('wgPostEditConfirmationDisabled', true);

Thank you for both the explanation and the JavaScript code, it works!

@Quiddity There appear to be at least about 160 users (after eliminating duplicates) who have hidden .postedit in their CSS:

That might be a tiny number in the grand scheme of things but adding a tag couldn't hurt.

Krinkle renamed this task from Create a user preference to disable the postedit confirmation to Restore ability to hide postedit confirmation.Mar 2 2022, 9:30 PM

The ability to hide the postedit notification through a personal CSS customisation will most likely be restored as part of T302848, which allows PostEdit to add a stable class name to it.

Change 767587 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] mediawiki.action.view.postEdit: Restore class name for personal styling

https://gerrit.wikimedia.org/r/767587

Change 767591 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/core@master] mediawiki.action.view.postEdit: add 'postedit' CSS class to notification

https://gerrit.wikimedia.org/r/767591

Change 767591 abandoned by MusikAnimal:

[mediawiki/core@master] mediawiki.action.view.postEdit: add 'postedit' CSS class to notification

Reason:

I have been beaten by Krinkle ;) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/767587/

https://gerrit.wikimedia.org/r/767591

The ability to hide the postedit notification through a personal CSS customisation will most likely be restored as part of T302848, which allows PostEdit to add a stable class name to it.

The Core patch has already been merged https://gerrit.wikimedia.org/r/c/mediawiki/core/+/767274/. I wanted to say that I nearly created a dedicated task for this, but I figured after all these years if no one else thought to add this functionality it must have been a narrow use-case! I had created a patch to add the class to postEdit but I see now you've beaten me to it :)

Change 767587 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.action.view.postEdit: Restore 'postedit' CSS class

https://gerrit.wikimedia.org/r/767587

Nardog assigned this task to MusikAnimal.