| Esanders | |
| Dec 15 2020, 8:55 PM |
| F48638505: screenshot 47.mov.gif | |
| Apr 25 2024, 4:04 PM |
| F48638504: screenshot 46.mov.gif | |
| Apr 25 2024, 4:04 PM |
| F48638011: screenshot 44.mov.gif | |
| Apr 25 2024, 3:59 PM |
| F48638006: screenshot 43.mov.gif | |
| Apr 25 2024, 3:59 PM |
| F34648835: Screen Recording 2021-09-20 at 9.07.18 AM.mov.gif | |
| Sep 20 2021, 4:14 PM |
| F34648839: Screen Recording 2021-09-20 at 9.08.27 AM.mov.gif | |
| Sep 20 2021, 4:14 PM |
| F34648841: Screen Recording 2021-09-20 at 9.11.29 AM.mov.gif | |
| Sep 20 2021, 4:14 PM |
| F34641884: Screen Recording 2021-09-13 at 6.59.25 AM.mov.gif | |
| Sep 13 2021, 2:02 PM |
If I tab onto a link, the hover card always appears above the link, even if there isn't room to show it.
Hovering with the mouse results in the card being placed below the link if necessary.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T270215#9745324 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T270215#9745363 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Account for scroll offset when using non-mouse positioning | mediawiki/extensions/Popups | master | +3 -3 |
I tested this on Chrome, and now I see the page preview always appearing under the link so I think this is fixed?
Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
AC1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.
Status: ❌ FAIL
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
❌ A{F34648841}C1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.
While testing Prod I noticed that the behavior changed if I scrolled down (or some other reason, I'm not sure).
The initial tabbing worked for the links on the top:
But if I scrolled down using the mouse then clicked, or if I tabbed to the point where the page scrolled down then shift-tabbed back up to a link near the top, the popup would still appear above the link.
Given the error is still present, I'm throwing back to the backlog for another day since we've wrapped up our timebox for page previews work.
Change 1013281 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/Popups@master] Account for scroll offset when using non-mouse positioning
Change #1013281 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Account for scroll offset when using non-mouse positioning
Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
✅ AC1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.
Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
✅ AC1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.
Tabbing scrolls the page so that the focused element is in the middle vertically so this is hard to validate that when tabbing the popup would open down. Hovering does show this to be true.
