Popup not necessarily positioned correctly when tabbing through links
Open, LowPublic
Actions

Assigned To

Authored By

	Esanders
	Dec 15 2020, 8:55 PM

Description

If I tab onto a link, the hover card always appears above the link, even if there isn't room to show it.

Hovering with the mouse results in the card being placed below the link if necessary.

QA Results - Beta

AC	Status	Details
1	❌	T270215#7366016

Details

	Subject	Repo	Branch	Lines +/-
	Account for scroll offset when using non-mouse positioning	mediawiki/extensions/Popups	master	+3 -3

Customize query in gerrit

Event Timeline

Esanders created this task.Dec 15 2020, 8:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2020, 8:55 PM

• nray added a project: Web-Team-Backlog.Dec 16 2020, 8:22 PM

Jdlrobson assigned this task to ovasileva.Jan 5 2021, 7:04 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva triaged this task as Medium priority.Jan 18 2021, 10:25 PM

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

ovasileva lowered the priority of this task from Medium to Low.Feb 22 2021, 1:44 PM

Jdlrobson added a parent task: T287097: [GOAL] Accessibility compliance focus (new development & fixes).Jul 26 2021, 8:51 PM

Jdlrobson removed ovasileva as the assignee of this task.Jul 26 2021, 8:55 PM

Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog board.

Jdlrobson added a subscriber: ovasileva.

Jdlrobson moved this task from unsed to Kanbanana-FY-2021-22 on the Web-Team-Backlog board.Aug 5 2021, 10:05 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

I tested this on Chrome, and now I see the page preview always appearing under the link so I think this is fixed?

Screen Shot 2021-08-12 at 10.09.44 AM.png (696×1 px, 645 KB)

ovasileva assigned this task to Edtadros.Sep 9 2021, 5:06 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

AC1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.

Screen Recording 2021-09-13 at 6.59.25 AM.mov.gif (938×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Sep 13 2021, 2:03 PM

Test Result - Beta (Retest)

Status: ❌ FAIL
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ A{F34648841}C1: When tabbing through a page's links. Popups should appear above the link towards the bottom of the page, and below the link towards the top of the page.

While testing Prod I noticed that the behavior changed if I scrolled down (or some other reason, I'm not sure).

The initial tabbing worked for the links on the top:

Screen Recording 2021-09-20 at 9.07.18 AM.mov.gif (792×1 px, 2 MB)

But if I scrolled down using the mouse then clicked, or if I tabbed to the point where the page scrolled down then shift-tabbed back up to a link near the top, the popup would still appear above the link.

Screen Recording 2021-09-20 at 9.08.27 AM.mov.gif (792×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Sep 20 2021, 4:14 PM

Edtadros updated the task description. (Show Details)

Given the error is still present, I'm throwing back to the backlog for another day since we've wrapped up our timebox for page previews work.

Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 21 2021, 4:05 PM

Jdlrobson moved this task from Future Unplanned to Page previews maintenance on the Web-Team-Backlog (Needs Prioritization (Tech)) board.

Jdlrobson removed a parent task: T287097: [GOAL] Accessibility compliance focus (new development & fixes).Sep 27 2021, 5:09 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)).Dec 9 2021, 7:05 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Dec 13 2021, 2:31 PM

ovasileva moved this task from Needs More Work to Needs Analysis on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 13 2021, 6:31 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Jan 25 2022, 6:21 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2021-22).Jan 25 2022, 6:21 PM

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.

Jdlrobson moved this task from Current Fiscal Year to Incoming on the Web-Team-Backlog board.Wed, Mar 20, 8:56 PM

Change 1013281 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Popups@master] Account for scroll offset when using non-mouse positioning

https://gerrit.wikimedia.org/r/1013281

gerritbot added a project: Patch-For-Review.Thu, Mar 21, 12:15 PM

Change #1013281 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Account for scroll offset when using non-mouse positioning

https://gerrit.wikimedia.org/r/1013281

matmarex closed this task as Resolved.Sun, Apr 14, 2:42 AM

matmarex assigned this task to Esanders.

matmarex removed a project: Patch-For-Review.

matmarex subscribed.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Sun, Apr 14, 3:00 AM

This needs QA.

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.Mon, Apr 15, 4:25 PM

	F34648835: Screen Recording 2021-09-20 at 9.07.18 AM.mov.gif
	Sep 20 2021, 4:14 PM

	F34648839: Screen Recording 2021-09-20 at 9.08.27 AM.mov.gif
	Sep 20 2021, 4:14 PM

	F34648841: Screen Recording 2021-09-20 at 9.11.29 AM.mov.gif
	Sep 20 2021, 4:14 PM

	F34641884: Screen Recording 2021-09-13 at 6.59.25 AM.mov.gif
	Sep 13 2021, 2:02 PM

	F34591902: Screen Shot 2021-08-12 at 10.09.44 AM.png
	Aug 12 2021, 5:10 PM

Popup not necessarily positioned correctly when tabbing through linksOpen, LowPublicActions

Description

QA Results - Beta

Details

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta (Retest)

QA Steps

Popup not necessarily positioned correctly when tabbing through links
Open, LowPublic
Actions