Page MenuHomePhabricator
Create Task
Maniphest T270720

Graph tag doesn't work in interface messages (ru.wikipedia, Page information action)
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To
None
Authored By
Iniquity
Dec 22 2020, 6:25 PM
Tags
Referenced Files
F33970348: image.png
Dec 22 2020, 8:07 PM
F33970350: image.png
Dec 22 2020, 8:07 PM
F33969786: image.png
Dec 22 2020, 6:25 PM
F33969782: image.png
Dec 22 2020, 6:25 PM
Subscribers
Aklapper
Iniquity
Krinkle
SerDIDG
Yurik

Description

In connection with T259207 statistics on graphs in Russian Wikipedia stopped working, how can we fix it?
https://ru.wikipedia.org/w/index.php?title=Википедия:КУЛ_должен_быть_очищен/IX&action=info&uselang=ru
It was added here: https://ru.wikipedia.org/wiki/MediaWiki:Pageinfo-header

Steps to Reproduce:

  1. Go to ruwiki
  2. Open any popular page (https://ru.wikipedia.org/wiki/Заглавная_страница for example)
  3. Open info about this page with uselang=ru (https://ru.wikipedia.org/w/index.php?title=Заглавная_страница&action=info&uselang=ru)

Actual Results:
The graphs at the top are not displayed

image.png (513×898 px, 34 KB)

Expected Results:
The graphs at the top are displayed

image.png (348×989 px, 29 KB)

Related Objects

Event Timeline

Iniquity created this task.Dec 22 2020, 6:25 PM
Jdforrester-WMF added a comment.Dec 22 2020, 7:58 PM

Yup, this is an inescapable consequence of client-side-only rendering. For now we should switch off the graphs from the info page.

Jdforrester-WMF added a project: PageViewInfo.Dec 22 2020, 7:58 PM
Jdforrester-WMF added a comment.Dec 22 2020, 8:06 PM

Hmm, no, it's rendering for me? It's all client-side already.

Jdforrester-WMF added a comment.Dec 22 2020, 8:07 PM

image.png (1×2 px, 317 KB)
and
image.png (1×2 px, 260 KB)
for example.

Iniquity added a comment.Dec 22 2020, 8:21 PM
In T270720#6708984, @Jdforrester-WMF wrote:

Hmm, no, it's rendering for me? It's all client-side already.

Oh, sorry, it needs uselang=ru: https://ru.wikipedia.org/w/index.php?title=Заглавная_страница&action=info&uselang=ru

Iniquity updated the task description. (Show Details)Dec 22 2020, 8:23 PM
Jdforrester-WMF added a comment.Dec 22 2020, 8:34 PM

It looks like Шаблон:График просмотров is inserting a graph callback, which isn't supported any more; I believe the template is maintained at https://www.mediawiki.org/wiki/Template_talk:Graph:PageViews where people might have more ideas, sorry.

SerDIDG subscribed.Dec 22 2020, 9:55 PM
jbond removed projects: serviceops, SRE.Dec 30 2020, 12:49 PM
hashar unsubscribed.Apr 28 2021, 8:32 AM
Iniquity added a subscriber: Yurik.May 18 2021, 5:09 AM

@Yurik hi :) can you help with this issue?

Jdforrester-WMF closed this task as Invalid.May 18 2021, 10:41 PM

This needs to be fixed in the template on-wiki, which isn't managed on Phabricator, sorry!

Iniquity reopened this task as Open.May 18 2021, 10:56 PM
Iniquity edited projects, added Russian-Sites; removed PageViewInfo, Platform Engineering (Icebox), Graphoid.
Iniquity removed subscribers: akosiaris, dr0ptp4kt, MarkTraceur and 9 others.
Jdforrester-WMF removed a parent task: T242855: Undeploy graphoid.May 18 2021, 10:58 PM
Krinkle renamed this task from The graphs on a 'info' special page are no longer displayed to Pageview graph on "Page information" action broken.May 18 2021, 11:00 PM
Krinkle renamed this task from Pageview graph on "Page information" action broken to Graph tag doesn't work in interface messages (ru.wikipedia, Page information action).
Krinkle triaged this task as High priority.
Krinkle added projects: PageViewInfo, Regression.
Krinkle removed projects: Regression, PageViewInfo.
Krinkle subscribed.May 18 2021, 11:05 PM

Depending on when this broke this could be caused by:

  • Graphoid disablement. Thus relying on client JS which perhaps never worked in the Graph extension for interfaces messages on special pages and other page actions.
  • Or, the extension was changed, or the core code for adding interface messages to OutputPage, such that the ParserOutput module gets lost.
  • Or, breaking changes in the skin, such as the current mw-content-body mess, could have caused this to stop working.
MBH subscribed.May 19 2021, 11:13 AM
Aklapper added a project: MediaWiki-extensions-Graph.Jun 14 2021, 2:18 PM
Iniquity closed this task as a duplicate of T232388: MediaWiki:Pageinfo-header graphs not displaying on ruwiki, "unknown error".Nov 11 2021, 3:51 PM
MBH unsubscribed.Nov 12 2021, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits