Page MenuHomePhabricator
Create Task
Maniphest T242855

Undeploy graphoid
Closed, ResolvedPublic
Actions

Description

Per T211881, graphoid is to be undeploy (with the functionality being transferred to the client side). This task is for tracking this. A list of steps, in dependency order are below. For now they are SRE related, feel free to augment the list

  • Deploy client side only on beta
  • Deploy client side config change to test wiki's
  • Deploy spinner change on beta
  • Deploy client side config to mediawiki.org
  • Deploy spinner change to production
  • Deploy client side config to phase 1 wikis
  • Deploy css perf changes to production
  • Deploy client side config to phase 2 wikis
  • Deploy client side config to phase 3 wikis
  • Deploy client side config to phase 4 wikis
  • Deploy final client side config clean-up
  • Update RESTBase configuration to no longer reference graphoid
  • Remove the LVS configuration for graphoid from scb and LVS loadbalancers
  • Remove DNS for graphoid.svc.{eqiad|codfw}.wmnet
  • Remove graphoid puppet code
  • Stop graphoid on scb clusters, cleanup scb from graphoid configuration, code, deploys, users etc

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Lens0021 subscribed.Dec 3 2020, 11:44 PM
Wugapodes subscribed.Dec 7 2020, 7:01 PM
Izno subscribed.Dec 17 2020, 10:40 PM
Jdforrester-WMF closed subtask T271495: Final undeploy for graphoid - en.wiki as Resolved.Jan 8 2021, 12:15 AM
gerritbot added a comment.Jan 8 2021, 12:19 AM

Change 654950 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Graph@master] Drop ability to attempt server-side rendering with Graphoid

https://gerrit.wikimedia.org/r/654950

gerritbot added a project: Patch-For-Review.Jan 8 2021, 12:19 AM
gerritbot added a comment.Jan 8 2021, 12:24 AM

Change 654954 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop ability to use graphoid

https://gerrit.wikimedia.org/r/654954

Jdforrester-WMF updated the task description. (Show Details)Jan 8 2021, 12:25 AM
gerritbot added a comment.Jan 8 2021, 1:46 AM

Change 654959 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] lvs: stop monitoring graphoid

https://gerrit.wikimedia.org/r/654959

gerritbot added a comment.Jan 8 2021, 1:48 AM

Change 654960 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] admin: delete the graphoid admin group, remove from scb

https://gerrit.wikimedia.org/r/654960

gerritbot added a comment.Jan 8 2021, 5:47 PM

Change 654960 abandoned by Dzahn:
[operations/puppet@production] admin: delete the graphoid admin group, remove from scb

Reason:
ok, waiting until everything is removed

https://gerrit.wikimedia.org/r/654960

gerritbot added a comment.Jan 8 2021, 8:18 PM

Change 654959 abandoned by Dzahn:
[operations/puppet@production] lvs: stop monitoring graphoid

Reason:
like with the admin group.. only after it's actually removed

https://gerrit.wikimedia.org/r/654959

• Jseddon closed subtask T259207: Undeploy graphoid for phase 3 wiki's as Resolved.Jan 9 2021, 4:55 PM
• Jseddon closed subtask T236892: Communicate transition of Graph/Graphoid to client-side only JavaScript feature as Resolved.
Aklapper updated the task description. (Show Details)Jan 10 2021, 11:33 AM
gerritbot added a comment.Jan 12 2021, 3:57 PM

Change 654959 restored by Alexandros Kosiaris:
[operations/puppet@production] lvs: stop monitoring graphoid

https://gerrit.wikimedia.org/r/654959

gerritbot added a comment.Jan 12 2021, 4:15 PM

Change 654959 merged by Alexandros Kosiaris:
[operations/puppet@production] lvs: stop monitoring graphoid

https://gerrit.wikimedia.org/r/654959

• Jseddon closed subtask T270443: Undeploy graphoid for phase 4 wiki's as Resolved.Jan 26 2021, 2:09 AM
MusikAnimal mentioned this in T151654: Support high-dpi graph image generation.Feb 3 2021, 3:25 AM
akosiaris updated the task description. (Show Details)Feb 12 2021, 12:41 PM
akosiaris updated the task description. (Show Details)
gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663812 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] restbase: Remove graphoid config

https://gerrit.wikimedia.org/r/663812

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663813 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] Remove graphoid from services_proxy

https://gerrit.wikimedia.org/r/663813

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663814 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] Remove graphoid deployment references

https://gerrit.wikimedia.org/r/663814

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663815 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] graphoid: Switch to lvs_setup

https://gerrit.wikimedia.org/r/663815

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663816 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] graphoid: Switch to service_setup

https://gerrit.wikimedia.org/r/663816

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663817 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] graphoid: Remove conftool data

https://gerrit.wikimedia.org/r/663817

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663818 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] graphoid: Remove LVS IP from scb

https://gerrit.wikimedia.org/r/663818

gerritbot added a comment.Feb 12 2021, 12:53 PM

Change 663819 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/puppet@production] graphoid: Remove all puppet references

https://gerrit.wikimedia.org/r/663819

akosiaris added a comment.Feb 12 2021, 12:56 PM

Patches being uploaded. I 've tried to cover everything, but maybe I missed something. In the course of the next week they will be slowly deployed, purging graphoid from the infrastructure. In case anyone makes it to this task because of some resource (VM, dev env, whatever) was rendered inoperable or broken because of these patches, they have my implicit +1 to destroy above said resource and/or proceed to corrective actions for untangling their resource from graphoid.

gerritbot added a comment.Feb 12 2021, 1:00 PM

Change 663822 had a related patch set uploaded (by Alexandros Kosiaris; owner: Alexandros Kosiaris):
[operations/dns@master] graphoid: Remove all RRs for it

https://gerrit.wikimedia.org/r/663822

hashar added a project: Projects-Cleanup.Feb 12 2021, 1:20 PM

Tagging Projects-Cleanup for the repositories archival.

I guess we can empty up mediawiki/service/graphoid.git with a note pointing back to this task, mark the repository readonly and then do the rest of the usual cleanup task we are used to (deactivate in Diffusion, delete github mirrors etc).

DannyS712 renamed this task from Undeploy graphoid to Undeploy graphoid.Feb 12 2021, 3:26 PM
Lens0021 unsubscribed.Feb 12 2021, 5:11 PM
Jdforrester-WMF added a comment.Feb 14 2021, 7:23 PM
In T242855#6826152, @hashar wrote:

Tagging Projects-Cleanup for the repositories archival.

I guess we can empty up mediawiki/service/graphoid.git with a note pointing back to this task, mark the repository readonly and then do the rest of the usual cleanup task we are used to (deactivate in Diffusion, delete github mirrors etc).

Let's do that as a distinct task.

Jdforrester-WMF updated the task description. (Show Details)Feb 14 2021, 7:23 PM
Jdforrester-WMF removed a project: Projects-Cleanup.
Jdforrester-WMF added a parent task: T274738: Archive the graphoid service and deploy repos.Feb 14 2021, 7:38 PM
Stashbot added a comment.Feb 17 2021, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-17T18:20:17Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@c5c4b2d]: Remove graphoid T242855

Stashbot added a comment.Feb 17 2021, 6:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-17T18:40:10Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@c5c4b2d]: Remove graphoid T242855 (duration: 19m 54s)

gerritbot added a comment.Feb 18 2021, 3:33 PM

Change 663812 merged by Alexandros Kosiaris:
[operations/puppet@production] restbase: Remove graphoid config

https://gerrit.wikimedia.org/r/663812

akosiaris updated the task description. (Show Details)Feb 19 2021, 1:30 PM
gerritbot added a comment.Feb 19 2021, 1:39 PM

Change 663813 merged by Alexandros Kosiaris:
[operations/puppet@production] Remove graphoid from services_proxy

https://gerrit.wikimedia.org/r/663813

The_RedBurn mentioned this in T216431: Graphs create img tags without width and height.Feb 21 2021, 9:22 AM
gerritbot added a comment.Feb 22 2021, 1:42 PM

Change 663814 merged by Alexandros Kosiaris:
[operations/puppet@production] Remove graphoid deployment references

https://gerrit.wikimedia.org/r/663814

gerritbot added a comment.Feb 22 2021, 1:42 PM

Change 663815 merged by Alexandros Kosiaris:
[operations/puppet@production] graphoid: Switch to lvs_setup

https://gerrit.wikimedia.org/r/663815

gerritbot added a comment.Feb 22 2021, 2:36 PM

Change 663816 merged by Alexandros Kosiaris:
[operations/puppet@production] graphoid: Switch to service_setup

https://gerrit.wikimedia.org/r/663816

gerritbot added a comment.Feb 22 2021, 2:42 PM

Change 663822 merged by Alexandros Kosiaris:
[operations/dns@master] graphoid: Remove all RRs for it

https://gerrit.wikimedia.org/r/663822

akosiaris updated the task description. (Show Details)Feb 22 2021, 2:52 PM
gerritbot added a comment.Feb 23 2021, 12:51 PM

Change 663817 merged by Alexandros Kosiaris:
[operations/puppet@production] graphoid: Remove conftool data

https://gerrit.wikimedia.org/r/663817

gerritbot added a comment.Feb 23 2021, 12:52 PM

Change 663818 merged by Alexandros Kosiaris:
[operations/puppet@production] graphoid: Remove LVS IP from scb

https://gerrit.wikimedia.org/r/663818

gerritbot added a comment.Feb 23 2021, 12:52 PM

Change 663819 merged by Alexandros Kosiaris:
[operations/puppet@production] graphoid: Remove all puppet references

https://gerrit.wikimedia.org/r/663819

Stashbot added a comment.Mar 4 2021, 3:00 PM

Mentioned in SAL (#wikimedia-releng) [2021-03-04T15:00:48Z] <Majavah> remove graphoid role from deploymenr-sca[01-02] ref T276102 and it being decomissioned in T242855

Stashbot mentioned this in T276102: broken puppet on deployment-sca01.deployment-prep.eqiad1.wikimedia.cloud and deployment-sca02.deployment-prep.eqiad1.wikimedia.cloud.Mar 4 2021, 3:00 PM
akosiaris updated the task description. (Show Details)Mar 4 2021, 3:08 PM
hashar unsubscribed.Mar 4 2021, 4:23 PM
gerritbot added a comment.Mar 22 2021, 9:46 AM

Change 654954 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop ability to use graphoid

https://gerrit.wikimedia.org/r/654954

Jdforrester-WMF closed subtask T270720: Graph tag doesn't work in interface messages (ru.wikipedia, Page information action) as Invalid.May 18 2021, 10:41 PM
Iniquity reopened subtask T270720: Graph tag doesn't work in interface messages (ru.wikipedia, Page information action) as Open.May 18 2021, 10:56 PM
Jdforrester-WMF removed a subtask: T270720: Graph tag doesn't work in interface messages (ru.wikipedia, Page information action).May 18 2021, 10:58 PM
Seddon closed subtask T255420: Provide static fallback for noscript users as Resolved.May 25 2021, 2:39 PM
Seddon removed Seddon as the assignee of this task.May 25 2021, 2:51 PM
Seddon subscribed.
AntiCompositeNumber mentioned this in T156191: Fix the rendering font used by the Graphs extension.Oct 9 2021, 2:05 AM
Aklapper added a comment.Oct 10 2021, 12:05 PM

Half a year later, is there anyone feeling kind of responsible to perform the remaining two bullet points still open in the task description?

TheReadOnly subscribed.Oct 10 2021, 4:36 PM

@Aklapper Can a volunteer like me perform the remaining two bullet points? If not, can you please point me towards any code changes that might be required to do the 2 clean up tasks?

akosiaris added a comment.Oct 11 2021, 2:47 PM
In T242855#7415161, @Aklapper wrote:

Half a year later, is there anyone feeling kind of responsible to perform the remaining two bullet points still open in the task description?

For what is worth, I only have a vague idea what the last 2 remaining bullet points are about. Let me know though if I can somehow help (merge/deploy something).

Aklapper added a comment.Oct 14 2021, 6:08 AM

@Seddon: Could you elaborate on these bullet points, please? Thanks!

Jgiannelos mentioned this in T285093: Graphs appear as blank on the mobile app.Dec 6 2021, 2:00 PM
matmarex mentioned this in T298030: Visual Editor hangs with Template:Graph:Lines.Dec 20 2021, 5:41 PM
TheDJ subscribed.Jan 20 2022, 10:51 AM

I've removed graphoid info from https://www.mediawiki.org/wiki/Extension:Graph to avoid further confusion for readers. I moved part of it to https://www.mediawiki.org/wiki/Extension:Graph/Graphoid (marked historical) just in case everyone ever needs it again.

I updated the patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Graph/+/654950 to remove the logic associated with graphoid from the extension.

As far as I can determine there are no further client side css performance updates outstanding, but I'm not sure what "Deploy final client side config clean-up" is about.

TheDJ mentioned this in T277375: Graphs and charts are not shown in Wikipedia Android App.Jan 20 2022, 10:54 AM
TheDJ mentioned this in T98698: PDF rendering does not include graph image, as the Graph extension does not support Graphoid anymore.Jan 20 2022, 1:23 PM
TheDJ mentioned this in T299642: Design a fallback image for Graphs.Jan 20 2022, 1:33 PM
TheDJ mentioned this in T240626: Performance review of client-side-only version of Graph extension.Jan 20 2022, 1:59 PM
gerritbot added a comment.Jan 21 2022, 10:25 PM

Change 654950 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] Drop ability to attempt server-side rendering with Graphoid

https://gerrit.wikimedia.org/r/654950

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 21 2022, 11:00 PM
akosiaris mentioned this in T294329: Document checklist steps to undeploy / sunset a codebase on WMF servers (not: archiving).Jul 19 2022, 1:59 PM
Krinkle closed subtask T240626: Performance review of client-side-only version of Graph extension as Resolved.Sep 26 2022, 5:39 PM
jijiki moved this task from cross-team active to 🛎 Services & Oids on the serviceops board.Oct 17 2022, 4:05 PM
jijiki closed subtask T256641: Delay spinner showing for graphs for 1s as Resolved.Oct 17 2022, 4:19 PM
Seddon unsubscribed.Oct 19 2022, 1:01 PM
Jdforrester-WMF closed this task as Resolved.Feb 22 2023, 3:34 PM

I'll mark this as Resolved. No-one wants to confess to knowing what the remaining checkboxes are.

Krinkle mentioned this in T272530: Adding a graph to a page doubles JS payload on mobile and desktop.Apr 19 2023, 10:39 PM
Volans reopened this task as Open.Oct 11 2023, 11:24 AM
Volans subscribed.

FYI The service IPs in Netbox are still allocated to the service and probably needs cleanup:
https://netbox.wikimedia.org/ipam/ip-addresses/?q=graphoid

Once deleted a run of the sre.dns.netbox cookbook is needed.

Volans mentioned this in T270071: SVC DNS zonefiles and source of truth.Oct 11 2023, 12:21 PM
Clement_Goubert closed this task as Resolved.Oct 11 2023, 12:42 PM
Clement_Goubert claimed this task.
Clement_Goubert subscribed.

Done

Aklapper added a comment.Oct 12 2023, 1:56 PM

I updated https://www.mediawiki.org/wiki/Extension:Graph/Graphoid accordingly.

Krinkle mentioned this in T169027: Provide iframe sandboxing for rich-media extensions (defense in depth).Nov 28 2023, 2:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits