"The filename is not allowed." when attempting to upload MP4 file on en.wiki
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	MBinder_WMF
	Jan 5 2021, 2:16 AM

Description

Steps to reproduce:
Upload video via "Insert" button in Visual Editor

Observed Result:
About a second after encountering the "Details" dialogue, the error pops up and blocks engagement.

Expected Result:
Video uploads and the page allows for interaction with the dialogue.

Screenshot/Screen capture:

Screen Shot 2021-01-04 at 6.28.29 PM.png (659×519 px, 54 KB)

file_name_not_allowed.mp41 MBDownload

Device:
MacBook Air 13-inch Early 2015

Browser:
Chrome Version 87.0.4280.88 (Official Build) (x86_64)

Wiki:
https://en.wikipedia.org/

Editor:
VE

Page:
https://en.wikipedia.org/wiki/Spotted_sandpiper

Environment:
Production

Details

	Subject	Repo	Branch	Lines +/-
	ApiUpload: Don't error about filenames on partially-uploaded files	mediawiki/core	master	+20 -30

Customize query in gerrit

Related Objects

Mentioned Here: T208539: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php
rMW82458c0ce0f5: Validate name for async uploads

Event Timeline

MBinder_WMF created this task.Jan 5 2021, 2:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2021, 2:16 AM

MBinder_WMF added a project: Editing-team.Jan 5 2021, 2:16 AM

After getting this message on Commons

Screen Shot 2021-01-04 at 6.26.46 PM.png (440×380 px, 48 KB)

I assume the en.wiki error is because VE does not support .mp4 files. However, the error seems to suggest that the name of the file is the issue (which is sort of true, though editing out ".mp4" from the filename does not change the issue). So, this might not be a bug, but rather a feature request for a clearer error message. :)

MBinder_WMF updated the task description. (Show Details)Jan 5 2021, 2:30 AM

The cross-wiki upload tool is not VE-specific, it's also in the 2010 and 2017 wikitext editors. Unfortunately there's no Multimedia team any more…

Re-wording the error message from "extension" to "file type" is easy, but not necessarily much more helpful…

Restricted Application added a project: Commons. · View Herald TranscriptJan 5 2021, 2:44 AM

The API error is illegal-filename so the editor is behaving correctly. This is a bug in ApiUpload::verifyUpload() - in the chunked upload code path, it is checking UploadBase::getTitle() and then returning a useless error message, instead of checking UploadBase::validateName() which would provide a useful error.

Ha. I guess it should call them the other way around?

DannyS712 removed a project: Multimedia.Jan 5 2021, 4:08 AM

… or given that checkVerification handles case UploadBase::ILLEGAL_FILENAME and case UploadBase::FILETYPE_MISSING, just scrap it? But then, there's also case UploadBase::FILE_TOO_LARGE…

This code dates from 2019, moved earlier for T208539: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php: rMW82458c0ce0f5: Validate name for async uploads

Yeah, just scrap, I think. FILE_TOO_LARGE and the other UploadBase::verifyUpload() stuff will be checked later - AIUI the first two branches in ApiUpload::verifyUpload() are called for individual chunks so most checks wouldn't make sense there. After the file is assembled, it will be called again and will use the last branch.

Umherirrender added subscribers: matthiasmullie, Cparle.Jan 5 2021, 12:34 PM

Change 654479 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] ApiUpload: Don't error about filenames on partially-uploaded files

https://gerrit.wikimedia.org/r/654479

gerritbot added a project: Patch-For-Review.Jan 5 2021, 7:02 PM

Jdforrester-WMF claimed this task.Jan 5 2021, 7:06 PM

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 1:34 AM

@Jdforrester-WMF: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Jdforrester-WMF claimed this task.Nov 21 2023, 2:08 PM

This is veryyyy annoying

@Lectrician1: Please do not add "me too" comments which add nothing but notifications. Use tokens instead. Thanks.

Mvolz awarded a token.Apr 11 2024, 12:38 PM

	F33984911: Screen Shot 2021-01-04 at 6.28.29 PM.png
	Jan 5 2021, 2:30 AM

	F33984908: Screen Shot 2021-01-04 at 6.26.46 PM.png
	Jan 5 2021, 2:30 AM

"The filename is not allowed." when attempting to upload MP4 file on en.wikiOpen, Needs TriagePublicActions

Description

Details

Related Objects

Event Timeline

"The filename is not allowed." when attempting to upload MP4 file on en.wiki
Open, Needs TriagePublic
Actions