Page MenuHomePhabricator
Create Task
Maniphest T271259

Database query error when viewing non-existent pages on mediawiki.org
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Viewing the page Extension:MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec on MediaWiki.org, which was recently deleted, is producing a database error.

Error message
[X-TXJApAADoAAHm5k38AAABM] 2021-01-05 21:16:21: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Details

Request ID
X-TXJApAADoAAHm5k38AAABM
Request URL
https://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec&action=edit&redlink=1
Stack Trace
2021-01-05 21:16:21 [X-TXJApAADoAAHm5k38AAABM] mw1263 mediawikiwiki 1.36.0-wmf.25 exception ERROR: [X-TXJApAADoAAHm5k38AAABM] /w/index.php?title=Extension:MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec&action=edit&redlink=1   Wikimedia\Rdbms\DBQueryError from line 1699 of /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php: Error 1176: Key 'log_times' doesn't exist in table 'logging' (10.64.16.7)
Function: IndexPager::buildQueryInfo (LogPager)
Query: SELECT  /*! STRAIGHT_JOIN */ log_id,log_type,log_action,log_timestamp,log_namespace,log_title,log_params,log_deleted,user_id,user_name,user_editcount,comment_log_comment.comment_text AS `log_comment_text`,comment_log_comment.comment_data AS `log_comment_data`,comment_log_comment.comment_id AS `log_comment_cid`,actor_log_user.actor_user AS `log_user`,actor_log_user.actor_name AS `log_user_text`,log_actor,(SELECT  GROUP_CONCAT(ctd_name SEPARATOR ',')  FROM `change_tag` JOIN `change_tag_def` ON ((ct_tag_id=ctd_id))   WHERE ct_log_id=log_id  ) AS `ts_tags`  FROM `logging` IGNORE INDEX (log_times) JOIN `comment` `comment_log_comment` ON ((comment_log_comment.comment_id = log_comment_id)) JOIN `actor` `actor_log_user` ON ((actor_log_user.actor_id = log_actor)) LEFT JOIN `user` ON ((user_id=actor_log_user.actor_user))   WHERE (log_action != 'revision') AND (log_type NOT IN ('spamblacklist','titleblacklist','urlshortener','abusefilterprivatedetails','oath','suppress')) AND log_type IN ('delete','move')  AND log_namespace = 102 AND log_title = 'MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec' AND ((log_deleted & 1) = 0)  ORDER BY log_timestamp DESC LIMIT 11  
 {"exception_id":"X-TXJApAADoAAHm5k38AAABM","exception_url":"/w/index.php?title=Extension:MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec&action=edit&redlink=1","caught_by":"entrypoint"} 
[Exception Wikimedia\Rdbms\DBQueryError] (/srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php:1699) Error 1176: Key 'log_times' doesn't exist in table 'logging' (10.64.16.7)
Function: IndexPager::buildQueryInfo (LogPager)
Query: SELECT  /*! STRAIGHT_JOIN */ log_id,log_type,log_action,log_timestamp,log_namespace,log_title,log_params,log_deleted,user_id,user_name,user_editcount,comment_log_comment.comment_text AS `log_comment_text`,comment_log_comment.comment_data AS `log_comment_data`,comment_log_comment.comment_id AS `log_comment_cid`,actor_log_user.actor_user AS `log_user`,actor_log_user.actor_name AS `log_user_text`,log_actor,(SELECT  GROUP_CONCAT(ctd_name SEPARATOR ',')  FROM `change_tag` JOIN `change_tag_def` ON ((ct_tag_id=ctd_id))   WHERE ct_log_id=log_id  ) AS `ts_tags`  FROM `logging` IGNORE INDEX (log_times) JOIN `comment` `comment_log_comment` ON ((comment_log_comment.comment_id = log_comment_id)) JOIN `actor` `actor_log_user` ON ((actor_log_user.actor_id = log_actor)) LEFT JOIN `user` ON ((user_id=actor_log_user.actor_user))   WHERE (log_action != 'revision') AND (log_type NOT IN ('spamblacklist','titleblacklist','urlshortener','abusefilterprivatedetails','oath','suppress')) AND log_type IN ('delete','move')  AND log_namespace = 102 AND log_title = 'MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec' AND ((log_deleted & 1) = 0)  ORDER BY log_timestamp DESC LIMIT 11  

  #0 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php(1683): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
  #1 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
  #2 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
  #3 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query(string, string, integer)
  #4 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
  #5 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
  #6 /srv/mediawiki/php-1.36.0-wmf.25/includes/pager/IndexPager.php(449): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
  #7 /srv/mediawiki/php-1.36.0-wmf.25/includes/pager/IndexPager.php(280): IndexPager->reallyDoQuery(string, integer, boolean)
  #8 /srv/mediawiki/php-1.36.0-wmf.25/includes/logging/LogPager.php(499): IndexPager->doQuery()
  #9 /srv/mediawiki/php-1.36.0-wmf.25/includes/pager/IndexPager.php(588): LogPager->doQuery()
  #10 /srv/mediawiki/php-1.36.0-wmf.25/includes/logging/LogEventsList.php(700): IndexPager->getBody()
  #11 /srv/mediawiki/php-1.36.0-wmf.25/includes/EditPage.php(2842): LogEventsList::showLogExtract(OutputPage, array, Title, string, array)
  #12 /srv/mediawiki/php-1.36.0-wmf.25/includes/EditPage.php(652): EditPage->showIntro()
  #13 /srv/mediawiki/php-1.36.0-wmf.25/includes/actions/EditAction.php(71): EditPage->edit()
  #14 /srv/mediawiki/php-1.36.0-wmf.25/includes/MediaWiki.php(532): EditAction->show()
  #15 /srv/mediawiki/php-1.36.0-wmf.25/includes/MediaWiki.php(316): MediaWiki->performAction(Article, Title)
  #16 /srv/mediawiki/php-1.36.0-wmf.25/includes/MediaWiki.php(945): MediaWiki->performRequest()
  #17 /srv/mediawiki/php-1.36.0-wmf.25/includes/MediaWiki.php(548): MediaWiki->main()
  #18 /srv/mediawiki/php-1.36.0-wmf.25/index.php(53): MediaWiki->run()
  #19 /srv/mediawiki/php-1.36.0-wmf.25/index.php(46): wfIndexMain()
  #20 /srv/mediawiki/w/index.php(3): require(string)
  #21 {main}
SubjectRepoBranchLines +/-
Check for the index name while it's being renamedmediawiki/coremaster+4 -1
Check for the index name while it's being renamedmediawiki/corewmf/1.36.0-wmf.25+4 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT267418 1.36.0-wmf.25 deployment blockers
 ResolvedPRODUCTION ERRORLadsgroupT271259 Database query error when viewing non-existent pages on mediawiki.org

Event Timeline

Pppery created this task.Jan 5 2021, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2021, 9:18 PM
Peachey88 triaged this task as Unbreak Now! priority.Jan 5 2021, 9:36 PM
Peachey88 subscribed.

Affects any non existent page not just recently deleted by the looks

Skizzerz renamed this task from Database query error when viewing Extension:MobileFrontend/Hooks/MobileSiteOutputPageBeforeExec on mediawiki.org to Database query error when viewing non-existent pages on mediawiki.org.Jan 5 2021, 9:37 PM
Skizzerz added a parent task: T267418: 1.36.0-wmf.25 deployment blockers.
Skizzerz subscribed.Jan 5 2021, 9:40 PM
In T271259#6724041, @Peachey88 wrote:

Affects any non existent page not just recently deleted by the looks

Modified description to reflect this information, as it matches what I was experiencing as well.

Ciencia_Al_Poder subscribed.Jan 5 2021, 9:41 PM
RhinosF1 subscribed.Jan 5 2021, 9:42 PM
Reedy edited Stack Trace. (Show Details)Jan 5 2021, 9:43 PM
Reedy added a project: MediaWiki-General.
Ladsgroup claimed this task.Jan 5 2021, 9:45 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 5 2021, 9:45 PM
Pppery unsubscribed.Jan 5 2021, 9:46 PM
Reedy subscribed.Jan 5 2021, 9:48 PM

Some relation to: T270033: Fix and enforce table prefix usage in columns and indexes in core, rMW443c94de3f48: Rename four logging indexes to have log_ prefix

gerritbot added a comment.Jan 5 2021, 9:49 PM

Change 654507 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Check for the index name while it's being renamed

https://gerrit.wikimedia.org/r/654507

gerritbot added a project: Patch-For-Review.Jan 5 2021, 9:49 PM
Jdforrester-WMF mentioned this in T270769: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging'.Jan 5 2021, 10:05 PM
gerritbot added a comment.Jan 5 2021, 10:27 PM

Change 654448 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@wmf/1.36.0-wmf.25] Check for the index name while it's being renamed

https://gerrit.wikimedia.org/r/654448

gerritbot added a comment.Jan 5 2021, 10:50 PM

Change 654507 merged by jenkins-bot:
[mediawiki/core@master] Check for the index name while it's being renamed

https://gerrit.wikimedia.org/r/654507

sbassett mentioned this in T270988: CVE-2021-30155: Titleblacklist didn't prevent creation of pages by Special:ChangeContentModel when a rule was met.Jan 5 2021, 10:57 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 5 2021, 11:00 PM
gerritbot added a comment.Jan 5 2021, 11:05 PM

Change 654448 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.25] Check for the index name while it's being renamed

https://gerrit.wikimedia.org/r/654448

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2021, 11:10 PM
Ladsgroup closed this task as Resolved.Jan 5 2021, 11:16 PM
Ladsgroup mentioned this in T267418: 1.36.0-wmf.25 deployment blockers.
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 6 2021, 12:00 AM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Jan 6 2021, 12:15 AM
Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.Jan 27 2021, 8:40 PM
Krinkle edited projects, added MediaWiki-Logevents; removed MediaWiki-General.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL