- Due Date
- Jan 12 2021, 5:00 AM
|mediawiki/extensions/SecurePoll||master||+62 -0||Log when an admin is added to or removed from an election|
- Mentioned In
- T274568: [Bug] Normalise usernames in no-JS
T271280: Make SecurePoll log data downloadable as a CSV or WikiText
T271277: Create Special:SecurePollLog page
- Mentioned Here
- T274790: SecurePoll: Log election admins when an election is first created
T271276: Log when admins access voter data in SecurePoll
rMW08f821e12636: Localisation updates from https://translatewiki.net.
rESPO1ebc4fda886d: Localisation updates from https://translatewiki.net.
rESPObc7fd596c879: Add election id filter to Special:SecurePollLog page
T270313: Investigate work involved in adding log for election admins for SecurePoll [8 hours]
T271270: Create new logging table in SecurePoll
If you add or remove admins when editing an election, this gets recorded in Special:SecurePollLog.
When creating an election, the admins you have chosen are not recorded in the log. I guess this is not necessary.
If you don't touch the admins when editing (even if you change their order) nothing gets recorded in the logs.
In case of regression, I tested adding and removing an admin on beta, which does not have logging enabled.
With JS disabled, there can be some weird behaviour. For example, if you change the election admin from Other Electionadmin to Other_Electionadmin, we appear to treat them as two different users and you get a misleading log entry:
In the same way, you can also add/remove the same admin more than once, and this gets recorded multiple times in the log.
I don't think this is likely to happen in practice, nor would it be a big problem if it did, but I may raise a bug about normalising usernames without JS.
Also, something I think @Tchanders mentioned in the code review comments, is that we are taking user ids from the user table, when we should now be using the actor table. Perhaps there should be a follow up task for that. The same goes for T271276 (which I forgot to comment on that ticket).