Page MenuHomePhabricator

Immortal comment follows me across pages
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Go to a page (e.g., a user talk page) that contains a link to another talk page (e.g., someone else's user talk page)
  2. Click 'New section' at the top to use the New Discussions tool (in visual mode?).
  3. Type something the box.
  4. Decide that you don't want to post that after all. Instead, decide that you want to go to a different talk page (i.e., a talk page that is linked on the current talk page).
    1. Do not close the tab. Do not cancel your new section.
  5. Click the link (which is on the current talk page) to go to a different talk page.
  6. See that New Discussion is trying to put your old comment on the new talk page ("Unsaved changes recovered")

Event Timeline

Well, it can be killed using the cancel button, so I believe the correct term is "eternal" ;)

Change 664808 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/664808

Change 664808 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/664808

Change 665167 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.30] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/665167

Change 665169 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.31] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/665169

Change 665167 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.30] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/665167

Change 665169 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.31] Make new topic autosave specific to page title

https://gerrit.wikimedia.org/r/665169

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:17:35Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/DiscussionTools/: 9c6cdf5: 97acef6: DiscussionTools backports (T272666; T274949) (duration: 01m 26s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:19:21Z] <urbanecm@deploy1001> sync-file aborted: 1cc29df DiscussionTools backports (T272666; T274949) (duration: 00m 00s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:20:49Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/DiscussionTools/: 1cc29df: 6b88aff: DiscussionTools backports (T272666; T274949) (duration: 01m 08s)

ppelberg added a project: Skipped QA.