Page MenuHomePhabricator

Post-deployment QA (New Discussion Tool)
Closed, ResolvedPublic

Description

This task is about making sure the New Discussion Tool is appearing as a Beta Feature and publishing comments as we expect it to.

Testing instructions

Part I: at each of the wikis listed in the ===Where to test section below, do the following:

  1. Visit Special:Preferences > Beta features (read: mw-prefsection-betafeatures) and verify Discussion tools is available as a Beta feature.
  2. Enable the Discusson tools beta feature if it is not already.
  3. Visit Special:Preferences#mw-prefsection-editing and verify the Enable quick topic adding feature is available within the Discussion pages section of the page
  4. Turn on the Enable quick topic adding setting if it is not already.
  5. Visit the "Test pages" listed in the ===Where to test section below. At each of them, do the following:
    • Click the New section / Add topic link/tab and verify the New Discussion Tool opens
  6. Visit your sandbox at each of the wikis listed in the ===Where to test section below and do the following:
    • Verify you can open the New Discussion Tool and use it to publish a new topic to the talk page.
  7. *Revisit** Special:Preferences#mw-prefsection-editing and TURN OFF the Enable quick topic adding feature
  8. Visit any talk page, click the Add topic / New section link and verify the existing experience opens.

Part II: file tickets for any issues that

Where to test

WikipediaLanguage codeTest pages
FrenchfrSandbox talk page
Hebrewhe" "
Hindihi" "
Italianit" "
Japaneseja" "
Koreanko" "
Spanishes" "
Persianfa" "

Done

  • Testing instructions are completed

Event Timeline

ppelberg renamed this task from Pre-deployment regression testing (New Discussion Tool) to Post-deployment QA (New Discussion Tool).Mar 11 2021, 5:44 PM
ppelberg updated the task description. (Show Details)
ppelberg added a project: Editing QA.
ppelberg moved this task from Inbox to High Priority on the Editing QA board.

Checked the availability and the functionality of the quick topic adding feature on the wikis listed.

I had a question about the default state of the check boxes under Discussion pages section of the page Special:Preferences#mw-prefsection-editing.
@ppelberg pointed out that the expected behavior of the default state is reflected by the first two points under the section "Setting Defaults" in this ticket: T270119, where "they should/should not automatically have access to the New Discussion Tool once it is made available." means the checkboxes will be checked/unchecked. If that's the case, then it is failing for users who have never enabled the Reply Tool, by way of the Discussion tools. Because the following is happening in that scenario:

  1. Enabled the Discussion tools beta feature.
  2. Visited Spécial:Préférences#mw-prefsection-editing.
  3. Noticed the checkbox next to the Enable quick topic adding was "checked".

However, my understanding of the "Setting defaults" was that, they are reflecting the availability of those check boxes once the new discussion tool is made available, not the "Default State" of the checkboxes, which is working correctly by the way. When I tested with user accounts which already enabled Discussion tool beta feature they had those checkboxes available to them immediately and for the ones who have not, those appeared after turning on the Beta feature from Preferences.

Can someone confirm the above?

Other than this, all other functionalities are working as expected.

To be clear, you're talking about this one?

Setting defaults

  • 2. For people at wikis where the Reply Tool is currently available as a beta feature and who disabled/never enabled the Reply Tool, by way of the Discussion tools, they should not automatically have access to the New Discussion Tool once it is made available.

I think in "should (not) have access to…" here actually refers to the default state of the checkbox, not to whether it appears on the preferences page.

However, that spec was written before we had the separate checkboxes for Reply Tool and New Discussion Tool – we just had the beta feature (and it only controlled the Reply Tool). So, "who … enabled the Reply Tool" actually refers to just enabling the beta feature, not the other checkbox.

So I think the scenario you gave would actually be the correct behavior under that interpretation? But I'll defer to @ppelberg to tell us again what he meant ;)

To be clear, you're talking about this one?

Setting defaults

  • 2. For people at wikis where the Reply Tool is currently available as a beta feature and who disabled/never enabled the Reply Tool, by way of the Discussion tools, they should not automatically have access to the New Discussion Tool once it is made available.

@matmarex, yes. I think the bit you are quoting above – along with #1 in T270119 > Setting defaults – is what @Ryasmeen was referring to.

I think in "should (not) have access to…" here actually refers to the default state of the checkbox, not to whether it appears on the preferences page.

Precisely. Scenarios #1 and #2 within the Setting defaults section of T270119 are meant to refer to, "...the default state of the checkbox..." within Special:Preferences#mw-prefsection-editing.

So I think the scenario you gave would actually be the correct behavior under that interpretation? But I'll defer to @ppelberg to tell us again what he meant ;)

I too think this is working as expected. As such, I'm going to resolve this task.


//Meta
Rummana / Bartosz: I appreciate y'all untangling this with me.