Steps to Reproduce:
- on desktop, start at Special:Homepage
- click on a link-recommendation task
Actual Results:
- the AddLink plugin does not load
Expected Results:
- the AddLink plugin loads
On MinveraNeue this doesn't seem to be a problem.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add a Link: Open edit mode from JS | mediawiki/extensions/GrowthExperiments | master | +21 -7 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | kostajh | T266437 Add a link engineering: backend product specifications | |||
| Resolved | kostajh | T261396 Add a link: engineering tasks for initial release | |||
| Resolved | BUG REPORT | • mewoph | T277228 VE plugin fails to load on desktop article target |
Event Timeline
Comment Actions
Per discussions in Slack with @kostajh and @Tgr, this seems to be a timing issue introduced by opening the VisualEditor automatically (T276508) upon loading the page via veaction=edit query param (VisualEditor modules might be loaded before SuggestedEdits.Guidance.js is loaded so addPlugin is called but doesn't do anything. For now, I'll make a change to open edit mode from JS instead of upon page load (via query params).
Comment Actions
Change 672560 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a Link: Open edit mode from JS
Comment Actions
I forgot about this yesterday, but the timing issue also affects reloading the editor (e.g. the user pressing F5) so we should probably fix it fully before going live. This change is still useful as reloading issues do not hinder development and QA but unreliability of opening the task would.
Comment Actions
I've +2'ed the patch but as @Tgr mentioned, we should handle page reloads – when the user reloads the page they should be back in the editor with the add link plugin open.
Comment Actions
Change 672560 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a Link: Open edit mode from JS