Page MenuHomePhabricator

Add a link: task should open the article in edit mode
Closed, ResolvedPublic

Description

  • When a user clicks on a task from Special:Homepage they should be in edit mode on the article page.
  • On mobile, the full article should be opened.
  • On mobile, do not show the mobile peek. It is only useful if the user has clicked on a task that opens the article in read mode.
  • Help panel should not be opened when the article is opened in edit mode.

Event Timeline

mewoph updated the task description. (Show Details)
mewoph renamed this task from Add a link: open the article in edit mode to Add a link: task should open the article in edit mode.Mar 4 2021, 11:01 PM

Change 670017 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Open VisualEditor automatically for link-recommendation task type

https://gerrit.wikimedia.org/r/670017

I've +2'ed the patch, but leaving in code review in case we decide we want to do the follow-up action noted in the review.

Change 670017 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Open VisualEditor automatically for link-recommendation task type

https://gerrit.wikimedia.org/r/670017

Change 670312 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Move redirect params logic to TaskType

https://gerrit.wikimedia.org/r/670312

Change 670312 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Move redirect params logic to TaskType

https://gerrit.wikimedia.org/r/670312

Another thing we should do is ensure the mobile peek does not launch on mobile for tasks that are supposed to open in edit mode, since the peek is only useful when the user is looking at the article in read mode.

@kostajh Thanks, that makes sense. I also added that the help panel should be closed as well.

Change 670974 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Don't show mobile peek and help panel for add link task

https://gerrit.wikimedia.org/r/670974

@RHo on mobile, after tapping a task card on Special:Homepage, the user is taken to the article in edit mode. Currently, tapping the "X" to close the editing overlay returns the user to Special:Homepage. Should tapping the X to close the editing overlay instead take the user to the read mode of the article?

http://localhost:8080/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0&mobileaction=toggle_view_mobile#/homepage/suggested-edits

image.png (712×541 px, 122 KB)

http://localhost:8080/w/index.php?title=Lipsko#/editor/all

image.png (712×541 px, 97 KB)

tapping the X at the top left takes me back to http://localhost:8080/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0&mobileaction=toggle_view_mobile#/homepage/suggested-edits

image.png (712×541 px, 122 KB)

I filed a separate task about the placement of the help panel CTA (T277270)

Change 670974 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Don't show mobile peek and help panel for add link task

https://gerrit.wikimedia.org/r/670974

@RHo on mobile, after tapping a task card on Special:Homepage, the user is taken to the article in edit mode. Currently, tapping the "X" to close the editing overlay returns the user to Special:Homepage. Should tapping the X to close the editing overlay instead take the user to the read mode of the article?

Hi @kosta - the link inspector card should not have an "x" icon on it per details and spec on T269644.
However there is an "x" on the top editing toolbar, along with the dropdown to switch editor modes, which brings up a "Are you sure you want to leave?" dialog to confirm they want to leave - details of that interaction are on T269653.

@RHo on mobile, after tapping a task card on Special:Homepage, the user is taken to the article in edit mode. Currently, tapping the "X" to close the editing overlay returns the user to Special:Homepage. Should tapping the X to close the editing overlay instead take the user to the read mode of the article?

Hi @kosta - the link inspector card should not have an "x" icon on it per details and spec on T269644.
However there is an "x" on the top editing toolbar, along with the dropdown to switch editor modes, which brings up a "Are you sure you want to leave?" dialog to confirm they want to leave - details of that interaction are on T269653.

👍 thanks for clarifying!

The scope of the task is done - checked in testwiki wmf.35.

Further work will be done in the following phab tasks:

T269644
T269653

Howver, @RHo - something to be aware of: on mobile the extended Add link panel covers almost the whole article.

IMG_9611.PNG (1×640 px, 109 KB)

The scope of the task is done - checked in testwiki wmf.35.

Further work will be done in the following phab tasks:

T269644
T269653

Howver, @RHo - something to be aware of: on mobile the extended Add link panel covers almost the whole article.

IMG_9611.PNG (1×640 px, 109 KB)

Thanks @Etonkovidova - this should not be possible in the actual UI as the link cards for the non-suggested links are meant to be disabled.