Page MenuHomePhabricator

[modern Vector] "Languages" list is not shown on the main page where local languages exist but noexternallanglinks is enabled
Closed, ResolvedPublic2 Estimated Story Points

Description

https://ru.wikipedia.org/wiki/Заглавная_страница?useskinversion=2
https://en.wikipedia.org/wiki/Main_Page?useskinversion=2
https://ko.wikipedia.org/wiki/위키백과:대문

Screenshot_2021-03-16 Main Page.png (844×1 px, 209 KB)

There should be a list of languages at the bottom left. Now it is not shown on the main page. It is shown on other pages in the wiki.

Screenshot_2021-03-16 Battle of Halmyros.png (587×1 px, 78 KB)

https://en.wikipedia.org/wiki/Template:Main_Page_interwikis https://www.wikidata.org/wiki/Q5296

The Vector skin has recently been changed https://www.mediawiki.org/wiki/MediaWiki_1.36/wmf.34#Vector
The list is shown in https://fr.wikipedia.org/wiki/Wikipédia:Accueil_principal

Due to the T273144 links now work differently with the "noexternallanglinks" https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Repository/Language_Switching_Research#Are_there_any_constraints_to_achieving_the_user_stories_above? T179140

How should wiki show featured links now or shouldn't they show them this way?

QA Steps

  • Visit https://en.wikipedia.beta.wmflabs.org/wiki/T277517 . This page has the noexternallanglinks in its wikitext, but also includes a local interlanguage link so that languages should still show.
  • Ensure that the language button is visible.
  • Clicking the language button shows a list containing "Simple English"

QA Results - Beta

ACStatusDetails
1T277517#7027770
2T277517#7027770

QA Results - Prod

ACStatusDetails
1T277517#7071114
2T277517#7071114

Event Timeline

Jdlrobson renamed this task from "Languages" list is not shown on the main page to [modern Vector] "Languages" list is not shown on the main page where local languages exist but noexternallanglinks is enabled.Mar 17 2021, 4:58 PM
Jdlrobson assigned this task to ovasileva.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

@Sunpriat2 to check I understand correctly:

If an editor adds {{noexternallanglinks}} to any page, the expectation is only Wikidata language links are disabled NOT all language links are disabled?

https://www.mediawiki.org/wiki/Wikibase/Installation/Advanced_configuration#noexternallanglinks

@Jdlrobson For a complete understanding, this was used as a tweak around what the list looks like. For example, there are 317 languages ​​on the main page, if you disable the checkbox "Use a compact language list, with languages relevant to you." in Preferences/Appearance, then these languages ​​will be 6300px in height. When {{noexternallanglinks}} was added, the long list from Wikidata disappeared, but the links left as local interwiki in the wikitext of the page remained and were shown in the sidebar in place of the languages.
It is planned that the languages will be in one button in the header https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Language_switching , but the main page does not have a header and it is unclear how the button and languages will look on the main page in the future.
Perhaps after the appearance of one button, the setting of disabling the short list will not affect the list in the modern Vector. But the setting will affect monobook and old Vector skins, where some gadgets work with a complete list, for example, moving up certain languages or replacing the names of languages from their writing to names in one local language.
Maybe now all wikis should use noexternallanglinks "as a function, with parameters" if this new change is important or it will work as written "Only the interlanguage links that are present in the wikitext will be used".

It is planned that the languages will be in one button in the header https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Language_switching , but the main page does not have a header and it is unclear how the button and languages will look on the main page in the future.

You can look at T276140 for some insight into this particular question.

Maybe now all wikis should use noexternallanglinks "as a function, with parameters" if this new change is important or it will work as written "Only the interlanguage links that are present in the wikitext will be used".

As implemented, {{noexternallanglinks}} is disabling all languages on the page. Now I understand this check better, I think the check should be removed completely. When the magic word is used it doesn't mean the page can't have languages it just means to ignore wikidata. That should not be a concern for Vector. It seems every page can have languages except special pages.

As implemented, {{noexternallanglinks}} is disabling all languages on the page.

Vector V2 is disabling all languages on the page.

Now I understand this check better, I think the check should be removed completely.

To be clear, you mean removing https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/ec6bca52eeb763c9bec9da7bd78f2e22300b82d5/includes/SkinVector.php#134, right? If so, then I think that this could be estimated and moved to Ready for Development immediately.

phuedx removed phuedx as the assignee of this task.Apr 7 2021, 9:17 AM
phuedx added a subscriber: phuedx.

Change 681720 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Remove 'noexternallanglinks' check from `canHaveLanguages`

https://gerrit.wikimedia.org/r/681720

nray claimed this task.
nray moved this task from Doing to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
nray added a subscriber: Edtadros.
nray added a subscriber: nray.

I need to add QA steps

Change 681720 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove 'noexternallanglinks' check from `canHaveLanguages`

https://gerrit.wikimedia.org/r/681720

nray updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/T277517 . This page has the noexternallanglinks in its wikitext, but also includes a local interlanguage link so that languages should still show.
✅ AC1: Ensure that the language button is visible.
✅ AC2: Clicking the language button shows a list containing "Simple English"

Screen Shot 2021-04-22 at 8.43.19 AM.png (687×1 px, 166 KB)

Test Result - prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/T277517 . This page has the noexternallanglinks in its wikitext, but also includes a local interlanguage link so that languages should still show.
✅ AC1: Ensure that the language button is visible.
✅ AC2: Clicking the language button shows a list containing "Simple English"

Screen Shot 2021-05-07 at 6.18.10 PM.png (979×1 px, 510 KB)

@nray just to be sure, TIL I could search wikitext. I used the following search string:

insource:/noexternallanglinks/

Please let me know if this is correct. I'm moving it to Ready for Signoff with you assigned.

Edtadros updated the task description. (Show Details)