Page MenuHomePhabricator
Create Task
Maniphest T277697

Improve language variant support in widgets
Open, LowPublicBUG REPORT
Actions

Description

I have noticed a few bugs around widgets and language variants, so this task encompasses revisiting widgets with an eye towards fixing any variant weirdness we see:

  • I noticed intermittently the POTD widget is the loading / gray state when the primary language is a variant. This seems worth investigating since Picture of the Day shouldn't be tied to a particular wiki language. I had also noticed it on 6.7.4 occasionally so this may not be variant-related.
  • The top read widget switches languages properly when a different variant becomes the app preferred language. However deeplinking to the article shows an incorrect language variant. (Test steps: Primary app language Serbian Latin, secondary language Serbian Cyrillic. Top read shows most text in Latin, but deep linking goes to an article in Cyrillic). Moved to https://phabricator.wikimedia.org/T278581
  • The top read widget is in a loading / gray state after updating from 6.7.4 and the primary language is a variant. Pulling to refresh on the Explore feed fixes this, but it would be nice if it worked right away.

Note I haven't tested iOS13 widgets or the On this Day iOS14 widget (both Chinese and Serbian show the "Your primary language does not support On this day" error state), so we should confirm there are no bugs with those too.

Related Objects
Search...

Event Timeline

Tsevener created this task.Mar 17 2021, 7:33 PM
Shizhao moved this task from Backlog to Apps/Tools/Services on the Chinese-Sites board.Mar 18 2021, 2:09 AM
• JMinor triaged this task as Low priority.Mar 18 2021, 7:45 PM

Per our meeting, lets focus on bullet 2 as our highest priority fix. If we can get that in, then we'll see what we can do about the lifecycle/grey screen/reloading issues.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 22 2021, 6:39 PM
Tsevener moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Mar 23 2021, 7:19 PM
• Dmantena claimed this task.Mar 23 2021, 8:29 PM
• Dmantena moved this task from Ready for Development to Doing on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Mar 23 2021, 10:46 PM
• Dmantena added a comment.Mar 26 2021, 6:05 PM

@Tsevener Following up on you mentioning proxying the language changes yesterday, so far it seems like the app itself makes calls with the appropriate Accept-Language header value when switching languages in app. I just want to confirm one thing: is the intent of the Accept-Language header value for requests in languages without explicit variants to use the iOS device's preferred languages?

For example, I notice when I have Spanish as my preferred app language, and my iOS device's preferred languages are English and Simplified Chinese, the request looks like this:

Host: es.wikipedia.org
Accept-Language: en, zh-hans;q=0.5
• Dmantena mentioned this in T278581: Apply user's preferred language variant to incoming links when applicable.Mar 26 2021, 7:45 PM
• Dmantena updated the task description. (Show Details)
• Dmantena removed • Dmantena as the assignee of this task.Mar 26 2021, 7:49 PM
• Dmantena moved this task from Doing to Tasks from Product Backlog on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.
• Dmantena subscribed.

Moved the direct/specific variant component of this into new task (https://phabricator.wikimedia.org/T278581), moving this task back.

Tsevener added a comment.Mar 26 2021, 8:09 PM

@Dmantena yep, at least that's how it was requesting before. The variant work @James_Dempsey did only changed Accept-Language headers in the case of hitting a wiki that supports variants. This was really just to limit changes we were making, but it seems like it could be possible to remove the header entirely from non-variant Wikis eventually. Here's a comment where we asked specifically about it. We decided to make the Accept-Language header simple for variant wikis (i.e. zh-hant rather than an exhaustive list), but left non-variant language requests as-is.

• Dmantena added a comment.Mar 27 2021, 12:46 AM

@Tsevener Cool - thanks!

• Dmantena added a comment.Mar 27 2021, 12:46 AM

This PR adds language variant support to the Top read widgets: https://github.com/wikimedia/wikipedia-ios/pull/3895

• Dmantena renamed this task from Support language variants in widgets to Improve language variant support in widgets.Mar 30 2021, 9:25 PM
• Dmantena added a parent task: T268677: Widget clean-up.
• Dmantena removed a project: iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower.
• JMinor closed subtask T278581: Apply user's preferred language variant to incoming links when applicable as Resolved.Apr 26 2021, 10:54 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 17 2023, 8:27 AM
Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptFeb 17 2023, 8:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL