Page MenuHomePhabricator
Create Task
Maniphest T282401

Add a link: icons in Arabic too close to text
Closed, ResolvedPublic
Actions

Assigned To
• mewoph
Authored By
MMiller_WMF
May 10 2021, 5:13 AM
Tags
Referenced Files
F34450630: enPref_arSys_after.png
May 11 2021, 5:53 PM
F34450629: arPref_enSys_after.png
May 11 2021, 5:53 PM
F34450621: enPref_arSys.png
May 11 2021, 5:41 PM
F34450619: arPref_enSys.png
May 11 2021, 5:41 PM
F34449449: Capture d’écran du 2021-05-10 20-53-52.png
May 10 2021, 7:55 PM
F34449435: Capture d’écran du 2021-05-10 20-44-10.png
May 10 2021, 7:55 PM
F34449434: Capture d’écran du 2021-05-10 20-48-05.png
May 10 2021, 7:55 PM
F34449436: Capture d’écran du 2021-05-10 20-46-40.png
May 10 2021, 7:55 PM
View All 10 Files
Subscribers
Aklapper
alaa
DED
Dyolf77_WMF
Etonkovidova
kostajh
• marcella
View All 17 Subscribers

Description

In Arabic Wikipedia, we see that the robot icon for the link suggestions is really up close to the text, with some extra whitespace being highlighted afterward:

image.png (134×300 px, 15 KB)

image.png (118×228 px, 6 KB)

Details

SubjectRepoBranchLines +/-
Add a link: explicitly set annotation icon's margin for mixed directionalitymediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+18 -0
Add a link: explicitly set annotation icon's margin for mixed directionalitymediawiki/extensions/GrowthExperimentsmaster+18 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.May 10 2021, 5:13 AM
Restricted Application added a subscriber: alaa. · View Herald TranscriptMay 10 2021, 5:13 AM
kostajh triaged this task as High priority.May 10 2021, 7:51 AM
kostajh lowered the priority of this task from High to Medium.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Backlog to May 10 - May 14 on the Add-Link board.May 10 2021, 1:23 PM
Dyolf77_WMF added a comment.May 10 2021, 7:55 PM

@MMiller_WMF for you information I tested with 3 different browsers (firefox, chrome and brave on GNU/linux), but it seems that the robot icon is normal if the language was Arabic:

Capture d’écran du 2021-05-10 20-46-40.png (231×492 px, 35 KB)

Capture d’écran du 2021-05-10 20-44-10.png (242×533 px, 28 KB)

Capture d’écran du 2021-05-10 20-48-05.png (294×595 px, 33 KB)

But I noticed the problem if the language was English/Latin:
Capture d’écran du 2021-05-10 20-53-52.png (272×538 px, 37 KB)

• mewoph subscribed.May 11 2021, 5:41 PM

ar preference + en system

arPref_enSys.png (768×1 px, 150 KB)

en preference + ar system

enPref_arSys.png (652×972 px, 108 KB)

• mewoph claimed this task.May 11 2021, 5:48 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 11 2021, 5:50 PM

Change 689191 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: explicitly set annotation icon's margin for mixed directionality

https://gerrit.wikimedia.org/r/689191

gerritbot added a project: Patch-For-Review.May 11 2021, 5:50 PM
• mewoph added a comment.May 11 2021, 5:53 PM

ar preference + en system (updated)

arPref_enSys_after.png (678×926 px, 111 KB)

en preference + ar system (updated)

enPref_arSys_after.png (658×942 px, 115 KB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 11 2021, 5:53 PM
gerritbot added a comment.May 12 2021, 9:45 AM

Change 689543 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: explicitly set annotation icon's margin for mixed directionality

https://gerrit.wikimedia.org/r/689543

kostajh moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 12 2021, 9:45 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 12 2021, 10:02 AM

Change 689191 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: explicitly set annotation icon's margin for mixed directionality

https://gerrit.wikimedia.org/r/689191

gerritbot added a comment.May 12 2021, 11:26 AM

Change 689543 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: explicitly set annotation icon's margin for mixed directionality

https://gerrit.wikimedia.org/r/689543

Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 12:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 12 2021, 11:54 PM
Etonkovidova closed this task as Resolved.May 18 2021, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits