Page MenuHomePhabricator

Make "Convert formatting to wikitext" feature non modal
Open, Needs TriagePublic

Description

This allows users who expect paste to be plain text to keep typing and ignore the prompt.

Existing experience:

Proposed experience:

T281010 proposes an even more minimal prompt but the proposal above is still a significant improvement.

Testing instructions

  • Copy some text with rich formatting, e.g. lists, links, bold, italic, ... (nb external links are stripped and therefore don't count)
  • Paste into 2017 WTE
  • Observe that the plain text paste is shown immediately along with a context for "Rich text detected". If "Convert to wikitext" is clicked the formatting is added.
  • The plain text or formatted text pasted should be identical to before with the modal popup (compare with a test on live)
  • Clicking, cursoring away or typing should make the "Rich text detected" context disappear.

Event Timeline

Change 551313 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] NWE: Always paste rich text as plain, and show context item to convert

https://gerrit.wikimedia.org/r/551313

Test wiki created on Patch Demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/b1cca98add/w/

ppelberg added subscribers: iamjessklein, Ryasmeen, ppelberg.

@iamjessklein moving this over to you for design review.

In parallel, @Esanders can you please add ===Testing instructions to the task description so that when it's ready for QA, @Ryasmeen nows what to test and the environment in which to test.

This looks good to me (same as my previous review, right?) If so +1

Change 551313 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] NWE: Always paste rich text as plain, and show context item to convert

https://gerrit.wikimedia.org/r/551313