I have around 4000 deleted edits on Commons. However, if I look at Special:DeletedContributions/AntiCompositeNumber, it shows only 3.
If I click "oldest" or "older 50", it shows 0:
AntiCompositeNumber | |
May 14 2021, 12:56 AM |
F34453359: image.png | |
May 14 2021, 12:56 AM |
F34453356: image.png | |
May 14 2021, 12:56 AM |
I have around 4000 deleted edits on Commons. However, if I look at Special:DeletedContributions/AntiCompositeNumber, it shows only 3.
If I click "oldest" or "older 50", it shows 0:
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Release | dancy | T281146 1.37.0-wmf.5 deployment blockers | ||
Resolved | • tstarling | T282844 Special:DeletedContributions shows no or almost no edits. |
This sounds very similar to T282183: Hiding own edits on watchlist and recentchanges results in hiding all IP edits (ref T278917).
If so, presumbly would have regressed in change 680820.
It's hitting the "could not be formatted" case:
<!-- Could not format Special:DeletedContribution row. -->
It's discarding this exception:
Caught exception Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $row->ar_page_id: must be given, or $page must be an existing page #0 /srv/mediawiki-staging/php-1.37.0-wmf.5/includes/Revision/RevisionArchiveRecord.php(86): Wikimedia\Assert\Assert::parameter(false, '$row->ar_page_i...', 'must be given, ...') #1 /srv/mediawiki-staging/php-1.37.0-wmf.5/includes/Revision/RevisionStore.php(1642): MediaWiki\Revision\RevisionArchiveRecord->__construct(Object(Title), Object(MediaWiki\User\UserIdentityValue), Object(CommentStoreComment), Object(stdClass), Object(MediaWiki\Revision\RevisionSlots), false) #2 /srv/mediawiki-staging/php-1.37.0-wmf.5/includes/Revision/RevisionStore.php(1540): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRowAndSlots(Object(stdClass), Object(MediaWiki\Revision\RevisionSlots), 0, Object(Title), Array) #3 /srv/mediawiki-staging/php-1.37.0-wmf.5/maintenance/eval.php(83) : eval()'d code(1): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRow(Object(stdClass)) #4 /srv/mediawiki-staging/php-1.37.0-wmf.5/maintenance/eval.php(83): eval() #5 /srv/mediawiki-staging/multiversion/MWScript.php(116): require_once('/srv/mediawiki-...') #6 {main}
So that is due to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/663218 , which was just merged.
* TimStarling does the "not my fault" dance*
Change 690807 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/core@master] Revert "Add assertions about page IDs during undeletion."
I'm looking at a doing a followup patch to DeletedContribsPager. I suppose anything that calls newRevisionFromArchiveRow() should be getting its field list from getArchiveQueryInfo(). But the RevisionFactory interface injected into DeletedContribsPager prevents that, since it lacks getArchiveQueryInfo() provided by the implementing class RevisionStore. What is the point of injecting a RevisionFactory if it is not possible to safely call any of its methods?
Change 690807 merged by Tim Starling:
[mediawiki/core@master] Revert "Add assertions about page IDs during undeletion."
Change 690796 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Add assertions about page IDs during undeletion."
Change 690796 merged by jenkins-bot:
[mediawiki/core@wmf/1.37.0-wmf.5] Revert "Add assertions about page IDs during undeletion."
Mentioned in SAL (#wikimedia-operations) [2021-05-14T03:16:30Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.5/includes/Revision/RevisionArchiveRecord.php: fix DeletedContributions breakage T282844 (duration: 01m 07s)
Mentioned in SAL (#wikimedia-operations) [2021-05-14T03:18:34Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.5/includes/page/PageArchive.php: T282844 (duration: 01m 07s)
Mentioned in SAL (#wikimedia-operations) [2021-05-14T03:20:08Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.5/includes/page/WikiPage.php: T282844 (duration: 01m 06s)
Change 693220 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):
[mediawiki/core@master] Add getQueryInfo to RevisionFactory
Change 693220 merged by jenkins-bot:
[mediawiki/core@master] Add getQueryInfo to RevisionFactory
Change 693380 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):
[mediawiki/core@master] Use getArchiveQueryInfo in DeletedContribsPager.
Change 693380 merged by jenkins-bot:
[mediawiki/core@master] Use getArchiveQueryInfo in DeletedContribsPager.