Page MenuHomePhabricator

Clean up obsolete ActorMigration usages for non-temp tables
Closed, ResolvedPublic

Description

ActorMigration is no longer required for the following fields:

  • ar_user
  • ar_user_text
  • img_user
  • img_user_text
  • oi_user
  • oi_user_text
  • fa_user
  • fa_user_text
  • rc_user
  • rc_user_text
  • log_user
  • log_user_text
  • ipb_by
  • ipb_by_text

They have been fully migrated to the actor table, so callers can just join on the actor table directly.

There are aliases in several getQueryInfo() calls which make them appear to exist, at least for the purposes of result fields. I think removing those aliases is going in the "too hard" basket for now. But removing the ActorMigration calls in core and hard-deprecating the use of ActorMigration for these fields is apparently feasible.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UserMergemaster+9 -9
mediawiki/coremaster+153 -231
mediawiki/coremaster+23 -6
mediawiki/coremaster+623 -503
mediawiki/extensions/CheckUsermaster+8 -11
mediawiki/extensions/OAuthmaster+11 -8
mediawiki/extensions/Flowmaster+49 -60
mediawiki/extensions/Thanksmaster+5 -5
mediawiki/extensions/FlaggedRevsmaster+7 -9
mediawiki/coremaster+42 -54
mediawiki/coremaster+113 -137
mediawiki/coremaster+103 -121
mediawiki/extensions/Translatemaster+13 -25
mediawiki/extensions/UploadWizardmaster+3 -5
mediawiki/coremaster+88 -105
mediawiki/coremaster+16 -18
mediawiki/coremaster+32 -26
mediawiki/extensions/Nukemaster+4 -8
mediawiki/extensions/AbuseFiltermaster+5 -13
mediawiki/coremaster+546 -685
mediawiki/coremaster+9 -11
mediawiki/coremaster+65 -100
mediawiki/coremaster+28 -20
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
Stalleddaniel
OpenNone
OpenNone
Opentstarling
Resolvedtstarling
ResolvedAnomie
ResolvedAnomie
ResolvedNone
DuplicateNone
ResolvedMarostegui
ResolvedBstorm
DeclinedNone
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedMarostegui
ResolvedBstorm
ResolvedMarostegui
ResolvedAnomie
ResolvedPRODUCTION ERRORCatrope
ResolvedPRODUCTION ERRORAnomie
ResolvedAnomie
ResolvedPRODUCTION ERRORAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedNiharika
ResolvedMaxSem
ResolvedMusikAnimal
ResolvedBstorm
ResolvedMilimetric
OpenNone
OpenNone
OpenNone
ResolvedJdforrester-WMF
ResolvedCiencia_Al_Poder
OpenNone
OpenNone
OpenNone
StalledNone
OpenNone

Event Timeline

Change 674997 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] [WIP] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/674997

Change 676176 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Actor migration cleanup for removeUnusedAccounts.php

https://gerrit.wikimedia.org/r/676176

Change 676177 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Actor migration cleanup for rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/676177

Change 676178 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Actor migration cleanup for SiteStatsUpdate

https://gerrit.wikimedia.org/r/676178

Change 676179 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Deprecate legacy actor migration keys and remove stage parameter

https://gerrit.wikimedia.org/r/676179

Change 676176 merged by jenkins-bot:

[mediawiki/core@master] Actor migration cleanup for removeUnusedAccounts.php

https://gerrit.wikimedia.org/r/676176

daniel added a subscriber: daniel.

Potting this on the Expedition board since this is closely related to the ActorNormalization work. Feel free to add us as reviewers on related patches.

Change 676177 merged by jenkins-bot:

[mediawiki/core@master] Actor migration cleanup for rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/676177

Change 676178 merged by jenkins-bot:

[mediawiki/core@master] Actor migration cleanup for SiteStatsUpdate

https://gerrit.wikimedia.org/r/676178

Change 680818 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration fields in DatabaseBlockStore

https://gerrit.wikimedia.org/r/680818

Change 680819 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration fields in reassignEdits.php

https://gerrit.wikimedia.org/r/680819

Change 680820 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration field "ar_user"

https://gerrit.wikimedia.org/r/680820

Change 680821 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration fields img_user/oi_user/fa_user

https://gerrit.wikimedia.org/r/680821

Change 680822 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration field "rc_user"

https://gerrit.wikimedia.org/r/680822

Change 680823 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/680823

Change 680824 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Stop using legacy ActionMigration field "ipb_by"

https://gerrit.wikimedia.org/r/680824

Change 674997 abandoned by Tim Starling:

[mediawiki/core@master] Stop using legacy ActorMigration fields

Reason:

superseded by 7 patch series in the same topic branch

https://gerrit.wikimedia.org/r/674997

According to https://www.mediawiki.org/wiki/Extension:Translate , the Translate extension has a "master" b/c policy going back to 1.33. But its extension.json says it requires 1.34+. Can @Nikerabbit please confirm that it is safe to drop ActorMigration calls in the Translate extension that are there to support MW 1.33 and earlier?

Change 680837 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/FlaggedRevs@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680837

Change 680867 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/AbuseFilter@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680867

Change 680869 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Flow@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680869

Change 680870 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/CheckUser@master] Stop using ActorMigration for log_user

https://gerrit.wikimedia.org/r/680870

Change 680872 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Translate@master] Stop using ActorMigration for rc_user and log_user

https://gerrit.wikimedia.org/r/680872

According to https://www.mediawiki.org/wiki/Extension:Translate , the Translate extension has a "master" b/c policy going back to 1.33. But its extension.json says it requires 1.34+. Can @Nikerabbit please confirm that it is safe to drop ActorMigration calls in the Translate extension that are there to support MW 1.33 and earlier?

The extension page is outdated. The MLEB BC policy is documented in https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Background. I have updated the extension page and will see if I can add updating it to our release checklist.

Change 680867 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680867

Change 681231 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Nuke@master] Stop using legacy ActorMigration field "rc_user"

https://gerrit.wikimedia.org/r/681231

Change 681233 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/OAuth@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/681233

Change 681236 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Thanks@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/681236

Change 681237 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/UploadWizard@master] Stop using the legacy ActorMigration field "img_user"

https://gerrit.wikimedia.org/r/681237

Change 681238 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/UserMerge@master] Remove references to user fields removed in MW 1.34

https://gerrit.wikimedia.org/r/681238

Change 681231 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Stop using legacy ActorMigration field "rc_user"

https://gerrit.wikimedia.org/r/681231

That concludes the code search for WMF deployed extensions. Any other extensions using the old ActorMigration fields will emit deprecation warnings after https://gerrit.wikimedia.org/r/c/mediawiki/core/+/676179 is merged.

Change 680818 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration fields in DatabaseBlockStore

https://gerrit.wikimedia.org/r/680818

Change 680819 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration fields in reassignEdits.php

https://gerrit.wikimedia.org/r/680819

Change 680820 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration field "ar_user"

https://gerrit.wikimedia.org/r/680820

Change 681237 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Stop using the legacy ActorMigration field "img_user"

https://gerrit.wikimedia.org/r/681237

Change 680872 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Stop using ActorMigration for rc_user and log_user

https://gerrit.wikimedia.org/r/680872

Change 681867 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Split a base class out of ActorMigration

https://gerrit.wikimedia.org/r/681867

Change 680821 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration fields img_user/oi_user/fa_user

https://gerrit.wikimedia.org/r/680821

Change 680822 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration field "rc_user"

https://gerrit.wikimedia.org/r/680822

Change 680823 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/680823

Change 680824 merged by jenkins-bot:

[mediawiki/core@master] Stop using legacy ActionMigration field "ipb_by"

https://gerrit.wikimedia.org/r/680824

Change 680837 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680837

Change 681236 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/681236

Change 680869 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Stop using legacy ActorMigration fields

https://gerrit.wikimedia.org/r/680869

Change 681233 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Stop using legacy ActorMigration field "log_user"

https://gerrit.wikimedia.org/r/681233

Change 680870 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Stop using ActorMigration for log_user

https://gerrit.wikimedia.org/r/680870

Change 681867 merged by jenkins-bot:

[mediawiki/core@master] Split a base class out of ActorMigration

https://gerrit.wikimedia.org/r/681867

Change 676179 merged by jenkins-bot:

[mediawiki/core@master] Deprecate legacy actor migration keys

https://gerrit.wikimedia.org/r/676179

Change 681238 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@master] Remove references to user fields removed in MW 1.34

https://gerrit.wikimedia.org/r/681238