Page MenuHomePhabricator

Implement fix : New comment highlight after following a notification persists in an unexpected way
Closed, ResolvedPublic

Description

New comment highlight after following a notification persists in an unexpected way.

Note: This ticket is a response to the behavior that was implemented in T281471.

User story

As someone who clicked a notification, from within Echo, about a new comment posted in a topic I am subscribed to, I want to be able to easily and quickly locate that comment on the talk page to which it is posted, so that I can understand the context in which the comment exists.

Revised behavior

Messages should disappear when a contributor clicks anywhere else on the page

Context

Comments about this were made by @Tacsipacsi after trying out an early demo, and by @Ryasmeen during pre-deployment QA:

Expected
[…]
The highlight […] never fades.

I don’t like when such highlights are “stuck” on the page until I navigate away; maybe I already do something entirely different. I like GitHub’s approach: when I open an anchor link (e.g. https://github.com/wikimedia/parsoid/pull/5#issuecomment-371981298), it highlights the comment, this highlight doesn’t fade out automatically, but it disappears immediately when I click anywhere on the page outside of that comment.

  1. When you click on a notification item, it takes you to the correct position on the talk page and highlights the comment. However, the highlight remains despite moving focus to elsewhere on the page. That means, even when you click on a Reply link for another comment on that talk page, the highlight stays for the notified comment, thus making it look confusing. It only goes away when a new comment gets highlighted after posting or after refreshing the page. cc: @iamjessklein

Done

  • Revised behavior is specified
  • Revised behavior is implemented

Event Timeline

@matmarex - is it possible to make the messages disappear when a contributor clicks anywhere else on the page?

Is that something that you can take a stab at doing @matmarex

iamjessklein renamed this task from New comment highlight after following a notification persists in an unexpected way to Implement fix : New comment highlight after following a notification persists in an unexpected way.Jul 1 2021, 7:55 PM
iamjessklein removed iamjessklein as the assignee of this task.
iamjessklein updated the task description. (Show Details)

Change 704187 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove comment highlight after user clicks anywhere on the page

https://gerrit.wikimedia.org/r/704187

Change 704187 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove comment highlight after user clicks anywhere on the page

https://gerrit.wikimedia.org/r/704187